Started by user sarbiansarbiansarbian2692d389e70f3c0d8b46628d54e9be89db16f5242e92d389e70f3c0d8b46628d54e9be89db16f5242eorigin/master92d389e70f3c0d8b46628d54e9be89db16f5242e92d389e70f3c0d8b46628d54e9be89db16f5242eorigin/master74dec5bc9229d335f1a7e131f3380449fe7febc9e5dec5bc9229d335f1a7e131f3380449fe7febc9e5refs/remotes/origin/masterdec5bc9229d335f1a7e131f3380449fe7febc9e5dec5bc9229d335f1a7e131f3380449fe7febc9e5refs/remotes/origin/masterdec5bc9229d335f1a7e131f3380449fe7febc9e5dec5bc9229d335f1a7e131f3380449fe7febc9e5refs/remotes/origin/masterhttps://github.com/sarbian/SmokeScreen.gitfalse#7418853247SmokeScreen #7474falsefalse749FAILURE1562502300934https://ksp.sarbian.com/jenkins/job/SmokeScreen/74/ModelMultiShurikenPersistFX.cs36560709235d8a12cd10e399cada8fd03ab6edbc1559945116000https://ksp.sarbian.com/jenkins/user/noreplynoreplynoreply@github.comFix for first model transform being misaligned because of different instantiation process. This is a fix for the problem discussed at https://github.com/KSP-RO/RealPlume-StockConfigs/pull/81 and https://github.com/PorktoberRevolution/ReStocked/issues/533 I'm not sure if this was always an issue that just went unnoticed, or if Unity changed something, but whatever the case it is now necessary to set worldPositionStays false. See https://docs.unity3d.com/ScriptReference/Transform.SetParent.html In the old ModelMultiParticlePersistFX all the emitterGameObjects were instantiated off the original GameObject model and then model was destroyed at the end. ModelMultiShurikenPersistFX instead opts to transform model for use as the first emitterGameObject and only instantiate more starting with the second transform if the engine has multiple transforms. However, with worldPositionStays true (the default) parent-relative position, scale and rotation are modified so the first transform may end up out of alignment with the subsequent ones. 2019-06-07 18:05:16 -040036560709235d8a12cd10e399cada8fd03ab6edbcFix for first model transform being misaligned because of differenteditModelMultiShurikenPersistFX.csPersistentKSPShurikenEmitter.csModelMultiShurikenPersistFX.csd2cb58255794c5d605d01fd68e8355cc3df379921562169252000https://ksp.sarbian.com/jenkins/user/patrykwyppatrykwyppatrykwyp@poczta.fmAdded a 'declutter'ing option to 'MODEL_MULTI_SHURIKEN_PERSIST' 2019-07-03 17:54:12 +0200d2cb58255794c5d605d01fd68e8355cc3df37992Added a 'declutter'ing option to 'MODEL_MULTI_SHURIKEN_PERSIST'editModelMultiShurikenPersistFX.cseditPersistentKSPShurikenEmitter.csSmokeScreenConfig.csPersistentKSPShurikenEmitter.cs.gitignoreSmokeScreenUI.csModelMultiShurikenPersistFX.cs9327fd748723a0fc7ebdd423a980d20a5e12c41c1562449602000https://ksp.sarbian.com/jenkins/user/patrykwyppatrykwyppatrykwyp@poczta.fmAdded an option to emit particles on LateUpdate: 'emitOnUpdate' 2019-07-06 23:46:42 +02009327fd748723a0fc7ebdd423a980d20a5e12c41cAdded an option to emit particles on LateUpdate: 'emitOnUpdate'editModelMultiShurikenPersistFX.cseditSmokeScreenConfig.csedit.gitignoreeditSmokeScreenUI.cseditPersistentKSPShurikenEmitter.csPersistentKSPShurikenEmitter.csModelMultiShurikenPersistFX.csbeee34f71f9fab96391c400d367b3b63e0a97e841562501259000https://ksp.sarbian.com/jenkins/user/sarbiansarbiansebastien.gaggini@gmail.comTabs, typos and foreach 2019-07-07 14:07:39 +0200beee34f71f9fab96391c400d367b3b63e0a97e84Tabs, typos and foreacheditModelMultiShurikenPersistFX.cseditPersistentKSPShurikenEmitter.csPersistentKSPShurikenEmitter.cs508c1f333421d8f2843842d1e1e7d84ff2624c731562501879000https://ksp.sarbian.com/jenkins/user/sarbiansarbiansebastien.gaggini@gmail.comVector math and order of operations See https://docs.unity3d.com/Manual/BestPracticeUnderstandingPerformanceInUnity7.html 2019-07-07 14:17:59 +0200508c1f333421d8f2843842d1e1e7d84ff2624c73Vector math and order of operationseditPersistentKSPShurikenEmitter.csPersistentKSPShurikenEmitter.csModelMultiShurikenPersistFX.cs5eaf1a31ca1ef9abc05375d023bd49fa320614e61562501907000https://ksp.sarbian.com/jenkins/user/sarbiansarbiansebastien.gaggini@gmail.comMore tabs/formating 2019-07-07 14:18:27 +02005eaf1a31ca1ef9abc05375d023bd49fa320614e6More tabs/formatingeditPersistentKSPShurikenEmitter.cseditModelMultiShurikenPersistFX.csPersistentKSPShurikenEmitter.csModelMultiShurikenPersistFX.csef6def419326f43b95398b7d474828f68790c6601562502233000https://ksp.sarbian.com/jenkins/user/sarbiansarbiansebastien.gaggini@gmail.comCouple more Vector math order 2019-07-07 14:23:53 +0200ef6def419326f43b95398b7d474828f68790c660Couple more Vector math ordereditPersistentKSPShurikenEmitter.cseditModelMultiShurikenPersistFX.csProperties/AssemblyInfo.csdec5bc9229d335f1a7e131f3380449fe7febc9e51562502259000https://ksp.sarbian.com/jenkins/user/sarbiansarbiansebastien.gaggini@gmail.comv2.8.2 2019-07-07 14:24:19 +0200dec5bc9229d335f1a7e131f3380449fe7febc9e5v2.8.2editProperties/AssemblyInfo.csgithttps://ksp.sarbian.com/jenkins/user/patrykwyppatrykwyphttps://ksp.sarbian.com/jenkins/user/sarbiansarbianhttps://ksp.sarbian.com/jenkins/user/noreplynoreply