Started by user sarbiansarbiansarbian53aa022badeb26e22a85b71f631f019190b617fb8aaa022badeb26e22a85b71f631f019190b617fb8aorigin/masteraa022badeb26e22a85b71f631f019190b617fb8aaa022badeb26e22a85b71f631f019190b617fb8aorigin/master1301347768e2c921359a2cbbbbabac8774795e1b7921347768e2c921359a2cbbbbabac8774795e1b792refs/remotes/origin/master1347768e2c921359a2cbbbbabac8774795e1b7921347768e2c921359a2cbbbbabac8774795e1b792refs/remotes/origin/master1347768e2c921359a2cbbbbabac8774795e1b7921347768e2c921359a2cbbbbabac8774795e1b792refs/remotes/origin/masterhttps://github.com/sarbian/ModuleManager.gitModuleManager-3.0.0.zipModuleManager-3.0.0.zipModuleManager-3.0.0.zipModuleManager.3.0.0.dllModuleManager.3.0.0.dllModuleManager.3.0.0.dllfalse#13047044997ModuleManager #130130falsefalse13056SUCCESS1512211920272https://ksp.sarbian.com/jenkins/user/jonnyothan/my-views/view/all/job/ModuleManager/130/CatAnimator.csModuleManager.csModuleManager.csprojMMPatchLoader.csCats/CatAnimator.csCats/CatManager.csmoduleManager.csCats/CatMover.csCats/CatOrbiter.csCatOrbiter.csCatMover.cse29c9cb61eb97df6e68bfea1bb6290d3ca49e97e1502371191000https://ksp.sarbian.com/jenkins/user/sarbiansarbiansebastien.gaggini@gmail.comBegin splitting files up (#76) * rename file most of it is MMPatchLoader so that's what it'll be * Remove corrupt #region It starts in one class and ends in another, I can't tell where it's really supposed to go * Move addon to its own file * Put cats in a box * Can has namespace * Promote business cat to manager * Unnecessary now * Old stuff 2017-08-10 15:19:51 +0200e29c9cb61eb97df6e68bfea1bb6290d3ca49e97eBegin splitting files up (#76)deleteCatMover.cseditModuleManager.csprojaddCats/CatAnimator.csaddCats/CatOrbiter.csaddCats/CatMover.csaddCats/CatManager.csdeleteCatOrbiter.csdeleteCatAnimator.csaddModuleManager.csdeletemoduleManager.csaddMMPatchLoader.csModuleManager.csproj1191841d6f532aa88c1b53441d1c88687d29fca21503176888000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comChange debug C# version to default 2017-08-19 14:08:08 -07001191841d6f532aa88c1b53441d1c88687d29fca2Change debug C# version to defaulteditModuleManager.csproj.gitignored2fd007db31b1e99879e99db56db1a10ad6b43e71503781786000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comVS, why u do dis? 2017-08-26 14:09:46 -0700d2fd007db31b1e99879e99db56db1a10ad6b43e7VS, why u do dis?edit.gitignoreCollections/ImmutableStack.csModuleManager.csproj536ff0cf0f06e0ae39b42920ce6189be99402d301503781872000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd ImmutableStack class 2017-08-26 14:11:12 -0700536ff0cf0f06e0ae39b42920ce6189be99402d30Add ImmutableStack classeditModuleManager.csprojaddCollections/ImmutableStack.csPatchContext.csModuleManager.csprojabba87ea8b94ea6cab2ab2a25828f7aed756fc8e1503803215000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd PatchContext struct 2017-08-26 20:06:55 -0700abba87ea8b94ea6cab2ab2a25828f7aed756fc8eAdd PatchContext structeditModuleManager.csprojaddPatchContext.csMMPatchLoader.cs05342e2e8914bb5bb221db1ab80921554b006cad1503803238000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUse ImmutableStack and PatchContext in MM 2017-08-26 20:07:18 -070005342e2e8914bb5bb221db1ab80921554b006cadUse ImmutableStack and PatchContext in MMeditMMPatchLoader.csMMPatchLoader.cs8685da977f63049acc2ab326cfb89e8c189049ff1503815654000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comRemove unused code Apparently had to do with texture replacer corruption, but not called anywhere 2017-08-26 23:34:14 -07008685da977f63049acc2ab326cfb89e8c189049ffRemove unused codeeditMMPatchLoader.csCollections/ImmutableStack.csExtensions/NodeStackExtensions.cs038db2345ec22b9592e1510b850a0f52080baac41503863834000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comImplement IEnumerable<T> 2017-08-27 12:57:14 -0700038db2345ec22b9592e1510b850a0f52080baac4Implement IEnumerable<T>editCollections/ImmutableStack.csaddExtensions/NodeStackExtensions.csCollections/ImmutableStack.cs946194e0bb9b1d8aca95ae0db677bcc84315b69a1503863846000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd Depth property 2017-08-27 12:57:26 -0700946194e0bb9b1d8aca95ae0db677bcc84315b69aAdd Depth propertyeditCollections/ImmutableStack.csMMPatchLoader.cs475aa6627978100bb3cf0aa24eacefea4779b0951503864192000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUse immutability in CheckNeeds 2017-08-27 13:03:12 -0700475aa6627978100bb3cf0aa24eacefea4779b095Use immutability in CheckNeedseditMMPatchLoader.csMMPatchLoader.cs27f788f0c06835ee965c6dae157fa97e95c0dd471503865606000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comForgot a using directive 2017-08-27 13:26:46 -070027f788f0c06835ee965c6dae157fa97e95c0dd47Forgot a using directiveeditMMPatchLoader.csMMPatchLoader.cs04df68375017aabfe67e589e050325357463952c1503865770000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comGed rid of Win64 specific code Doesn't matter anymore 2017-08-27 13:29:30 -070004df68375017aabfe67e589e050325357463952cGed rid of Win64 specific codeeditMMPatchLoader.csModuleManager.csproj340d113a0ab871b9df635e07db5d974dad4580921503986142000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comNeeds to be included in the project too 2017-08-28 22:55:42 -0700340d113a0ab871b9df635e07db5d974dad458092Needs to be included in the project tooeditModuleManager.csprojLogging/IBasicLogger.csLogging/ModLogger.csModuleManager.csprojb1a88634ddaf8a68bb0545cb062714096ad54c651503986293000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd logging interface 2017-08-28 22:58:13 -0700b1a88634ddaf8a68bb0545cb062714096ad54c65Add logging interfaceeditModuleManager.csprojaddLogging/IBasicLogger.csaddLogging/ModLogger.csPatchProgress.csModuleManager.csprojIPatchProgress.csad61311dcc5cd6c9ed2973e6470a9dc2a4797e1f1503988314000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract progress into its own object 2017-08-28 23:31:54 -0700ad61311dcc5cd6c9ed2973e6470a9dc2a4797e1fExtract progress into its own objecteditModuleManager.csprojaddIPatchProgress.csaddPatchProgress.csPatchContext.csModuleManager.csMMPatchLoader.cs76c998c61895de68f63f79fc57d0f64b30069d401503988584000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUse logger and progress Make some things static that no longer depend on the patch loader's state 2017-08-28 23:36:24 -070076c998c61895de68f63f79fc57d0f64b30069d40Use logger and progresseditPatchContext.cseditMMPatchLoader.cseditModuleManager.csMMPatchLoader.cs55fc4e6cc9dddb4b3c3e634002d893d9879234631503988761000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comRemove blocking option It's no longer used 2017-08-28 23:39:21 -070055fc4e6cc9dddb4b3c3e634002d893d987923463Remove blocking optioneditMMPatchLoader.csMMPatchLoader.csbf640f41e969b14922242a6a6fad577fa8f48b341503988970000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUse inline variable declaration 2017-08-28 23:42:50 -0700bf640f41e969b14922242a6a6fad577fa8f48b34Use inline variable declarationeditMMPatchLoader.csPatchProgress.csf751ed43916ed68a37c5f3d921c8caa41c67ca0e1504073317000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake log messages consistent 2017-08-29 23:08:37 -0700f751ed43916ed68a37c5f3d921c8caa41c67ca0eMake log messages consistenteditPatchProgress.csPatchProgress.csf03b5789becb4fb64dfd237ee12490bd2f1fa6541504073835000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake deletes and copies count toward patch count 2017-08-29 23:17:15 -0700f03b5789becb4fb64dfd237ee12490bd2f1fa654Make deletes and copies count toward patch counteditPatchProgress.csPatchProgress.csMMPatchLoader.csIPatchProgress.cs51b6f75a9e2462d28fc67967cfab16cfcb92b24d1504073930000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake names more accurate These are called before the patch is applied 2017-08-29 23:18:50 -070051b6f75a9e2462d28fc67967cfab16cfcb92b24dMake names more accurateeditMMPatchLoader.cseditPatchProgress.cseditIPatchProgress.csMMPatchLoader.cs8179c4405eca0916cd2edc3c9c4b8572cd6fd7c21504074195000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comSimplify null check 2017-08-29 23:23:15 -07008179c4405eca0916cd2edc3c9c4b8572cd6fd7c2Simplify null checkeditMMPatchLoader.csModuleManager/Cats/CatManager.csModuleManager/Properties/cat-1.pngIPatchProgress.csModuleManager/Properties/cat-12.pngModuleManager/Cats/CatOrbiter.csModuleManager/Properties/cat-10.pngpackages.configProperties/rainbow2.pngModuleManager.csprojModuleManager/Properties/cat-2.pngModuleManager/Cats/CatMover.csModuleManager/Logging/IBasicLogger.csModuleManager/Properties/cat-3.pngCats/CatManager.csCats/CatMover.csModuleManager/ModuleManager.csProperties/Resources.Designer.csCats/CatOrbiter.csProperties/cat-7.pngModuleManager/MMPatchLoader.csMMPatchLoader.csModuleManager/Properties/Resources.resxProperties/cat-6.pngModuleManager/CustomConfigsManager.csModuleManager/Properties/cat-4.pngModuleManager/ModuleManager.csprojModuleManager/Properties/cat-11.pngModuleManager.slnModuleManager.csModuleManager/Properties/Resources.Designer.csProperties/cat-5.pngProperties/AssemblyInfo.csModuleManager/Properties/rainbow2.pngProperties/cat-11.pngLogging/IBasicLogger.csExtensions/NodeStackExtensions.csModuleManager/Extensions/NodeStackExtensions.csModuleManager/Properties/cat-5.pngModuleManager/PatchContext.csModuleManager/PatchProgress.csModuleManager/Collections/ImmutableStack.csModuleManager/Properties/AssemblyInfo.csModuleManager/IPatchProgress.csProperties/cat-4.pngProperties/cat-12.pngCollections/ImmutableStack.csModuleManager/Cats/CatAnimator.csLogging/ModLogger.csModuleManager/Properties/cat-6.pngPatchProgress.csPatchContext.csModuleManager/Properties/cat-8.pngProperties/cat-8.pngProperties/cat-3.pngModuleManager/Logging/ModLogger.csModuleManager/packages.configCustomConfigsManager.csProperties/Resources.resxModuleManager/Properties/cat-7.pngProperties/cat-9.pngModuleManager/Properties/cat-9.pngCats/CatAnimator.csProperties/cat-2.pngProperties/cat-10.pngProperties/cat-1.png1a12a253a3addda038bfcd8fef7fa0b0f1840c0c1504326419000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.commove main project to its own directory Allows more to be added 2017-09-01 21:26:59 -07001a12a253a3addda038bfcd8fef7fa0b0f1840c0cmove main project to its own directoryaddModuleManager/Properties/cat-11.pngdeleteCollections/ImmutableStack.csaddModuleManager/Properties/cat-3.pngaddModuleManager/Cats/CatAnimator.csdeleteMMPatchLoader.csdeleteModuleManager.csaddModuleManager/Properties/cat-8.pngdeleteProperties/cat-3.pngaddModuleManager/Properties/cat-4.pngaddModuleManager/Properties/AssemblyInfo.csdeleteLogging/ModLogger.csaddModuleManager/Properties/cat-5.pngdeleteProperties/cat-4.pngdeleteProperties/cat-12.pngdeleteProperties/cat-11.pngdeletePatchProgress.csaddModuleManager/Properties/cat-1.pngaddModuleManager/Properties/cat-9.pngdeleteCustomConfigsManager.csdeleteProperties/cat-10.pngdeleteCats/CatAnimator.csdeleteExtensions/NodeStackExtensions.csdeleteProperties/Resources.Designer.csdeleteProperties/AssemblyInfo.csaddModuleManager/Properties/cat-10.pngdeleteProperties/cat-7.pngaddModuleManager/Cats/CatOrbiter.csaddModuleManager/ModuleManager.csaddModuleManager/Logging/ModLogger.csaddModuleManager/Properties/cat-12.pngaddModuleManager/Properties/Resources.resxdeletePatchContext.csaddModuleManager/PatchProgress.csaddModuleManager/Properties/cat-6.pngaddModuleManager/Properties/cat-2.pngdeleteProperties/cat-5.pngdeleteProperties/rainbow2.pngaddModuleManager/Properties/rainbow2.pngeditModuleManager.slndeleteProperties/cat-2.pngaddModuleManager/Logging/IBasicLogger.csdeleteProperties/Resources.resxdeleteCats/CatManager.csaddModuleManager/Properties/Resources.Designer.csaddModuleManager/PatchContext.csdeletepackages.configaddModuleManager/Cats/CatManager.csdeleteProperties/cat-8.pngaddModuleManager/ModuleManager.csprojaddModuleManager/IPatchProgress.csaddModuleManager/MMPatchLoader.csaddModuleManager/Properties/cat-7.pngaddModuleManager/Collections/ImmutableStack.csaddModuleManager/Cats/CatMover.csdeleteProperties/cat-9.pngdeleteLogging/IBasicLogger.csdeleteModuleManager.csprojdeleteCats/CatMover.csdeleteProperties/cat-6.pngdeleteProperties/cat-1.pngaddModuleManager/Extensions/NodeStackExtensions.csdeleteIPatchProgress.csaddModuleManager/packages.configaddModuleManager/CustomConfigsManager.csdeleteCats/CatOrbiter.csModuleManager/ModuleManager.csprojf02f418db54ecb0ef523e08063e3d6c59922f5fd1504326591000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comBetter output dir for debug 2017-09-01 21:29:51 -0700f02f418db54ecb0ef523e08063e3d6c59922f5fdBetter output dir for debugeditModuleManager/ModuleManager.csprojModuleManager/ModuleManager.csproj95362b529ab739ad6c62d9a0a50ca7eaf60fe7f11504326600000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDo not copy local 2017-09-01 21:30:00 -070095362b529ab739ad6c62d9a0a50ca7eaf60fe7f1Do not copy localeditModuleManager/ModuleManager.csprojModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/DummyTest.csModuleManagerTests/packages.configModuleManagerTests/Properties/AssemblyInfo.csModuleManager.slnc4ba1b943c1d94fdab9ac7e51c1ca5dc9f26e9181504327341000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd test project 2017-09-01 21:42:21 -0700c4ba1b943c1d94fdab9ac7e51c1ca5dc9f26e918Add test projectaddModuleManagerTests/Properties/AssemblyInfo.csaddModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/DummyTest.csaddModuleManagerTests/packages.configeditModuleManager.slnModuleManagerTests/ModuleManagerTests.csproje8159e1f9d8f8c292c827dc0e47f1b93431efcb21504327635000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd MM, Assembly-CSharp, UnityEngine refs 2017-09-01 21:47:15 -0700e8159e1f9d8f8c292c827dc0e47f1b93431efcb2Add MM, Assembly-CSharp, UnityEngine refseditModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/packages.config563a9427e4b3cd21da3ccaa3c38b149c2bb1ee9c1504328185000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd console runner Will be needed eventually 2017-09-01 21:56:25 -0700563a9427e4b3cd21da3ccaa3c38b149c2bb1ee9cAdd console runnereditModuleManagerTests/packages.configTestUtilsTests/Properties/AssemblyInfo.csTestUtilsTests/packages.configTestUtilsTests/TestUtilsTests.csprojTestUtilsTests/DummyTest.csModuleManager.slnTestUtils/Properties/AssemblyInfo.csTestUtils/TestUtils.csproja7f901e4654900cde28f93c15e27154d66a36e301504329367000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comYo dawg, I heard you like tests 2017-09-01 22:16:07 -0700a7f901e4654900cde28f93c15e27154d66a36e30Yo dawg, I heard you like testseditModuleManager.slnaddTestUtilsTests/Properties/AssemblyInfo.csaddTestUtils/Properties/AssemblyInfo.csaddTestUtilsTests/packages.configaddTestUtils/TestUtils.csprojaddTestUtilsTests/DummyTest.csaddTestUtilsTests/TestUtilsTests.csprojTestUtils/TestConfigNode.csTestUtilsTests/TestConfigNodeTest.csTestUtilsTests/TestUtilsTests.csprojTestUtils/TestUtils.csprojbe37f18a9cff44b889ecbc150b1a9b164b098c661504329802000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd TestConfigNode class Makes testing with ConfigNodes by simplifying creating them 2017-09-01 22:23:22 -0700be37f18a9cff44b889ecbc150b1a9b164b098c66Add TestConfigNode classeditTestUtils/TestUtils.csprojaddTestUtils/TestConfigNode.csaddTestUtilsTests/TestConfigNodeTest.cseditTestUtilsTests/TestUtilsTests.csprojModuleManagerTests/ModuleManagerTests.csproj278dad81e20c01e24505d4b9a48bd6c083eab8281504329872000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comReference TestUtils 2017-09-01 22:24:32 -0700278dad81e20c01e24505d4b9a48bd6c083eab828Reference TestUtilseditModuleManagerTests/ModuleManagerTests.csprojModuleManager/ModuleManager.csproj66e6612df80ebeac9c8cd23e37430ad527014a961504370462000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDon't reference a specific version of System 2017-09-02 09:41:02 -070066e6612df80ebeac9c8cd23e37430ad527014a96Don't reference a specific version of SystemeditModuleManager/ModuleManager.csprojModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Collections/ImmutableStackTest.csdf9c8ec4ead848c8ec2c7adeb13c7de8a81804771504370549000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd test for ImmutableStack 2017-09-02 09:42:29 -0700df9c8ec4ead848c8ec2c7adeb13c7de8a8180477Add test for ImmutableStackaddModuleManagerTests/Collections/ImmutableStackTest.cseditModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Extensions/NodeStackExtensionsTest.cs3e7100991cc45ea01bc78ee2f95f4cdd38cae0a61504393533000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd test for GetPath 2017-09-02 16:05:33 -07003e7100991cc45ea01bc78ee2f95f4cdd38cae0a6Add test for GetPatheditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/Extensions/NodeStackExtensionsTest.csModuleManagerTests/packages.configModuleManagerTests/ModuleManagerTests.csproj6e8285c5c6559339826804e599b90c3883284c761504402506000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd NSubstitute 2017-09-02 18:35:06 -07006e8285c5c6559339826804e599b90c3883284c76Add NSubstituteeditModuleManagerTests/packages.configeditModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Logging/ModLoggerTest.cs7398d4d1acbf2a8ed1db9dbc372fa94cf2c9cfa61504403632000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd tests for ModLogger 2017-09-02 18:53:52 -07007398d4d1acbf2a8ed1db9dbc372fa94cf2c9cfa6Add tests for ModLoggeraddModuleManagerTests/Logging/ModLoggerTest.cseditModuleManagerTests/ModuleManagerTests.csprojModuleManager/MMPatchLoader.csa5a095fc17b5e3a8c8b9c756a035d0bcbefdbec21504403972000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix an error 2017-09-02 18:59:32 -0700a5a095fc17b5e3a8c8b9c756a035d0bcbefdbec2Fix an erroreditModuleManager/MMPatchLoader.csTestUtilsTests/UrlBuilderTest.csTestUtilsTests/TestUtilsTests.csprojTestUtils/URLBuilder.csTestUtils/TestUtils.csproj564b226028542cf258b2792fb8612baab6b939dc1504492797000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd UrlBuilder Hackily creates UrlDir, UrlFile, UrlConfig for testing purposes 2017-09-03 19:39:57 -0700564b226028542cf258b2792fb8612baab6b939dcAdd UrlBuildereditTestUtils/TestUtils.csprojaddTestUtilsTests/UrlBuilderTest.cseditTestUtilsTests/TestUtilsTests.csprojaddTestUtils/URLBuilder.csModuleManager/MMPatchLoader.csModuleManager/IPatchProgress.csModuleManager/PatchProgress.csf190d17f56a1837204b62ad004da8005df624c2b1504500927000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comProgress shouldn't depend on deleted subnodes The number of needs unsatisfied nodes it should be counting is the number of root nodes that have been removed, not subnodes as well 2017-09-03 21:55:27 -0700f190d17f56a1837204b62ad004da8005df624c2bProgress shouldn't depend on deleted subnodeseditModuleManager/MMPatchLoader.cseditModuleManager/IPatchProgress.cseditModuleManager/PatchProgress.csModuleManager/IPatchProgress.csModuleManager/MMPatchLoader.csModuleManager/PatchProgress.csfca971747aa52e91653941cc5988cf7fa81195031504560261000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comThese should use actual URLs Since all the calls were just using .url anyway 2017-09-04 14:24:21 -0700fca971747aa52e91653941cc5988cf7fa8119503These should use actual URLseditModuleManager/IPatchProgress.cseditModuleManager/MMPatchLoader.cseditModuleManager/PatchProgress.csModuleManager/IPatchProgress.csModuleManager/MMPatchLoader.csModuleManager/PatchProgress.cs28e4ce78e513990712835ae12a6fe7d89f116ff71504561039000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comThese too 2017-09-04 14:37:19 -070028e4ce78e513990712835ae12a6fe7d89f116ff7These tooeditModuleManager/IPatchProgress.cseditModuleManager/MMPatchLoader.cseditModuleManager/PatchProgress.csModuleManager/PatchProgress.cs8d8463d17795917e4906dd469cae52e53c83bd601504587100000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMinor logging tweak 2017-09-04 21:51:40 -07008d8463d17795917e4906dd469cae52e53c83bd60Minor logging tweakeditModuleManager/PatchProgress.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/PatchProgressTest.csd37f58bc70332b6e5271fe69303d78c3aeb2b7411504587109000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd tests for PatchProgress 2017-09-04 21:51:49 -0700d37f58bc70332b6e5271fe69303d78c3aeb2b741Add tests for PatchProgressaddModuleManagerTests/PatchProgressTest.cseditModuleManagerTests/ModuleManagerTests.csprojModuleManager/MMPatchLoader.csca12c392d34244cddc3eca746d66070f90ae9eee1504845168000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comReplace DeepCopy with ConfigNode.CreateCopy It does 100% the same thing (and is recursive) 2017-09-07 21:32:48 -0700ca12c392d34244cddc3eca746d66070f90ae9eeeReplace DeepCopy with ConfigNode.CreateCopyeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs2b824899ff271c0681f7d03f527ec5b549a2f98a1504845418000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comInline out variable declarations Yay C#7 2017-09-07 21:36:58 -07002b824899ff271c0681f7d03f527ec5b549a2f98aInline out variable declarationseditModuleManager/MMPatchLoader.csModuleManager/CustomConfigsManager.csModuleManager/MMPatchLoader.csModuleManager/ModuleManager.cs47ce0154abaa501cb0cbcd10a709b9bd11bd370f1504845626000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comObey naming conventions 2017-09-07 21:40:26 -070047ce0154abaa501cb0cbcd10a709b9bd11bd370fObey naming conventionseditModuleManager/CustomConfigsManager.cseditModuleManager/ModuleManager.cseditModuleManager/MMPatchLoader.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/Command.csModuleManager/MMPatchLoader.csModuleManager/CommandParser.csModuleManager/ModuleManager.csprojModuleManagerTests/CommandParserTest.csa9a990d7f119d0d2d30f50f85a10d8398d27c2b11505358686000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comPull Command and ParseCommand out of MMPatchLoader Would be nice if enums allowed static methods 2017-09-13 20:11:26 -0700a9a990d7f119d0d2d30f50f85a10d8398d27c2b1Pull Command and ParseCommand out of MMPatchLoaderaddModuleManager/Command.csaddModuleManagerTests/CommandParserTest.csaddModuleManager/CommandParser.cseditModuleManager/MMPatchLoader.cseditModuleManager/ModuleManager.csprojeditModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManager/MMPatchLoader.csModuleManager/ModuleManager.csprojModuleManager/Extensions/ConfigNodeExtensions.csb43f79b20c2759797aa1ad6323331d3e5e834b851505358686000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract ShallowCopy "this" is the node you're copying to so that the extension method is only modifying "its" node 2017-09-13 20:11:26 -0700b43f79b20c2759797aa1ad6323331d3e5e834b85Extract ShallowCopyeditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csaddModuleManager/Extensions/ConfigNodeExtensions.cseditModuleManager/MMPatchLoader.cseditModuleManager/ModuleManager.csprojTestUtilsTests/UrlBuilderTest.csTestUtils/URLBuilder.cs534eee2d6cc93d7e3bf6a8899e201f674c957cb21505358686000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDon't create duplicates in UrlBuilder 2017-09-13 20:11:26 -0700534eee2d6cc93d7e3bf6a8899e201f674c957cb2Don't create duplicates in UrlBuildereditTestUtilsTests/UrlBuilderTest.cseditTestUtils/URLBuilder.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/Collections/ArrayEnumerator.csModuleManager/ModuleManager.csprojModuleManagerTests/Collections/ArrayEnumeratorTest.cs24f21435b3efc6e0064de654a679ec8d5afba2d31505362248000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd ArrayEnumerator Enumerates arrays in a garbage-free way 2017-09-13 21:10:48 -070024f21435b3efc6e0064de654a679ec8d5afba2d3Add ArrayEnumeratoraddModuleManager/Collections/ArrayEnumerator.csaddModuleManagerTests/Collections/ArrayEnumeratorTest.cseditModuleManagerTests/ModuleManagerTests.csprojeditModuleManager/ModuleManager.csprojModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/PatchListTest.csModuleManager/PatchList.csModuleManager/ModuleManager.csproj7138bbca48c127dda038d199b1518a0dfc84a0a51505365141000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comPatchList list of patches, 'nuff said 2017-09-13 21:59:01 -07007138bbca48c127dda038d199b1518a0dfc84a0a5PatchListeditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/PatchListTest.cseditModuleManager/ModuleManager.csprojaddModuleManager/PatchList.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/PatchExtractorTest.csModuleManager/ModuleManager.csprojModuleManager/PatchExtractor.cs9a55a65987f83afbc0d2df67b0c1e4c8d80a47e61505365320000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd PatchExtractor Extracts patches from the game database and sorts them 2017-09-13 22:02:00 -07009a55a65987f83afbc0d2df67b0c1e4c8d80a47e6Add PatchExtractoreditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/PatchExtractorTest.cseditModuleManager/ModuleManager.csprojaddModuleManager/PatchExtractor.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Extensions/UrlConfigExtensionsTest.csModuleManager/Extensions/UrlConfigExtensions.csModuleManager/ModuleManager.csproj90027c2abade9c7f035948bcfed4e6cddbc32e7e1505367118000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd SafeUrl extension method for UrlConfig Makes sure logging doesn't mess up, and fixes the weird quirk where a node with a name value ends up displaying that instead of its actual name 2017-09-13 22:31:58 -070090027c2abade9c7f035948bcfed4e6cddbc32e7eAdd SafeUrl extension method for UrlConfigaddModuleManager/Extensions/UrlConfigExtensions.cseditModuleManager/ModuleManager.csprojeditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/Extensions/UrlConfigExtensionsTest.csModuleManager/MMPatchLoader.csModuleManager/PatchExtractor.csModuleManager/PatchProgress.cs504354d57b7ffdb5128e48cdccccd9010ed22e631505369949000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUse SafeUrl in logging 2017-09-13 23:19:09 -0700504354d57b7ffdb5128e48cdccccd9010ed22e63Use SafeUrl in loggingeditModuleManager/MMPatchLoader.cseditModuleManager/PatchExtractor.cseditModuleManager/PatchProgress.csModuleManager/MMPatchLoader.cs331ab180365a6e243f4d2f192197b762a6820ba01505369949000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comRemove unused Doesn't really have any benefit 2017-09-13 23:19:09 -0700331ab180365a6e243f4d2f192197b762a6820ba0Remove unusededitModuleManager/MMPatchLoader.csModuleManagerTests/PatchExtractorTest.csModuleManager/PatchExtractor.csModuleManager/IPatchProgress.csModuleManagerTests/PatchProgressTest.csModuleManager/PatchProgress.cs3f8adeeb9ca45e6afd879602d8bf5176ba6f7a651505370312000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comLog when BEFORE or AFTER patch deleted This is pretty much equivalent to unsatisfied NEEDS, so it should be noted as such. Also log on an unsatisfied FOR, although this shouldn't happen (make it a warning) 2017-09-13 23:25:12 -07003f8adeeb9ca45e6afd879602d8bf5176ba6f7a65Log when BEFORE or AFTER patch deletededitModuleManager/PatchExtractor.cseditModuleManagerTests/PatchExtractorTest.cseditModuleManager/IPatchProgress.cseditModuleManagerTests/PatchProgressTest.cseditModuleManager/PatchProgress.csModuleManager/PatchList.csModuleManagerTests/PatchListTest.cs50346dc2f17ca43b5d47132e636df295ae95a9921505370333000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix case issues Mods may not be lowercase to begin with, need to handle this 2017-09-13 23:25:33 -070050346dc2f17ca43b5d47132e636df295ae95a992Fix case issueseditModuleManagerTests/PatchListTest.cseditModuleManager/PatchList.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/MMPatchLoader.csModuleManager/Extensions/StringExtensions.csModuleManager/ModuleManager.csprojModuleManagerTests/Extensions/StringExtensionsTest.cs99bc0bf583693dd2d83a94d93d1043bc28d037081505371760000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract IsBracketBalanced 2017-09-13 23:49:20 -070099bc0bf583693dd2d83a94d93d1043bc28d03708Extract IsBracketBalancedaddModuleManager/Extensions/StringExtensions.cseditModuleManager/MMPatchLoader.cseditModuleManager/ModuleManager.csprojaddModuleManagerTests/Extensions/StringExtensionsTest.cseditModuleManagerTests/ModuleManagerTests.csprojModuleManager/PatchExtractor.csModuleManagerTests/PatchExtractorTest.cse52a646ba73fb0639218d779508e7f110aaa1a3f1505372189000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comRemove bracket unbalanced nodes when sorting 2017-09-13 23:56:29 -0700e52a646ba73fb0639218d779508e7f110aaa1a3fRemove bracket unbalanced nodes when sortingeditModuleManager/PatchExtractor.cseditModuleManagerTests/PatchExtractorTest.csModuleManager/MMPatchLoader.cs8a8131017d7a26286b0b9f0bf8c64dc4da0d1ecc1505372266000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUnused method 2017-09-13 23:57:46 -07008a8131017d7a26286b0b9f0bf8c64dc4da0d1eccUnused methodeditModuleManager/MMPatchLoader.csModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManager/MMPatchLoader.csModuleManager/Extensions/ConfigNodeExtensions.cs5a468bea8d010631895e3e7bdbf40a5682748b131505374314000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comBring back DeepCopy Apparently KSP's default implementation fails on badly formed nodes 2017-09-14 00:31:54 -07005a468bea8d010631895e3e7bdbf40a5682748b13Bring back DeepCopyeditModuleManager/Extensions/ConfigNodeExtensions.cseditModuleManager/MMPatchLoader.cseditModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManager/MMPatchLoader.cs2e5854df9056d21d8efcac868de3d527e1ddd3191505374892000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix bad region 2017-09-14 00:41:32 -07002e5854df9056d21d8efcac868de3d527e1ddd319Fix bad regioneditModuleManager/MMPatchLoader.csModuleManager/PatchExtractor.csModuleManagerTests/PatchExtractorTest.cs9bd8253f26f0aaf03891cbef10d5a3c27de3ec6d1505449711000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake sure badly formed mod passes are an error 2017-09-14 21:28:31 -07009bd8253f26f0aaf03891cbef10d5a3c27de3ec6dMake sure badly formed mod passes are an erroreditModuleManager/PatchExtractor.cseditModuleManagerTests/PatchExtractorTest.csModuleManager/MMPatchLoader.csb0102431984947e8cff86aa4e7874b97119f23611505452838000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comThat's a bug 2017-09-14 22:20:38 -0700b0102431984947e8cff86aa4e7874b97119f2361That's a bugeditModuleManager/MMPatchLoader.csModuleManager/PatchExtractor.csModuleManager/Extensions/ConfigNodeExtensions.cscacc840da0d34307ef18796288eaafb30d2f32291505455034000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd some explanatory comments 2017-09-14 22:57:14 -0700cacc840da0d34307ef18796288eaafb30d2f3229Add some explanatory commentseditModuleManager/PatchExtractor.cseditModuleManager/Extensions/ConfigNodeExtensions.csModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManager/PatchExtractor.csModuleManager/Extensions/ConfigNodeExtensions.csc00735d7f3322aba14159706f996e7c45bc13dff1505455076000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUnnecessary using directives 2017-09-14 22:57:56 -0700c00735d7f3322aba14159706f996e7c45bc13dffUnnecessary using directiveseditModuleManager/PatchExtractor.cseditModuleManager/Extensions/ConfigNodeExtensions.cseditModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManager/MMPatchLoader.cs8d71ac691054fcc9e1fa236d4debbb2687be46321505455955000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUse sorted patches when applying Improves performance somewhat Verified that sorting patches takes almost no time even for a fairly large number of patches 2017-09-14 23:12:35 -07008d71ac691054fcc9e1fa236d4debbb2687be4632Use sorted patches when applyingeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csaa990db608166c83fd2fdbf9cd62fdba40788ff81505456264000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comRemove now-unnecessary try-catch There's already one around it and we no longer care about removing patches from the database at this stage 2017-09-14 23:17:44 -0700aa990db608166c83fd2fdbf9cd62fdba40788ff8Remove now-unnecessary try-catcheditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs3ca180142d1cc787cf92ceae683b64cbab04c9641505456479000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comReplace big if with guard clause Reduces indentation. Insert nodes shouldn't exist here anyway 2017-09-14 23:21:19 -07003ca180142d1cc787cf92ceae683b64cbab04c964Replace big if with guard clauseeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csec7c67cea50bc2b67ceadeac9b57ae3284816a241505456695000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comSimplify this It no longer has to look in actual passes here, so we can just use the name we want it to display. It does change the way it displays in the loading screen but that seems fine. 2017-09-14 23:24:55 -0700ec7c67cea50bc2b67ceadeac9b57ae3284816a24Simplify thiseditModuleManager/MMPatchLoader.csModuleManager/PatchExtractor.csModuleManager/MMPatchLoader.csModuleManagerTests/PatchExtractorTest.cs809831304b89671c1abf746c91f5d166dd5a1a861505458924000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comInvalid command = error on the patch extractor This seems like the right place to check it 2017-09-15 00:02:04 -0700809831304b89671c1abf746c91f5d166dd5a1a86Invalid command = error on the patch extractoreditModuleManagerTests/PatchExtractorTest.cseditModuleManager/PatchExtractor.cseditModuleManager/MMPatchLoader.csModuleManager/Extensions/StringExtensions.csModuleManager/MMPatchLoader.csModuleManagerTests/Extensions/StringExtensionsTest.cs180c2ee8434b8558072fca973299fa4821969f501505795809000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract RemoveWS 2017-09-18 21:36:49 -0700180c2ee8434b8558072fca973299fa4821969f50Extract RemoveWSeditModuleManagerTests/Extensions/StringExtensionsTest.cseditModuleManager/MMPatchLoader.cseditModuleManager/Extensions/StringExtensions.csModuleManager/MMPatchLoader.cs20a8afbeaf2aae223c407899649360715249d1021505801312000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix logging 2017-09-18 23:08:32 -070020a8afbeaf2aae223c407899649360715249d102Fix loggingeditModuleManager/MMPatchLoader.csModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManager/MMPatchLoader.csModuleManager/Extensions/ConfigNodeExtensions.cs35d89f8ab11a495ade7d25719e367b903127a4fa1505880666000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract PrettyPrint 2017-09-19 21:11:06 -070035d89f8ab11a495ade7d25719e367b903127a4faExtract PrettyPrinteditModuleManagerTests/Extensions/ConfigNodeExtensionsTest.cseditModuleManager/Extensions/ConfigNodeExtensions.cseditModuleManager/MMPatchLoader.csModuleManagerTests/Extensions/UrlConfigExtensionsTest.csModuleManager/Extensions/UrlConfigExtensions.csb52a80ea42e54cef13a90290c84eaeb4938236491505880746000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comGet rid of unnecesary using directives 2017-09-19 21:12:26 -0700b52a80ea42e54cef13a90290c84eaeb493823649Get rid of unnecesary using directiveseditModuleManagerTests/Extensions/UrlConfigExtensionsTest.cseditModuleManager/Extensions/UrlConfigExtensions.csModuleManager/MMPatchLoader.cs45a4c0c2222159a75c17415c16ef499c9e785c711506192297000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDon't run PrePatchInit if cache is being used Mod list is not necessary 2017-09-23 11:44:57 -070045a4c0c2222159a75c17415c16ef499c9e785c71Don't run PrePatchInit if cache is being usededitModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csd397a80a1157dbd74374fc9abd8a4f9e4b1ebbb31506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEliminate mods instance variable 2017-09-23 11:44:58 -0700d397a80a1157dbd74374fc9abd8a4f9e4b1ebbb3Eliminate mods instance variableeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs12780a636b8ace12511cfd71d8ec9302b3a152011506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUse method param rather than instance var Makes things easier to disentagle 2017-09-23 11:44:58 -070012780a636b8ace12511cfd71d8ec9302b3a15201Use method param rather than instance vareditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csb6b628cbed7806607a53eca2815e5e6be441eebf1506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEliminate Update Status will be updated when necessary anyway 2017-09-23 11:44:58 -0700b6b628cbed7806607a53eca2815e5e6be441eebfEliminate UpdateeditModuleManager/MMPatchLoader.csModuleManager/ModuleManager.cs7a40730ad2b966bcc0eccee8968af93d950efaa71506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEliminate redundant logging MMPatchLoader logs this info itself 2017-09-23 11:44:58 -07007a40730ad2b966bcc0eccee8968af93d950efaa7Eliminate redundant loggingeditModuleManager/ModuleManager.csModuleManager/MMPatchLoader.cs7e714a47ba7f158718e878ffcad83324f5b304531506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comKeep track of progress fraction independently 2017-09-23 11:44:58 -07007e714a47ba7f158718e878ffcad83324f5b30453Keep track of progress fraction independentlyeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs9236be107824be90bb56840dc20486aacb4fce7d1506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake StatusUpdate less general If cache is used, status only needs to be set once, no need to check it every time 2017-09-23 11:44:58 -07009236be107824be90bb56840dc20486aacb4fce7dMake StatusUpdate less generaleditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs8696143e2f3fd17dab5f92f81798141d4eeff69f1506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMove this What I get for trying to make a bunch of changes and then split them into small commits 2017-09-23 11:44:58 -07008696143e2f3fd17dab5f92f81798141d4eeff69fMove thiseditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs58d52d9572fce69dc234dbd7d1ba4f5b78e483131506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEliminate Progress instance variable Make it local, inject where needed 2017-09-23 11:44:58 -070058d52d9572fce69dc234dbd7d1ba4f5b78e48313Eliminate Progress instance variableeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs2645d222082cf9a5913590ac97ad6253c6ec92a31506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake more methods static All their instance variable dependencies have been eliminated 2017-09-23 11:44:58 -07002645d222082cf9a5913590ac97ad6253c6ec92a3Make more methods staticeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs824b077dfc46eee2998bbc56ea3fb28f7c96b7761506193169000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comThis is no longer necessary And will probably result in an error anyway 2017-09-23 11:59:29 -0700824b077dfc46eee2998bbc56ea3fb28f7c96b776This is no longer necessaryeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csac0a149a21efe830c2c8e7df2468526395b6fe6d1506193250000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMove exception handling outside of PrettyConfig Callers really shouldn't be trying to print the result if it resulted in an exception anyway 2017-09-23 12:00:50 -0700ac0a149a21efe830c2c8e7df2468526395b6fe6dMove exception handling outside of PrettyConfigeditModuleManager/MMPatchLoader.csModuleManagerTests/Extensions/ConfigNodeExtensionsTest.cseb18b601a5662c74712af4eea74c0c60cb7ca4671506194323000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comTweak test This isn't the case it was trying to test 2017-09-23 12:18:43 -0700eb18b601a5662c74712af4eea74c0c60cb7ca467Tweak testeditModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csTestUtilsTests/TestConfigNodeTest.csTestUtils/TestConfigNode.cs4fdfb8911e4b93c8f7c332e8fab077a8a1bc68611506224183000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAllow adding a ConfigNode.Value in initializer Not useful yet but maybe at some point 2017-09-23 20:36:23 -07004fdfb8911e4b93c8f7c332e8fab077a8a1bc6861Allow adding a ConfigNode.Value in initializereditTestUtilsTests/TestConfigNodeTest.cseditTestUtils/TestConfigNode.csModuleManagerTests/Extensions/UrlConfigExtensionsTest.csModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManager/MMPatchLoader.csModuleManager/Extensions/UrlConfigExtensions.csModuleManager/Extensions/ConfigNodeExtensions.cs70eca817c4d6d398c471b84d6ac0288ad4128e371506227482000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract PrettyConfig (for UrlConfig) 2017-09-23 21:31:22 -070070eca817c4d6d398c471b84d6ac0288ad4128e37Extract PrettyConfig (for UrlConfig)editModuleManager/Extensions/UrlConfigExtensions.cseditModuleManager/MMPatchLoader.cseditModuleManagerTests/Extensions/UrlConfigExtensionsTest.cseditModuleManager/Extensions/ConfigNodeExtensions.cseditModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManagerTests/Extensions/UrlConfigExtensionsTest.cs55308af509bf7b8c082c641528df24847a5b59821506231836000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd one more test 2017-09-23 22:43:56 -070055308af509bf7b8c082c641528df24847a5b5982Add one more testeditModuleManagerTests/Extensions/UrlConfigExtensionsTest.csModuleManager/MMPatchLoader.cs1a7d1e36c64d27318b002a5505f5959be21551d11506234508000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake CheckNeeds static Can now be extracted 2017-09-23 23:28:28 -07001a7d1e36c64d27318b002a5505f5959be21551d1Make CheckNeeds staticeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csbc451c5bdf2dafa43972a7930ee9483a5366e8611506234530000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comThis can already be static 2017-09-23 23:28:50 -0700bc451c5bdf2dafa43972a7930ee9483a5366e861This can already be staticeditModuleManager/MMPatchLoader.csModuleManager/Extensions/NodeStackExtensions.cs60cb30aa9e47a292bb08be23f46bfd8d8caaccc51506579014000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comRemove unnecessary Using 2017-09-27 23:10:14 -070060cb30aa9e47a292bb08be23f46bfd8d8caaccc5Remove unnecessary UsingeditModuleManager/Extensions/NodeStackExtensions.csModuleManagerTests/Extensions/UrlConfigExtensionsTest.csModuleManager/Extensions/UrlConfigExtensions.csa035b672edecdefd73f22fefef00c56a9270360f1506579216000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comImprove url and node printing * Handle null name explicitly * Include url when printing a UrlConfig 2017-09-27 23:13:36 -0700a035b672edecdefd73f22fefef00c56a9270360fImprove url and node printingeditModuleManager/Extensions/UrlConfigExtensions.cseditModuleManagerTests/Extensions/UrlConfigExtensionsTest.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/MMPatchLoader.csModuleManagerTests/NeedsCheckerTest.csModuleManager/NeedsChecker.csModuleManager/ModuleManager.csproj59a922067956db3ba32b6c248e537149584252961506579311000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract CheckNeeds Equality vs sameness mostly not tested for now, need to determine desired behavior 2017-09-27 23:15:11 -070059a922067956db3ba32b6c248e53714958425296Extract CheckNeedseditModuleManager/MMPatchLoader.csaddModuleManagerTests/NeedsCheckerTest.csaddModuleManager/NeedsChecker.cseditModuleManagerTests/ModuleManagerTests.csprojeditModuleManager/ModuleManager.csprojModuleManager/MMPatchLoader.cs784e7a80059574c888b4626a711359ce5463a5ae1506582649000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEnsure that final string printed to the screen is the actual status 2017-09-28 00:10:49 -0700784e7a80059574c888b4626a711359ce5463a5aeEnsure that final string printed to the screen is the actual statuseditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs13850b617ff7cdadd06a6bf943c7be22cf51b21a1506582681000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix up mod list logging * Use a string builder * Print assemblies in a nicer format (table) 2017-09-28 00:11:21 -070013850b617ff7cdadd06a6bf943c7be22cf51b21aFix up mod list loggingeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cscd3a4680ae697b04680743db8120434c42c135d01506652058000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUse Path.Combine It's more concise then concatenating with the separator char 2017-09-28 19:27:38 -0700cd3a4680ae697b04680743db8120434c42c135d0Use Path.CombineeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs901b5a5bc2035719e7e3da3fac1a354ee0cdea561506670295000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUnnecessary now 2017-09-29 00:31:35 -0700901b5a5bc2035719e7e3da3fac1a354ee0cdea56Unnecessary noweditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csa5b1547d4b6020ebad74d1e9cf2668fc9514e58e1506757571000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comImprove assembly list * Get rid of unused code * Include KSPAssembly version 2017-09-30 00:46:11 -0700a5b1547d4b6020ebad74d1e9cf2668fc9514e58eImprove assembly listeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs9cf00111aa40a9ae6a39ff6714613c5d68d200a51506826253000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAccidentally removed 2017-09-30 19:50:53 -07009cf00111aa40a9ae6a39ff6714613c5d68d200a5Accidentally removededitModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csModuleManager/PatchExtractor.csModuleManagerTests/PatchExtractorTest.csfde3fbc3782c23cbc0527e4128c49d08eb2cfbba1506883658000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMove tracking number of patches from mod list to sorting patches 2017-10-01 11:47:38 -0700fde3fbc3782c23cbc0527e4128c49d08eb2cfbbaMove tracking number of patcheseditModuleManager/MMPatchLoader.cseditModuleManagerTests/PatchExtractorTest.cseditModuleManager/PatchExtractor.csModuleManager/IPatchProgress.csModuleManager/PatchProgress.csf09622f190f8bb289df5229f6c45cf1a718858381506883815000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comPut progress counts in their own object Allows the same counts to be used with a different logger. Also remove unused setter for NeedsUnsatisfiedRootCount 2017-10-01 11:50:15 -0700f09622f190f8bb289df5229f6c45cf1a71885838Put progress counts in their own objecteditModuleManager/IPatchProgress.cseditModuleManager/PatchProgress.csModuleManager/MMPatchLoader.csce43104059244df30ebad90bfd928ab08ec4bd7d1506890154000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMove exception handling out of FIleSHA Callers should be aware of exceptions anyway 2017-10-01 13:35:54 -0700ce43104059244df30ebad90bfd928ab08ec4bd7dMove exception handling out of FIleSHAeditModuleManager/MMPatchLoader.csModuleManager/Utils/FileUtils.csModuleManager/ModuleManager.csprojModuleManager/MMPatchLoader.cs2dc9f9121be35ea1c30ada09c0dc0456cc7b0c1a1506892495000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract FileSHA Interacts with the file system so difficult to test unfortunately 2017-10-01 14:14:55 -07002dc9f9121be35ea1c30ada09c0dc0456cc7b0c1aExtract FileSHAeditModuleManager/ModuleManager.csprojeditModuleManager/MMPatchLoader.csaddModuleManager/Utils/FileUtils.csModuleManager/MMPatchLoader.cs6f2693924bbd2b85b5b4ea598a8437f0c9f2a49c1506894329000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix unassigned variable 2017-10-01 14:45:29 -07006f2693924bbd2b85b5b4ea598a8437f0c9f2a49cFix unassigned variableeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csf3352db53fdd4685c73706845d0fea5e435330ff1507083585000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake this extractable 2017-10-03 19:19:45 -0700f3352db53fdd4685c73706845d0fea5e435330ffMake this extractableeditModuleManager/MMPatchLoader.csModuleManager/ModListGenerator.csModuleManager/MMPatchLoader.csModuleManager/ModuleManager.csproje40426a633c90762f8fb034d561aefb388f576341507085540000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract GenerateModList Unfortunately interacts with AssemblyLoader and the file system so not really testable 2017-10-03 19:52:20 -0700e40426a633c90762f8fb034d561aefb388f57634Extract GenerateModListeditModuleManager/MMPatchLoader.cseditModuleManager/ModuleManager.csprojaddModuleManager/ModListGenerator.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Collections/MessageQueueTest.csModuleManager/ModuleManager.csprojModuleManager/Collections/MessageQueue.cs7a2e18da8eb06d4215e4d034984e98ca0e770af81507085733000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd MessageQueue 2017-10-03 19:55:33 -07007a2e18da8eb06d4215e4d034984e98ca0e770af8Add MessageQueueeditModuleManager/ModuleManager.csprojaddModuleManager/Collections/MessageQueue.cseditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/Collections/MessageQueueTest.csModuleManager/Logging/NormalMessage.csModuleManager/Logging/ILogMessage.csModuleManagerTests/Logging/NormalMessageTest.csModuleManager/Logging/QueueLogger.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/Logging/ExceptionMessage.csModuleManagerTests/Logging/ExceptionMessageTest.csModuleManager/ModuleManager.csprojModuleManagerTests/Logging/QueueLoggerTest.cs7d0c5878014b0e000808f8cb7b04d5665e280aa91507085739000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd QueueLogger and supporting classes Allows logging to a queue 2017-10-03 19:55:39 -07007d0c5878014b0e000808f8cb7b04d5665e280aa9Add QueueLogger and supporting classeseditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/Logging/NormalMessageTest.csaddModuleManagerTests/Logging/ExceptionMessageTest.cseditModuleManager/ModuleManager.csprojaddModuleManager/Logging/NormalMessage.csaddModuleManager/Logging/ExceptionMessage.csaddModuleManagerTests/Logging/QueueLoggerTest.csaddModuleManager/Logging/ILogMessage.csaddModuleManager/Logging/QueueLogger.csModuleManagerTests/PatchProgressTest.csModuleManager/PatchProgress.csd1975dbdd1bc2c61488644dd8e53ab92c557befd1507170155000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDon't keep track of non-root needs unsatisfied Isn't used anywhere 2017-10-04 19:22:35 -0700d1975dbdd1bc2c61488644dd8e53ab92c557befdDon't keep track of non-root needs unsatisfiededitModuleManagerTests/PatchProgressTest.cseditModuleManager/PatchProgress.csModuleManager/ModuleManager.csprojModuleManager/FatalErrorHandler.cs78d46359c18677bf34a7cbe0f1b510e2c2b9dc1e1507181240000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd FatalErrorHandler Allows us to display a message to the user and quit when an unrecoverable error occurs. Can't really be tested unfortunately. 2017-10-04 22:27:20 -070078d46359c18677bf34a7cbe0f1b510e2c2b9dc1eAdd FatalErrorHandleraddModuleManager/FatalErrorHandler.cseditModuleManager/ModuleManager.csprojModuleManagerTests/Threading/BackgroundTaskTest.csModuleManager/Threading/BackgroundTask.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Threading/TaskStatusTest.csModuleManager/Threading/TaskStatus.csModuleManager/Threading/ITaskStatus.csModuleManager/ModuleManager.csprojModuleManager/Threading/TaskStatusWrapper.cs172e2f3c845c42f1a4b4fb14182314891b00939a1507181921000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd background task support Allows a background task to be run and monitored, including if it exits due to an exception 2017-10-04 22:38:41 -0700172e2f3c845c42f1a4b4fb14182314891b00939aAdd background task supportaddModuleManagerTests/Threading/BackgroundTaskTest.csaddModuleManager/Threading/TaskStatus.cseditModuleManager/ModuleManager.csprojaddModuleManager/Threading/TaskStatusWrapper.csaddModuleManager/Threading/BackgroundTask.csaddModuleManagerTests/Threading/TaskStatusTest.cseditModuleManagerTests/ModuleManagerTests.csprojaddModuleManager/Threading/ITaskStatus.csModuleManager/IPatchProgress.csModuleManagerTests/PatchProgressTest.csModuleManager/Progress/IPatchProgress.csModuleManagerTests/Progress/PatchProgressTest.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/Progress/PatchProgress.csModuleManager/ModuleManager.csprojModuleManager/PatchProgress.cs7f9088719a5d478f5b5119fe7123ad06ba17a3401507182502000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comBegin creating Progress namespace 2017-10-04 22:48:22 -07007f9088719a5d478f5b5119fe7123ad06ba17a340Begin creating Progress namespacedeleteModuleManager/IPatchProgress.csdeleteModuleManager/PatchProgress.csaddModuleManager/Progress/PatchProgress.csaddModuleManagerTests/Progress/PatchProgressTest.cseditModuleManager/ModuleManager.csprojeditModuleManagerTests/ModuleManagerTests.csprojaddModuleManager/Progress/IPatchProgress.csdeleteModuleManagerTests/PatchProgressTest.csModuleManager/ModListGenerator.csModuleManager/MMPatchLoader.csModuleManagerTests/PatchExtractorTest.csModuleManager/PatchExtractor.csModuleManager/NeedsChecker.csModuleManager/Progress/IPatchProgress.csModuleManagerTests/Progress/PatchProgressTest.csModuleManagerTests/NeedsCheckerTest.csModuleManager/Progress/PatchProgress.csModuleManager/PatchContext.csb0f72c293f1ae36994c73c628eca346906ba59b51507182930000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFinish creating Progress namespace 2017-10-04 22:55:30 -0700b0f72c293f1ae36994c73c628eca346906ba59b5Finish creating Progress namespaceeditModuleManager/ModListGenerator.cseditModuleManager/PatchContext.cseditModuleManagerTests/NeedsCheckerTest.cseditModuleManager/PatchExtractor.cseditModuleManager/NeedsChecker.cseditModuleManagerTests/PatchExtractorTest.cseditModuleManagerTests/Progress/PatchProgressTest.cseditModuleManager/Progress/IPatchProgress.cseditModuleManager/MMPatchLoader.cseditModuleManager/Progress/PatchProgress.csModuleManagerTests/Progress/PatchProgressTest.csModuleManager/MMPatchLoader.cs3dbfbb1ad344efa8326def114cea916d685aefc01507182954000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUnnecessary directives 2017-10-04 22:55:54 -07003dbfbb1ad344efa8326def114cea916d685aefc0Unnecessary directiveseditModuleManager/MMPatchLoader.cseditModuleManagerTests/Progress/PatchProgressTest.csModuleManagerTests/NeedsCheckerTest.cs92ae91f6a8fef397d17f658e67538bc060a50d231507184003000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd needs test for and/or and capitalization 2017-10-04 23:13:23 -070092ae91f6a8fef397d17f658e67538bc060a50d23Add needs test for and/or and capitalizationeditModuleManagerTests/NeedsCheckerTest.csModuleManagerTests/Utils/CounterTest.csModuleManager/MMPatchLoader.csModuleManager/Progress/ProgressCounter.csModuleManager/Progress/IPatchProgress.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Progress/PatchProgressTest.csModuleManager/Utils/Counter.csModuleManager/Progress/PatchProgress.csModuleManager/ModuleManager.csproj6596b47e64677ee615718e6194d85e7ee67876591507186313000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comSeparate out progress counter Make it so that all the values can be incremented but not otherwise messed with. Allow a new progress tracker to be initialized that shares a counter with another but uses a different logger 2017-10-04 23:51:53 -07006596b47e64677ee615718e6194d85e7ee6787659Separate out progress countereditModuleManager/Progress/IPatchProgress.csaddModuleManager/Utils/Counter.cseditModuleManagerTests/ModuleManagerTests.csprojeditModuleManagerTests/Progress/PatchProgressTest.cseditModuleManager/Progress/PatchProgress.csaddModuleManager/Progress/ProgressCounter.csaddModuleManagerTests/Utils/CounterTest.cseditModuleManager/MMPatchLoader.cseditModuleManager/ModuleManager.csprojModuleManagerTests/Utils/CounterTest.csModuleManager/Utils/Counter.cs9a05e1b8902043f474c6d8bec4ed88da10ecf3281507187146000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEnsure Counter behaves like an int 2017-10-05 00:05:46 -07009a05e1b8902043f474c6d8bec4ed88da10ecf328Ensure Counter behaves like an inteditModuleManagerTests/Utils/CounterTest.cseditModuleManager/Utils/Counter.csModuleManager/Utils/Counter.cs97368004915876f14236207ea72b490ed85c86e71507187157000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMore unnecessary using 2017-10-05 00:05:57 -070097368004915876f14236207ea72b490ed85c86e7More unnecessary usingeditModuleManager/Utils/Counter.csModuleManagerTests/NeedsCheckerTest.csa1af72527f8c6356509a9e12cfecea7c76a865701507341464000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd test for ! (not) in :NEEDS 2017-10-06 18:57:44 -0700a1af72527f8c6356509a9e12cfecea7c76a86570Add test for ! (not) in :NEEDSeditModuleManagerTests/NeedsCheckerTest.csModuleManager/Command.csModuleManager/Progress/PatchProgress.csModuleManager/CommandParser.cs3a19ff8e6698a8f15660cc8cb2edacd3cb2fcf701507874242000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMore unnecessary using directives 2017-10-12 22:57:22 -07003a19ff8e6698a8f15660cc8cb2edacd3cb2fcf70More unnecessary using directiveseditModuleManager/Command.cseditModuleManager/CommandParser.cseditModuleManager/Progress/PatchProgress.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/MMPatchLoader.csModuleManagerTests/PatchApplierTest.csModuleManager/PatchApplier.csModuleManager/ModuleManager.csproje9c341a3e1fcfa5061a441bc9c1455acd60bf2751507874639000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract application of patches to its own thread Allows it to not be bound by logging which can be slow 2017-10-12 23:03:59 -0700e9c341a3e1fcfa5061a441bc9c1455acd60bf275Extract application of patches to its own threadaddModuleManager/PatchApplier.cseditModuleManagerTests/ModuleManagerTests.csprojeditModuleManager/MMPatchLoader.cseditModuleManager/ModuleManager.csprojaddModuleManagerTests/PatchApplierTest.csModuleManagerTests/Progress/PatchProgressTest.csModuleManager/Progress/PatchProgress.csb0e02e098a73aa19b1ef214f75aaaec2790d33ce1507875363000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comTest and fix PatchProgress.ProgressFraction Patches are now only counted after needs are checked, so this shouldn't consider needs unsatisfied nodes 2017-10-12 23:16:03 -0700b0e02e098a73aa19b1ef214f75aaaec2790d33ceTest and fix PatchProgress.ProgressFractioneditModuleManager/Progress/PatchProgress.cseditModuleManagerTests/Progress/PatchProgressTest.csModuleManager/MMPatchLoader.csba24af38d82bae9f5ed17dbf5115a7bed26441a81507943655000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comTweak 2017-10-13 18:14:15 -0700ba24af38d82bae9f5ed17dbf5115a7bed26441a8TweakeditModuleManager/MMPatchLoader.csModuleManager/PatchApplier.cs5fe79fd6b901eed0768ec3452ab65c97389b29711507966210000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comOnly convert to array once per pass This is expensive 2017-10-14 00:30:10 -07005fe79fd6b901eed0768ec3452ab65c97389b2971Only convert to array once per passeditModuleManager/PatchApplier.csModuleManager/PatchApplier.cs20e619287f1e8637476ada51f3a2470200b9b09b1507966210000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake node matching its own method Saves a level of indentation 2017-10-14 00:30:10 -070020e619287f1e8637476ada51f3a2470200b9b09bMake node matching its own methodeditModuleManager/PatchApplier.csModuleManagerTests/PatchApplierTest.csModuleManager/PatchApplier.cs244af1ac93d9c32a017666ff0e59e88d01c754491507966210000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comLoop only applies to edit patches Saves another indentation level. Also remove MM_PATCH_LOOP {} after done 2017-10-14 00:30:10 -0700244af1ac93d9c32a017666ff0e59e88d01c75449Loop only applies to edit patcheseditModuleManager/PatchApplier.cseditModuleManagerTests/PatchApplierTest.csModuleManagerTests/PatchApplierTest.csModuleManager/PatchApplier.cscdeb5f76dbf574eb5d310c71ea5cc605f70775081507966210000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDon't convert to an array at all It's not necessary. Also don't use switch - makes things cleaner. It's only 3 cases anyway 2017-10-14 00:30:10 -0700cdeb5f76dbf574eb5d310c71ea5cc605f7077508Don't convert to an array at alleditModuleManager/PatchApplier.cseditModuleManagerTests/PatchApplierTest.csModuleManager/MMPatchLoader.cs30eeb6f3c1a6ba1525b762ef6583f362b84e64ab1507966210000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEnsure that user gets updates during long passes The patcher can potentially generate log messages faster than the main thread can log them, causing frames that are noticeably long with no updates. This ensures that yields still happen then. Verified that this does not meaningfully affect performance. Previous tests suggest that the time wasted by waiting until the next frame is relatively small. 2017-10-14 00:30:10 -070030eeb6f3c1a6ba1525b762ef6583f362b84e64abEnsure that user gets updates during long passeseditModuleManager/MMPatchLoader.csModuleManager/PatchApplier.cs7e42de5a4e85a83ef6711885255a9f1b8b64aa0d1508305795000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comWithout switch, i is valid here 2017-10-17 22:49:55 -07007e42de5a4e85a83ef6711885255a9f1b8b64aa0dWithout switch, i is valid hereeditModuleManager/PatchApplier.csModuleManager/MMPatchLoader.csdc1a167b0874120c893962e097388bd8be2a84e31508306437000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEnsure time between each check of the log queue This prevents the queue from being locked too often, slowing down the patching thread 2017-10-17 23:00:37 -0700dc1a167b0874120c893962e097388bd8be2a84e3Ensure time between each check of the log queueeditModuleManager/MMPatchLoader.csModuleManager/PatchApplier.csec5310bdfa4ebd10da8de9e675a2150d3beff0981508306884000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comConvert to an array initially Apparently it saves a bit of time, and this won't be changed while patches run 2017-10-17 23:08:04 -0700ec5310bdfa4ebd10da8de9e675a2150d3beff098Convert to an array initiallyeditModuleManager/PatchApplier.csModuleManager/PatchApplier.cs7cc6c5130dc9fe86d6bed7158b1390be88fa5edf1508307776000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comHaving an actual array here no longer necessary 2017-10-17 23:22:56 -07007cc6c5130dc9fe86d6bed7158b1390be88fa5edfHaving an actual array here no longer necessaryeditModuleManager/PatchApplier.csModuleManager/PatchApplier.csbd82d53b561931630a1c5ddda4491e56ab46e7271508307795000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comApparently Linq slows things down I guess it matters at scale 2017-10-17 23:23:15 -0700bd82d53b561931630a1c5ddda4491e56ab46e727Apparently Linq slows things downeditModuleManager/PatchApplier.csModuleManager/PatchApplier.csce3893f9682c3dae5232491b3ee9f4f97a6e3b2a1508310796000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comImprove access of name a bit Looks like GetValue("name") has a bit of overhead, instead we can check if the UrlConfig's type == name 2017-10-18 00:13:16 -0700ce3893f9682c3dae5232491b3ee9f4f97a6e3b2aImprove access of name a biteditModuleManager/PatchApplier.csModuleManager/PatchApplier.cs203ad88debd4cd772d754da569e35d0efd2419431508312589000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMove loop out of loop This is all a bit loopy 2017-10-18 00:43:09 -0700203ad88debd4cd772d754da569e35d0efd241943Move loop out of loopeditModuleManager/PatchApplier.csTestUtils/UrlBuilder.csTestUtils/URLBuilder.cs73f7b397ab6cc0930be850a9f8c33dc86a1b58dc1510476109000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comcase should match filename matters on some filesystems 2017-11-12 00:41:49 -080073f7b397ab6cc0930be850a9f8c33dc86a1b58dccase should match filenamedeleteTestUtils/URLBuilder.csaddTestUtils/UrlBuilder.csModuleManager/Properties/AssemblyInfo.cs2caefbd81811147d23444796b5caffdb38ce07ba1512211138000https://ksp.sarbian.com/jenkins/user/sarbiansarbiansebastien.gaggini@gmail.comv3.0.0 for KSP 1.3.1 2017-12-02 11:38:58 +01002caefbd81811147d23444796b5caffdb38ce07bav3.0.0 for KSP 1.3.1editModuleManager/Properties/AssemblyInfo.csgithttps://ksp.sarbian.com/jenkins/user/joeydwongjoeydwonghttps://ksp.sarbian.com/jenkins/user/sarbiansarbian