Started by user sarbiansarbiansarbian53aa022badeb26e22a85b71f631f019190b617fb8aaa022badeb26e22a85b71f631f019190b617fb8aorigin/masteraa022badeb26e22a85b71f631f019190b617fb8aaa022badeb26e22a85b71f631f019190b617fb8aorigin/master14400216d33dcf53034d6c4e593effd84d67e341c4900216d33dcf53034d6c4e593effd84d67e341c49refs/remotes/origin/master00216d33dcf53034d6c4e593effd84d67e341c4900216d33dcf53034d6c4e593effd84d67e341c49refs/remotes/origin/master00216d33dcf53034d6c4e593effd84d67e341c4900216d33dcf53034d6c4e593effd84d67e341c49refs/remotes/origin/masterhttps://github.com/sarbian/ModuleManager.gitModuleManager-3.1.1.zipModuleManager-3.1.1.zipModuleManager-3.1.1.zipModuleManager.3.1.1.dllModuleManager.3.1.1.dllModuleManager.3.1.1.dllfalse#14448814997ModuleManager #144144falsefalse144308SUCCESS1542047972810https://ksp.sarbian.com/jenkins/user/jonnyothan/my-views/view/all/job/ModuleManager/144/- ModuleManager/MMPatchLoader.cs7ea256db1aa3c2e961d0178307fe9561f7206d0d1540175007000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake patch stopwatch local
It's not needed outside of ProcessPatch(), which contains everything it
needs to time
2018-10-21 19:23:27 -07007ea256db1aa3c2e961d0178307fe9561f7206d0dMake patch stopwatch localeditModuleManager/MMPatchLoader.cs
- ModuleManager/MMPatchLoader.cs8056f597afe14208b0ff9dd133cf9b8eb9b7c3411540175007000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake useCache local
Really only needed for a few lines in ProcessPatch()
2018-10-21 19:23:27 -07008056f597afe14208b0ff9dd133cf9b8eb9b7c341Make useCache localeditModuleManager/MMPatchLoader.cs
- ModuleManagerTests/PatchExtractorTest.csModuleManagerTests/PatchTest.csModuleManager/PatchExtractor.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/Patch.csModuleManager/PatchList.csModuleManagerTests/PatchApplierTest.csModuleManager/PatchApplier.csModuleManager/ModuleManager.csproj02bd5817ec393dbecc9cc1eb0143aed2b53897231540175570000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake Patch an object
Saves having to parse things multiple times, error/info messages can now
show the original name (except NEEDS, will be worked on). More
functionality will be added to this class in future commits.
2018-10-21 19:32:50 -070002bd5817ec393dbecc9cc1eb0143aed2b5389723Make Patch an objecteditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/PatchTest.cseditModuleManagerTests/PatchExtractorTest.cseditModuleManager/PatchList.csaddModuleManager/Patch.cseditModuleManagerTests/PatchApplierTest.cseditModuleManager/PatchApplier.cseditModuleManager/PatchExtractor.cseditModuleManager/ModuleManager.csproj
- ModuleManager/PatchExtractor.cs9d37955474438a38696ca0b15ae8dc8c451982d11540175570000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comSimplify a bit
2018-10-21 19:32:50 -07009d37955474438a38696ca0b15ae8dc8c451982d1Simplify a biteditModuleManager/PatchExtractor.cs
- ModuleManager/PatchExtractor.cs54c48ffa3ffab3939ec6895ef15756ef19339c0f1540175570000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtra semicolon
2018-10-21 19:32:50 -070054c48ffa3ffab3939ec6895ef15756ef19339c0fExtra semicoloneditModuleManager/PatchExtractor.cs
- ModuleManager/MMPatchLoader.csModuleManagerTests/PatchExtractorTest.csModuleManager/PatchExtractor.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/PatchListTest.csModuleManager/PatchList.csModuleManager/Collections/ArrayEnumerator.csModuleManager/Pass.csModuleManagerTests/PatchApplierTest.csModuleManager/PatchApplier.csModuleManager/ModuleManager.csprojModuleManagerTests/PassTest.cse9411608c888b47d128865beedf047b3c622139b1540175713000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract interface for PatchList, modify PatchExtractor
PatchExtractor did too much at once, it shouldn't enumerate and extract
at the same time (still some work to be done there...). PatchList now
has a clearer interface and obscures more of the details - iterating
through patches is now handled by it rater than PatchApplier
2018-10-21 19:35:13 -0700e9411608c888b47d128865beedf047b3c622139bExtract interface for PatchList, modify PatchExtractoreditModuleManagerTests/PatchExtractorTest.cseditModuleManagerTests/ModuleManagerTests.csprojeditModuleManager/PatchList.cseditModuleManager/Collections/ArrayEnumerator.cseditModuleManager/PatchApplier.cseditModuleManager/ModuleManager.csprojaddModuleManager/Pass.csaddModuleManagerTests/PassTest.cseditModuleManagerTests/PatchListTest.cseditModuleManager/MMPatchLoader.cseditModuleManager/PatchExtractor.cseditModuleManagerTests/PatchApplierTest.cs
- ModuleManager/MMPatchLoader.csfef311054bbd8b0298e7af79e09acd935a4409d31540175713000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAllow null value in wildcard match
Allows for instance :HAS[#someValue] instead of :HAS[#someValue[*]]
2018-10-21 19:35:13 -0700fef311054bbd8b0298e7af79e09acd935a4409d3Allow null value in wildcard matcheditModuleManager/MMPatchLoader.cs
- ModuleManagerTests/PatchExtractorTest.csModuleManagerTests/PatchTest.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/NodeMatcher.csModuleManager/Patch.csModuleManager/ModuleManager.csprojModuleManager/PatchApplier.csModuleManagerTests/NodeMatcherTest.cse134c5049ff49671538e6a64e9e494bf3f241a0b1540175713000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract node matcher
Will eventually be useful in modifying nodes too, but not without some
refactoring. For now it is only used on root patches.
2018-10-21 19:35:13 -0700e134c5049ff49671538e6a64e9e494bf3f241a0bExtract node matchereditModuleManager/ModuleManager.csprojeditModuleManager/PatchApplier.cseditModuleManagerTests/PatchExtractorTest.csaddModuleManager/NodeMatcher.cseditModuleManagerTests/ModuleManagerTests.csprojeditModuleManager/Patch.cseditModuleManagerTests/PatchTest.csaddModuleManagerTests/NodeMatcherTest.cs
- ModuleManager/Patches/DeletePatch.csModuleManagerTests/PatchExtractorTest.csModuleManager/Patches/EditPatch.csModuleManagerTests/Patches/PatchCompilerTest.csModuleManager/PatchExtractor.csModuleManager/Patches/IPatch.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Patches/EditPatchTest.csModuleManagerTests/Patches/CopyPatchTest.csModuleManager/Patch.csModuleManager/Pass.csModuleManager/PatchList.csModuleManagerTests/Patches/DeletePatchTest.csModuleManagerTests/PatchTest.csModuleManager/Patches/PatchCompiler.csModuleManagerTests/PatchListTest.csModuleManagerTests/PatchApplierTest.csModuleManager/ModuleManager.csprojModuleManager/PatchApplier.csModuleManagerTests/PassTest.csModuleManager/Patches/CopyPatch.cs53d238a7ccc585c66ef21536fa5dd62fbea703281540175811000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract IPatch interface, split up root patches
2018-10-21 19:36:51 -070053d238a7ccc585c66ef21536fa5dd62fbea70328Extract IPatch interface, split up root patcheseditModuleManager/ModuleManager.csprojdeleteModuleManager/Patch.csaddModuleManager/Patches/DeletePatch.cseditModuleManagerTests/ModuleManagerTests.csprojeditModuleManagerTests/PatchExtractorTest.cseditModuleManager/PatchApplier.cseditModuleManager/PatchExtractor.cseditModuleManager/Pass.cseditModuleManagerTests/PatchListTest.csaddModuleManagerTests/Patches/EditPatchTest.csaddModuleManager/Patches/IPatch.cseditModuleManagerTests/PassTest.csaddModuleManager/Patches/EditPatch.csdeleteModuleManagerTests/PatchTest.csaddModuleManagerTests/Patches/DeletePatchTest.cseditModuleManager/PatchList.csaddModuleManagerTests/Patches/CopyPatchTest.csaddModuleManager/Patches/PatchCompiler.csaddModuleManagerTests/Patches/PatchCompilerTest.csaddModuleManager/Patches/CopyPatch.cseditModuleManagerTests/PatchApplierTest.cs
- ModuleManagerTests/PatchListTest.csModuleManagerTests/Patches/PatchCompilerTest.csModuleManagerTests/PassTest.csModuleManagerTests/NodeMatcherTest.csffbabbbdbeb035211853584a4d7ed43832c58dd01540175811000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix tests depending on line endings
Since we're already asserting on the ParamName, we can trust that the
2nd part of the message will be there and not test it.
2018-10-21 19:36:51 -0700ffbabbbdbeb035211853584a4d7ed43832c58dd0Fix tests depending on line endingseditModuleManagerTests/PatchListTest.cseditModuleManagerTests/Patches/PatchCompilerTest.cseditModuleManagerTests/NodeMatcherTest.cseditModuleManagerTests/PassTest.cs
- ModuleManager/Progress/ProgressCounter.csc91258096cc0c5d3fb79a08ccfa30eee950e89391540175811000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comWhitespace
2018-10-21 19:36:51 -0700c91258096cc0c5d3fb79a08ccfa30eee950e8939WhitespaceeditModuleManager/Progress/ProgressCounter.cs
- ModuleManagerTests/Progress/PatchProgressTest.csModuleManager/MMPatchLoader.csModuleManager/Progress/PatchProgress.csModuleManager/Progress/ProgressCounter.csModuleManager/Progress/IPatchProgress.cs7b230976b88f11380d84ad3d6f224d0c6a9042b51540175811000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAllow warnings
Cache generation can proceed but the user will be alerted.
2018-10-21 19:36:51 -07007b230976b88f11380d84ad3d6f224d0c6a9042b5Allow warningseditModuleManager/MMPatchLoader.cseditModuleManager/Progress/PatchProgress.cseditModuleManager/Progress/ProgressCounter.cseditModuleManager/Progress/IPatchProgress.cseditModuleManagerTests/Progress/PatchProgressTest.cs
- ModuleManager/Collections/ArrayEnumerator.csModuleManagerTests/Collections/ArrayEnumeratorTest.cs99984913ac564b5a06860a4094bbafe4ff3354501540175811000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake ArrayEnumerator more versatile
Now optionally accepts start index and length
2018-10-21 19:36:51 -070099984913ac564b5a06860a4094bbafe4ff335450Make ArrayEnumerator more versatileeditModuleManager/Collections/ArrayEnumerator.cseditModuleManagerTests/Collections/ArrayEnumeratorTest.cs
- ModuleManager/Tags/TagListParser.csModuleManager/Tags/TagList.csModuleManagerTests/Tags/TagListParserTest.csModuleManager/Tags/Tag.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Tags/TagListTest.csModuleManagerTests/Tags/TagTest.csModuleManager/ModuleManager.csproj7d994ad71842dd85e4c48efcdeed075d8ed09dd31540175811000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comTag, TagList, TagListParser
A lot of things in MM are structured like :tag[value]trailer and this
formalizes that structure
2018-10-21 19:36:51 -07007d994ad71842dd85e4c48efcdeed075d8ed09dd3Tag, TagList, TagListParsereditModuleManagerTests/ModuleManagerTests.csprojaddModuleManager/Tags/TagList.csaddModuleManager/Tags/TagListParser.csaddModuleManagerTests/Tags/TagListTest.csaddModuleManager/Tags/Tag.cseditModuleManager/ModuleManager.csprojaddModuleManagerTests/Tags/TagListParserTest.csaddModuleManagerTests/Tags/TagTest.cs
- ModuleManagerTests/PatchExtractorTest.csModuleManager/Patches/EditPatch.csModuleManagerTests/Patches/PassSpecifiers/AfterPassSpecifierTest.csModuleManager/PatchExtractor.csModuleManagerTests/Patches/PassSpecifiers/InsertPassSpecifierTest.csModuleManager/Progress/IPatchProgress.csModuleManager/Patches/IPatch.csModuleManagerTests/Patches/EditPatchTest.csModuleManagerTests/Patches/PassSpecifiers/ForPassSpecifierTest.csModuleManagerTests/Patches/CopyPatchTest.csModuleManagerTests/Patches/PassSpecifiers/FinalPassSpecifierTest.csModuleManager/Patches/PassSpecifiers/FirstPassSpecifier.csModuleManager/Patches/ProtoPatch.csModuleManager/Patches/ProtoPatchBuilder.csModuleManagerTests/Patches/ProtoPatchBuilderTest.csModuleManagerTests/Patches/DeletePatchTest.csModuleManager/Patches/PassSpecifiers/LegacyPassSpecifier.csModuleManager/Patches/PassSpecifiers/BeforePassSpecifier.csModuleManager/Patches/PatchCompiler.csModuleManagerTests/Progress/PatchProgressTest.csModuleManagerTests/PatchListTest.csModuleManagerTests/Patches/PassSpecifiers/FirstPassSpecifierTest.csModuleManager/Patches/PassSpecifiers/InsertPassSpecifier.csModuleManager/Patches/PassSpecifiers/ForPassSpecifier.csModuleManager/Patches/DeletePatch.csModuleManager/Patches/PassSpecifiers/IPassSpecifier.csModuleManagerTests/Patches/PatchCompilerTest.csModuleManager/NeedsChecker.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/NeedsCheckerTest.csModuleManager/PatchList.csModuleManagerTests/Patches/PassSpecifiers/LegacyPassSpecifierTest.csModuleManagerTests/NodeMatcherTest.csModuleManager/Patches/PassSpecifiers/FinalPassSpecifier.csModuleManager/MMPatchLoader.csModuleManager/NodeMatcher.csModuleManagerTests/PatchApplierTest.csModuleManager/PatchApplier.csModuleManager/ModuleManager.csprojModuleManager/Progress/PatchProgress.csModuleManagerTests/Patches/PassSpecifiers/BeforePassSpecifierTest.csModuleManager/Patches/PassSpecifiers/AfterPassSpecifier.csModuleManager/Patches/CopyPatch.cs9b79b392f325efd89949a41c920f4871946a2ea51540175811000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comRestructure patch building
Lots of changes
* Parsing/validating patch is now separate code
* Less code in the patch extractor (may even be able to go away entirely
with some simplifications)
* Pass specifier is now an explicit concept
* Needs checker is now an object and has a cleaner interface
* Some things which were errors before are now just warnings
* If there is more than one pass specifier it will take the first one
and warn
* Syntax for root patch names is much more formal now, this might break
some unusual cases that are silently accepted now
2018-10-21 19:36:51 -07009b79b392f325efd89949a41c920f4871946a2ea5Restructure patch buildingeditModuleManagerTests/PatchExtractorTest.cseditModuleManager/PatchApplier.csaddModuleManager/Patches/PassSpecifiers/FinalPassSpecifier.csaddModuleManager/Patches/PassSpecifiers/BeforePassSpecifier.csaddModuleManager/Patches/ProtoPatchBuilder.csaddModuleManagerTests/Patches/PassSpecifiers/FinalPassSpecifierTest.csaddModuleManagerTests/Patches/ProtoPatchBuilderTest.csaddModuleManager/Patches/PassSpecifiers/AfterPassSpecifier.cseditModuleManagerTests/NeedsCheckerTest.cseditModuleManager/Patches/CopyPatch.cseditModuleManager/Patches/PatchCompiler.cseditModuleManagerTests/Patches/EditPatchTest.csaddModuleManagerTests/Patches/PassSpecifiers/FirstPassSpecifierTest.cseditModuleManager/ModuleManager.csprojeditModuleManager/PatchExtractor.cseditModuleManager/PatchList.csaddModuleManager/Patches/PassSpecifiers/IPassSpecifier.cseditModuleManager/MMPatchLoader.cseditModuleManager/NeedsChecker.cseditModuleManagerTests/PatchListTest.csaddModuleManagerTests/Patches/PassSpecifiers/LegacyPassSpecifierTest.csaddModuleManager/Patches/PassSpecifiers/FirstPassSpecifier.cseditModuleManager/Patches/EditPatch.cseditModuleManager/Progress/IPatchProgress.cseditModuleManagerTests/ModuleManagerTests.csprojaddModuleManager/Patches/PassSpecifiers/LegacyPassSpecifier.cseditModuleManager/NodeMatcher.cseditModuleManager/Patches/DeletePatch.cseditModuleManagerTests/PatchApplierTest.csaddModuleManagerTests/Patches/PassSpecifiers/BeforePassSpecifierTest.cseditModuleManagerTests/Patches/PatchCompilerTest.cseditModuleManagerTests/NodeMatcherTest.csaddModuleManagerTests/Patches/PassSpecifiers/ForPassSpecifierTest.csaddModuleManagerTests/Patches/PassSpecifiers/AfterPassSpecifierTest.csaddModuleManager/Patches/PassSpecifiers/InsertPassSpecifier.cseditModuleManager/Progress/PatchProgress.csaddModuleManager/Patches/PassSpecifiers/ForPassSpecifier.cseditModuleManager/Patches/IPatch.csaddModuleManager/Patches/ProtoPatch.cseditModuleManagerTests/Patches/CopyPatchTest.cseditModuleManagerTests/Patches/DeletePatchTest.csaddModuleManagerTests/Patches/PassSpecifiers/InsertPassSpecifierTest.cseditModuleManagerTests/Progress/PatchProgressTest.cs
- ModuleManager/MMPatchLoader.csModuleManager/Tags/TagListParser.csModuleManagerTests/PatchExtractorTest.csModuleManager/PatchExtractor.csModuleManagerTests/Tags/TagListParserTest.cs845fd212cf7121a33ff68a2d5706126f09391aa81540175811000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake extra colons a warning rather than an error
Been seeing a lot of these and the correct path is determinate
2018-10-21 19:36:51 -0700845fd212cf7121a33ff68a2d5706126f09391aa8Make extra colons a warning rather than an erroreditModuleManagerTests/PatchExtractorTest.cseditModuleManagerTests/Tags/TagListParserTest.cseditModuleManager/MMPatchLoader.cseditModuleManager/Tags/TagListParser.cseditModuleManager/PatchExtractor.cs
- ModuleManager/Properties/AssemblyInfo.cs00216d33dcf53034d6c4e593effd84d67e341c491542047814000https://ksp.sarbian.com/jenkins/user/sarbiansarbiansebastien.gaggini@gmail.comv3.1.1
2018-11-12 19:36:54 +010000216d33dcf53034d6c4e593effd84d67e341c49v3.1.1editModuleManager/Properties/AssemblyInfo.cs
githttps://ksp.sarbian.com/jenkins/user/joeydwongjoeydwonghttps://ksp.sarbian.com/jenkins/user/sarbiansarbian