Started by user sarbiansarbiansarbian53aa022badeb26e22a85b71f631f019190b617fb8aaa022badeb26e22a85b71f631f019190b617fb8aorigin/masteraa022badeb26e22a85b71f631f019190b617fb8aaa022badeb26e22a85b71f631f019190b617fb8aorigin/master147166b72c9a2a087c3b58e4e3e4ea949171c48c9c7166b72c9a2a087c3b58e4e3e4ea949171c48c9c7refs/remotes/origin/master166b72c9a2a087c3b58e4e3e4ea949171c48c9c7166b72c9a2a087c3b58e4e3e4ea949171c48c9c7refs/remotes/origin/master166b72c9a2a087c3b58e4e3e4ea949171c48c9c7166b72c9a2a087c3b58e4e3e4ea949171c48c9c7refs/remotes/origin/masterhttps://github.com/sarbian/ModuleManager.gitModuleManager-4.0.0.zipModuleManager-4.0.0.zipModuleManager-4.0.0.zipModuleManager.4.0.0.dllModuleManager.4.0.0.dllModuleManager.4.0.0.dllfalse#14746324997ModuleManager #147147falsefalse147431SUCCESS1548357465632https://ksp.sarbian.com/jenkins/user/jonnyothan/my-views/view/all/job/ModuleManager/147/- ModuleManagerTests/ModuleManagerTests.csprojTestUtilsTests/packages.configTestUtilsTests/TestUtilsTests.csprojModuleManagerTests/packages.configb605a7345aed428c1f1d64856329fcdf722c23911547056425000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUpdate NuGet packages where available
Others require .NET 4
2019-01-09 09:53:45 -0800b605a7345aed428c1f1d64856329fcdf722c2391Update NuGet packages where availableeditTestUtilsTests/packages.configeditTestUtilsTests/TestUtilsTests.csprojeditModuleManagerTests/packages.configeditModuleManagerTests/ModuleManagerTests.csproj
- ModuleManagerTests/ModuleManagerTests.csprojTestUtilsTests/packages.configTestUtilsTests/TestUtilsTests.csprojModuleManagerTests/packages.configTestUtils/TestUtils.csproj29932505aafa752c4a3bb7eb1cd51491118c9fd11547056425000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAccessory projects on .NET 4.7.1
Visual Studio apparently requires .NET 4 to run tests now. Main project
stays on 3.5 since KSP requires that.
2019-01-09 09:53:45 -080029932505aafa752c4a3bb7eb1cd51491118c9fd1Accessory projects on .NET 4.7.1editTestUtilsTests/packages.configeditModuleManagerTests/ModuleManagerTests.csprojeditTestUtilsTests/TestUtilsTests.csprojeditModuleManagerTests/packages.configeditTestUtils/TestUtils.csproj
- ModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/app.configModuleManagerTests/packages.config9a9bd677dadd99e360490bb2b110522b3ca3b1bd1547056425000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUpdate NSubstitute to latest
2019-01-09 09:53:45 -08009a9bd677dadd99e360490bb2b110522b3ca3b1bdUpdate NSubstitute to latesteditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/app.configeditModuleManagerTests/packages.config
- ModuleManagerTests/ModuleManagerTests.csprojTestUtilsTests/packages.configTestUtilsTests/TestUtilsTests.csprojModuleManagerTests/packages.configbb858604b6cdd5f1369ce0b7cad8819e355b133c1547056425000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUpdate Xunit
2019-01-09 09:53:45 -0800bb858604b6cdd5f1369ce0b7cad8819e355b133cUpdate XuniteditTestUtilsTests/packages.configeditModuleManagerTests/packages.configeditTestUtilsTests/TestUtilsTests.csprojeditModuleManagerTests/ModuleManagerTests.csproj
- ModuleManagerTests/PatchExtractorTest.csModuleManagerTests/Patches/PatchCompilerTest.csModuleManagerTests/Patches/EditPatchTest.csModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManagerTests/Patches/CopyPatchTest.csModuleManagerTests/DummyTest.csTestUtilsTests/DummyTest.cs0968853237bbf2341f14a9456a2417a982efc1fb1547056425000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix Xunit warnings
2019-01-09 09:53:45 -08000968853237bbf2341f14a9456a2417a982efc1fbFix Xunit warningseditModuleManagerTests/DummyTest.cseditModuleManagerTests/Patches/PatchCompilerTest.cseditModuleManagerTests/Patches/CopyPatchTest.cseditModuleManagerTests/Patches/EditPatchTest.cseditModuleManagerTests/Extensions/ConfigNodeExtensionsTest.cseditModuleManagerTests/PatchExtractorTest.cseditTestUtilsTests/DummyTest.cs
- ModuleManagerTests/ModuleManagerTests.csprojModuleManager/Logging/StreamLogger.csModuleManager/ModuleManager.csprojModuleManagerTests/Logging/StreamLoggerTest.cse03db37b1605fe8496b3456f0af5a7a7524394421547103160000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comimplement stream logger
log to a stream
2019-01-09 22:52:40 -0800e03db37b1605fe8496b3456f0af5a7a752439442implement stream loggereditModuleManagerTests/ModuleManagerTests.csprojeditModuleManager/ModuleManager.csprojaddModuleManagerTests/Logging/StreamLoggerTest.csaddModuleManager/Logging/StreamLogger.cs
- ModuleManager/Progress/IPatchProgress.cs16d88d209d5f1cc5f22061d2e9e065122d1f00a91547103160000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUnnecessary using
2019-01-09 22:52:40 -080016d88d209d5f1cc5f22061d2e9e065122d1f00a9Unnecessary usingeditModuleManager/Progress/IPatchProgress.cs
- ModuleManager/ModuleManager.cs376b71fe5cdee0ea1410bb4d63763ed00bc251c91547103160000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comThese are already run by MMPatchLoader
No need to explicitly run them again on database reload
2019-01-09 22:52:40 -0800376b71fe5cdee0ea1410bb4d63763ed00bc251c9These are already run by MMPatchLoadereditModuleManager/ModuleManager.cs
- ModuleManager/MMPatchLoader.csModuleManagerTests/InGameTestRunnerTest.csModuleManager/ModuleManager.csModuleManager/ModuleManagerPostPatch.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/ModuleManagerTestRunner.csModuleManager/ModuleManager.csproje1a2be8b7b7dfab2c1c9f1acc0a96cc6d3696b341547103301000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract post patch
Now its own loading system
Extract test runner and add tests for it (meta!)
2019-01-09 22:55:01 -0800e1a2be8b7b7dfab2c1c9f1acc0a96cc6d3696b34Extract post patcheditModuleManager/ModuleManager.cseditModuleManager/ModuleManager.csprojeditModuleManagerTests/ModuleManagerTests.csprojeditModuleManager/MMPatchLoader.csaddModuleManagerTests/InGameTestRunnerTest.csaddModuleManager/ModuleManagerPostPatch.csaddModuleManager/ModuleManagerTestRunner.cs
- ModuleManagerTests/PatchExtractorTest.csModuleManager/Patches/EditPatch.csModuleManager/PatchExtractor.csModuleManager/ProtoUrlConfig.csModuleManager/Progress/IPatchProgress.csModuleManager/Patches/IPatch.csModuleManagerTests/Patches/EditPatchTest.csModuleManagerTests/Patches/CopyPatchTest.csModuleManager/PatchContext.csModuleManagerTests/Patches/DeletePatchTest.csModuleManagerTests/MMPatchLoaderTest.csModuleManager/Patches/PatchCompiler.csModuleManagerTests/Progress/PatchProgressTest.csModuleManagerTests/PatchListTest.csModuleManager/Patches/DeletePatch.csModuleManagerTests/Patches/PatchCompilerTest.csModuleManagerTests/Patches/InsertPatchTest.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/PatchList.csModuleManager/MMPatchLoader.csModuleManager/Patches/InsertPatch.csModuleManagerTests/PatchApplierTest.csModuleManager/ModuleManager.csprojModuleManager/PatchApplier.csModuleManager/Progress/PatchProgress.csModuleManager/Patches/CopyPatch.cs48df502d6d38721788489652d57cd83d1d16a8dd1547103580000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comOperate on a copy of the game database then apply
* Insert nodes are now patches. They don't support MM syntax yet (just
applied directly) but that could be added
* ProtoUrlConfig identifies a UrlFile and node without the expectation
that the UrlFile knows about the node (turned into a real UrlConfig at
the end)
* Intermedate state of the game database is now a linked list of nodes
2019-01-09 22:59:40 -080048df502d6d38721788489652d57cd83d1d16a8ddOperate on a copy of the game database then applyeditModuleManagerTests/ModuleManagerTests.csprojeditModuleManager/Progress/IPatchProgress.cseditModuleManagerTests/Patches/CopyPatchTest.csaddModuleManager/ProtoUrlConfig.cseditModuleManager/Patches/DeletePatch.cseditModuleManager/ModuleManager.csprojeditModuleManagerTests/PatchExtractorTest.cseditModuleManager/Patches/EditPatch.cseditModuleManager/Patches/IPatch.cseditModuleManagerTests/PatchApplierTest.cseditModuleManagerTests/PatchListTest.cseditModuleManager/PatchExtractor.cseditModuleManager/PatchList.cseditModuleManagerTests/MMPatchLoaderTest.cseditModuleManagerTests/Patches/PatchCompilerTest.cseditModuleManager/PatchApplier.cseditModuleManager/Progress/PatchProgress.cseditModuleManagerTests/Patches/DeletePatchTest.cseditModuleManager/MMPatchLoader.csaddModuleManager/Patches/InsertPatch.cseditModuleManager/Patches/CopyPatch.cseditModuleManagerTests/Progress/PatchProgressTest.cseditModuleManager/PatchContext.csaddModuleManagerTests/Patches/InsertPatchTest.cseditModuleManager/Patches/PatchCompiler.cseditModuleManagerTests/Patches/EditPatchTest.cs
- ModuleManager/MMPatchLoader.cs72f37f1b58158c6dbf5fed3aef2cd06d3ffc9fc51547103580000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMove path initialization to static initializer
By the time the plugin is even loaded this should all exist
2019-01-09 22:59:40 -080072f37f1b58158c6dbf5fed3aef2cd06d3ffc9fc5Move path initialization to static initializereditModuleManager/MMPatchLoader.cs
- ModuleManager/MMPatchLoader.cs122d4bfbfc8d4c32c84cc63a7da43430c0be1c321547103580000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake sure cache also uses copy of game db
Configs can be applied after in either case
2019-01-09 22:59:40 -0800122d4bfbfc8d4c32c84cc63a7da43430c0be1c32Make sure cache also uses copy of game dbeditModuleManager/MMPatchLoader.cs
- ModuleManager/FilePathRepository.csModuleManager/MMPatchLoader.csModuleManager/CustomConfigsManager.csModuleManager/ModuleManager.csprojea7b05a6358295f43f20d02aba4095e76e58fef31547103580000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract paths to their own class
Forgot that the static initalizers would prevent tests from running
2019-01-09 22:59:40 -0800ea7b05a6358295f43f20d02aba4095e76e58fef3Extract paths to their own classaddModuleManager/FilePathRepository.cseditModuleManager/ModuleManager.csprojeditModuleManager/MMPatchLoader.cseditModuleManager/CustomConfigsManager.cs
- ModuleManager/MMPatchLoader.csModuleManager/Progress/IPatchProgress.csModuleManager/ModuleManager.csModuleManager/ModuleManagerPostPatch.csModuleManager/MMPatchRunner.csModuleManagerTests/Progress/PatchProgressTest.csModuleManagerTests/PatchApplierTest.csModuleManager/ModuleManager.csprojModuleManager/Progress/PatchProgress.csModuleManager/PatchApplier.csd50fc9e2403b3860c842267b4ff3ef04d32c53e61547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.compatch in background
Patches are now applied on a separate thread to an isolated copy of the
game database, then copied into the actual game database by post-patch
runner. Post patch runner will wait for patched database if it isn't
done yet.
One consequence is that logging during patching can no longer be
directed to the main log (it'll get mixed up with other messages). Now
directed to
<ksp_root>/Logs/ModuleManager.log
2019-01-09 23:02:01 -0800d50fc9e2403b3860c842267b4ff3ef04d32c53e6patch in backgroundeditModuleManager/Progress/IPatchProgress.cseditModuleManager/ModuleManager.cseditModuleManagerTests/Progress/PatchProgressTest.cseditModuleManager/ModuleManagerPostPatch.cseditModuleManager/MMPatchLoader.cseditModuleManagerTests/PatchApplierTest.cseditModuleManager/ModuleManager.csprojeditModuleManager/Progress/PatchProgress.cseditModuleManager/PatchApplier.csaddModuleManager/MMPatchRunner.cs
- ModuleManager/MMPatchLoader.cs09b1eff0444f3ecdb1e6b312b1f10906e1ef2b731547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comRemove PurgeUnused
Hasn't been necessary for a while
2019-01-09 23:02:01 -080009b1eff0444f3ecdb1e6b312b1f10906e1ef2b73Remove PurgeUnusededitModuleManager/MMPatchLoader.cs
- ModuleManager/FilePathRepository.csModuleManager/MMPatchRunner.cs39e4157f86bcce19eafb2d2adbc0fc5b64f520ff1547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comPut log paths in path repository
2019-01-09 23:02:01 -080039e4157f86bcce19eafb2d2adbc0fc5b64f520ffPut log paths in path repositoryeditModuleManager/MMPatchRunner.cseditModuleManager/FilePathRepository.cs
- ModuleManager/ModuleManager.csprojModuleManager/PostPatchLoader.csModuleManager/ModuleManagerPostPatch.csde6b621e8e8bfcdbd9ec917f0fcd9404d19675791547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comRename file to reflect class name
2019-01-09 23:02:01 -0800de6b621e8e8bfcdbd9ec917f0fcd9404d1967579Rename file to reflect class nameeditModuleManager/ModuleManager.csprojdeleteModuleManager/ModuleManagerPostPatch.csaddModuleManager/PostPatchLoader.cs
- ModuleManager/PostPatchLoader.cs6ed6702fcf105168da1552667e2d6cf5a8e5dc2a1547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDump ModuleManager log to main log after patching
Makes it easier to debug people's issues
2019-01-09 23:02:01 -08006ed6702fcf105168da1552667e2d6cf5a8e5dc2aDump ModuleManager log to main log after patchingeditModuleManager/PostPatchLoader.cs
- ModuleManager/Patches/DeletePatch.csModuleManager/Patches/EditPatch.csModuleManagerTests/Patches/InsertPatchTest.csModuleManager/Patches/IPatch.csModuleManagerTests/Patches/EditPatchTest.csModuleManagerTests/Patches/CopyPatchTest.csModuleManager/PatchList.csModuleManagerTests/Patches/DeletePatchTest.csModuleManager/Patches/InsertPatch.csModuleManagerTests/PatchListTest.csModuleManagerTests/PatchApplierTest.csModuleManager/PatchApplier.csModuleManager/Patches/CopyPatch.cs1589e0708914af3889854411f44e89ee86c78b021547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDon't count insert nodes as patches
As far as progress is concerned, these take much less time to apply than
patches, and are often less numerous. This can lead to weird completion
percentages.
2019-01-09 23:02:01 -08001589e0708914af3889854411f44e89ee86c78b02Don't count insert nodes as patcheseditModuleManager/Patches/InsertPatch.cseditModuleManager/Patches/DeletePatch.cseditModuleManager/PatchApplier.cseditModuleManager/Patches/IPatch.cseditModuleManager/Patches/CopyPatch.cseditModuleManagerTests/PatchApplierTest.cseditModuleManagerTests/Patches/DeletePatchTest.cseditModuleManager/PatchList.cseditModuleManagerTests/Patches/EditPatchTest.cseditModuleManagerTests/PatchListTest.cseditModuleManager/Patches/EditPatch.cseditModuleManagerTests/Patches/CopyPatchTest.cseditModuleManagerTests/Patches/InsertPatchTest.cs
- ModuleManager/MMPatchLoader.csc2424cb2254dbaa3bdd45e2defcfb20c40116e261547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comOnly display whole percentages
2019-01-09 23:02:01 -0800c2424cb2254dbaa3bdd45e2defcfb20c40116e26Only display whole percentageseditModuleManager/MMPatchLoader.cs
- ModuleManager/FilePathRepository.csaeca3350c3960f3b87489f73e120c86c8c3f21de1547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd subdir under Logs
Makes it consistent with Kopernicus
2019-01-09 23:02:01 -0800aeca3350c3960f3b87489f73e120c86c8c3f21deAdd subdir under LogseditModuleManager/FilePathRepository.cs
- ModuleManager/ModuleManager.csed78083e1fd679a0c23ffe272b5fa1863aefd8931547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comReplace reloading screen messages with dialog
2019-01-09 23:02:01 -0800ed78083e1fd679a0c23ffe272b5fa1863aefd893Replace reloading screen messages with dialogeditModuleManager/ModuleManager.cs
- ModuleManagerTests/ModuleManagerTests.csprojModuleManager/Logging/LogSplitter.csModuleManager/ModuleManager.csprojModuleManagerTests/Logging/LogSplitterTest.cs52d8b18040d915575e643cf6d8b5cc039f779fb01547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comadd LogSplitter
directs logs to two other loggers
2019-01-09 23:02:01 -080052d8b18040d915575e643cf6d8b5cc039f779fb0add LogSplitteraddModuleManager/Logging/LogSplitter.csaddModuleManagerTests/Logging/LogSplitterTest.cseditModuleManager/ModuleManager.csprojeditModuleManagerTests/ModuleManagerTests.csproj
- ModuleManager/MMPatchLoader.csModuleManager/FilePathRepository.cs714500341d17e5a0fccba3baa61b2ac6105e62f91547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comSave patch log and dump when loading from cache
This ensures that modders have access to a full history of what
ModuleManager did even when the log was taken from a run where it loaded
from cache
2019-01-09 23:02:01 -0800714500341d17e5a0fccba3baa61b2ac6105e62f9Save patch log and dump when loading from cacheeditModuleManager/MMPatchLoader.cseditModuleManager/FilePathRepository.cs
- ModuleManager/MMPatchLoader.csModuleManager/Logging/StreamLogger.csModuleManagerTests/Logging/StreamLoggerTest.csModuleManager/MMPatchRunner.csee9073b8a94c4ea4e8fbbf01c2e48704cb1088cb1547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comGet rid of stream logger's exception logger
In theory it should be monitored, and not being able to log is a pretty
serious condition we'd want to watch for
2019-01-09 23:02:01 -0800ee9073b8a94c4ea4e8fbbf01c2e48704cb1088cbGet rid of stream logger's exception loggereditModuleManagerTests/Logging/StreamLoggerTest.cseditModuleManager/Logging/StreamLogger.cseditModuleManager/MMPatchLoader.cseditModuleManager/MMPatchRunner.cs
- ModuleManager/MMPatchLoader.cse0c1400300d9aafc649cce033ed99d85df50f24c1547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comGet rid of trailing whitespace
Thanks VisualStudio
2019-01-09 23:02:01 -0800e0c1400300d9aafc649cce033ed99d85df50f24cGet rid of trailing whitespaceeditModuleManager/MMPatchLoader.cs
- ModuleManager/Logging/StreamLogger.cs326119bc1ec3d1c2cf8b13f22f6d426e47b7e96a1547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comuse international date format
2019-01-09 23:02:01 -0800326119bc1ec3d1c2cf8b13f22f6d426e47b7e96ause international date formateditModuleManager/Logging/StreamLogger.cs
- ModuleManager/MMPatchLoader.csModuleManager/Logging/QueueLogRunner.csModuleManager/MMPatchRunner.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Collections/MessageQueueTest.csModuleManager/ModuleManager.csprojModuleManagerTests/Logging/QueueLogRunnerTest.csModuleManager/Collections/MessageQueue.cs072b0d002a2e3facd4850a6a9ec9efdd7f6c99c51547103721000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comextract common parts of reading logs from queue to its own class
2019-01-09 23:02:01 -0800072b0d002a2e3facd4850a6a9ec9efdd7f6c99c5extract common parts of reading logs from queue to its own classeditModuleManager/MMPatchLoader.csaddModuleManagerTests/Logging/QueueLogRunnerTest.cseditModuleManagerTests/ModuleManagerTests.csprojeditModuleManagerTests/Collections/MessageQueueTest.csaddModuleManager/Logging/QueueLogRunner.cseditModuleManager/ModuleManager.csprojeditModuleManager/Collections/MessageQueue.cseditModuleManager/MMPatchRunner.cs
- ModuleManager/Properties/AssemblyInfo.cs166b72c9a2a087c3b58e4e3e4ea949171c48c9c71548357325000https://ksp.sarbian.com/jenkins/user/sarbiansarbiansebastien.gaggini@gmail.comv4.0.0
2019-01-24 20:15:25 +0100166b72c9a2a087c3b58e4e3e4ea949171c48c9c7v4.0.0editModuleManager/Properties/AssemblyInfo.cs
githttps://ksp.sarbian.com/jenkins/user/joeydwongjoeydwonghttps://ksp.sarbian.com/jenkins/user/sarbiansarbian