Started by user sarbiansarbiansarbian53aa022badeb26e22a85b71f631f019190b617fb8aaa022badeb26e22a85b71f631f019190b617fb8aorigin/masteraa022badeb26e22a85b71f631f019190b617fb8aaa022badeb26e22a85b71f631f019190b617fb8aorigin/master1513d85ddca5fcf62e81e21904fcb04364039081bbf3d85ddca5fcf62e81e21904fcb04364039081bbfrefs/remotes/origin/master3d85ddca5fcf62e81e21904fcb04364039081bbf3d85ddca5fcf62e81e21904fcb04364039081bbfrefs/remotes/origin/master3d85ddca5fcf62e81e21904fcb04364039081bbf3d85ddca5fcf62e81e21904fcb04364039081bbfrefs/remotes/origin/masterhttps://github.com/sarbian/ModuleManager.gitModuleManager-4.0.3.zipModuleManager-4.0.3.zipModuleManager-4.0.3.zipModuleManager.4.0.3.dllModuleManager.4.0.3.dllModuleManager.4.0.3.dllfalse#151274034997ModuleManager #151151falsefalse15114SUCCESS1565132679359https://ksp.sarbian.com/jenkins/user/jonnyothan/my-views/view/all/job/ModuleManager/151/- ModuleManagerTests/ModuleManagerTests.csprojModuleManager/Collections/KeyValueCache.csModuleManagerTests/Collections/KeyValueCacheTest.csModuleManager/ModuleManager.csproj918b0a24de7f604b31a058395e4e2709c7dc8ede1555720424000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.comadd thread-safe KeyValueCache
2019-04-19 17:33:44 -0700918b0a24de7f604b31a058395e4e2709c7dc8edeadd thread-safe KeyValueCacheaddModuleManagerTests/Collections/KeyValueCacheTest.cseditModuleManager/ModuleManager.csprojaddModuleManager/Collections/KeyValueCache.cseditModuleManagerTests/ModuleManagerTests.csproj
- ModuleManager/MMPatchLoader.cs6e6a465c4a04578772eb989b9f2132b3dd4b4d561555720443000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.comuse new KeyValueCache class as regex cache
Makes it thread safe - doesn't matter in production but might matter in
tests which can be run in parallel
2019-04-19 17:34:03 -07006e6a465c4a04578772eb989b9f2132b3dd4b4d56use new KeyValueCache class as regex cacheeditModuleManager/MMPatchLoader.cs
- ModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/ProtoUrlConfigTest.csa0c1dfc2c7342c8ee1010bee9a3019a3d4eb2b311555720605000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.comadd test for ProtoUrlConfig
2019-04-19 17:36:45 -0700a0c1dfc2c7342c8ee1010bee9a3019a3d4eb2b31add test for ProtoUrlConfigaddModuleManagerTests/ProtoUrlConfigTest.cseditModuleManagerTests/ModuleManagerTests.csproj
- ModuleManager/ProtoUrlConfig.csModuleManagerTests/ProtoUrlConfigTest.cs72717253e9d96fa05a9ca19603b8dbbe3964c4441555730110000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd name value to applying patch messages
Makes debugging patches easier, since multiple root nodes can save the
same url
Resolves #143
2019-04-19 20:15:10 -070072717253e9d96fa05a9ca19603b8dbbe3964c444Add name value to applying patch messageseditModuleManager/ProtoUrlConfig.cseditModuleManagerTests/ProtoUrlConfigTest.cs
- ModuleManager/Logging/StreamLogger.csModuleManagerTests/Logging/StreamLoggerTest.cscfaac6aa5031db26d8d84216f5e6885314a103061556598315000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix StreamLogger ignoring messages
Resolves #145
2019-04-29 21:25:15 -0700cfaac6aa5031db26d8d84216f5e6885314a10306Fix StreamLogger ignoring messageseditModuleManager/Logging/StreamLogger.cseditModuleManagerTests/Logging/StreamLoggerTest.cs
- ModuleManager/Logging/ILogMessage.csModuleManager/Logging/QueueLogger.csModuleManagerTests/Extensions/IBasicLoggerExtensionsTest.csModuleManagerTests/Patches/EditPatchTest.csModuleManagerTests/Logging/UnityLoggerTest.csModuleManagerTests/InGameTestRunnerTest.csModuleManagerTests/MMPatchLoaderTest.csModuleManagerTests/Progress/PatchProgressTest.csModuleManager/Logging/IBasicLogger.csModuleManager/Logging/StreamLogger.csModuleManagerTests/Logging/QueueLoggerTest.csModuleManagerTests/Logging/ModLoggerTest.csModuleManager/Logging/QueueLogRunner.csModuleManagerTests/Logging/NormalMessageTest.csModuleManagerTests/Logging/LogMessageTest.csModuleManagerTests/Logging/StreamLoggerTest.csModuleManager/Logging/ModLogger.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/Logging/ExceptionMessage.csModuleManager/Logging/UnityLogger.csModuleManager/Logging/NormalMessage.csModuleManager/Logging/LogSplitter.csModuleManager/Extensions/IBasicLoggerExtensions.csModuleManagerTests/Logging/LogSplitterTest.csModuleManagerTests/PatchApplierTest.csModuleManagerTests/Logging/ExceptionMessageTest.csModuleManager/ModuleManager.csprojModuleManager/Logging/LogMessage.csModuleManagerTests/LoggingAssertionHelpers.csModuleManagerTests/Logging/QueueLogRunnerTest.csd4d0fb78126ad4979c7df55f47dd4e9fc1e55b9b1556609078000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comRedo logging interface
* Convert exceptions to strings rather than keeping a separate interface
for exceptions everywhere
* Log messages know how to convert themselves to log strings
* Simplified interface (including assertions) provided by extension
methods
2019-04-30 00:24:38 -0700d4d0fb78126ad4979c7df55f47dd4e9fc1e55b9bRedo logging interfacedeleteModuleManagerTests/Logging/NormalMessageTest.csaddModuleManagerTests/Logging/LogMessageTest.cseditModuleManager/Logging/QueueLogRunner.csdeleteModuleManager/Logging/NormalMessage.cseditModuleManager/Logging/QueueLogger.cseditModuleManagerTests/Logging/QueueLoggerTest.csdeleteModuleManager/Logging/ExceptionMessage.cseditModuleManagerTests/Logging/ModLoggerTest.cseditModuleManager/ModuleManager.csprojeditModuleManagerTests/Extensions/IBasicLoggerExtensionsTest.csaddModuleManager/Logging/LogMessage.cseditModuleManagerTests/Patches/EditPatchTest.cseditModuleManager/Logging/ILogMessage.cseditModuleManagerTests/ModuleManagerTests.csprojeditModuleManagerTests/PatchApplierTest.cseditModuleManager/Logging/ModLogger.csdeleteModuleManagerTests/Logging/ExceptionMessageTest.cseditModuleManagerTests/Logging/StreamLoggerTest.cseditModuleManagerTests/Progress/PatchProgressTest.cseditModuleManagerTests/MMPatchLoaderTest.cseditModuleManager/Logging/IBasicLogger.cseditModuleManagerTests/Logging/QueueLogRunnerTest.cseditModuleManagerTests/Logging/UnityLoggerTest.csaddModuleManagerTests/LoggingAssertionHelpers.cseditModuleManager/Logging/LogSplitter.cseditModuleManagerTests/Logging/LogSplitterTest.cseditModuleManager/Extensions/IBasicLoggerExtensions.cseditModuleManager/Logging/StreamLogger.cseditModuleManager/Logging/UnityLogger.cseditModuleManagerTests/InGameTestRunnerTest.cs
- ModuleManager/Logging/LogMessage.csModuleManagerTests/Logging/LogMessageTest.csModuleManager/Logging/ModLogger.csfc74f1fcda46031eb9b3139c7a56830b6728d01d1556609559000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comInitialize LogMessage from old LogMessage
with new message
only uses LogType from old message for now but more coming
2019-04-30 00:32:39 -0700fc74f1fcda46031eb9b3139c7a56830b6728d01dInitialize LogMessage from old LogMessageeditModuleManager/Logging/ModLogger.cseditModuleManager/Logging/LogMessage.cseditModuleManagerTests/Logging/LogMessageTest.cs
- ModuleManager/MMPatchLoader.csModuleManagerTests/Logging/LogMessageTest.csModuleManager/Logging/LogMessage.csModuleManager/MMPatchRunner.cs07afe29d79f4260bbc6a3e6f517535ebc6afbba91556686516000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDon't put date on every log message
Instead put it once at the top of the log
2019-04-30 21:55:16 -070007afe29d79f4260bbc6a3e6f517535ebc6afbba9Don't put date on every log messageeditModuleManagerTests/Logging/LogMessageTest.cseditModuleManager/MMPatchLoader.cseditModuleManager/Logging/LogMessage.cseditModuleManager/MMPatchRunner.cs
- ModuleManagerTests/Logging/ModLoggerTest.csModuleManager/Logging/ILogMessage.csModuleManagerTests/Logging/LogMessageTest.csModuleManager/Logging/LogMessage.cs0a2c842ae3b141416b4a176f0fdb5fc1df4387601556686772000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comInitialize timestamp with log message
So if it takes some time to actually get to the log it will display the
originating timestamp rather than the timestamp it was logged at
2019-04-30 21:59:32 -07000a2c842ae3b141416b4a176f0fdb5fc1df438760Initialize timestamp with log messageeditModuleManagerTests/Logging/LogMessageTest.cseditModuleManager/Logging/ILogMessage.cseditModuleManagerTests/Logging/ModLoggerTest.cseditModuleManager/Logging/LogMessage.cs
- ModuleManagerTests/Logging/ModLoggerTest.csModuleManager/ModuleManager.csModuleManagerTests/Logging/PrefixLoggerTest.csModuleManager/Logging/ModLogger.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/PostPatchLoader.csModuleManager/Logging/PrefixLogger.csModuleManager/ModuleManager.csproja8bcad2adbb10413dd8b3175a0b61ef44390533c1556686825000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comModLogger -> PrefixLogger
Explains what it does better
2019-04-30 22:00:25 -0700a8bcad2adbb10413dd8b3175a0b61ef44390533cModLogger -> PrefixLoggerdeleteModuleManagerTests/Logging/ModLoggerTest.cseditModuleManager/ModuleManager.csaddModuleManagerTests/Logging/PrefixLoggerTest.cseditModuleManager/ModuleManager.csprojeditModuleManager/PostPatchLoader.csdeleteModuleManager/Logging/ModLogger.csaddModuleManager/Logging/PrefixLogger.cseditModuleManagerTests/ModuleManagerTests.csproj
- ModuleManager/Progress/PatchProgress.cs5711994c101b86891f9403a5c08c47492665810d1557089742000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUnnecessary using
2019-05-05 13:55:42 -07005711994c101b86891f9403a5c08c47492665810dUnnecessary usingeditModuleManager/Progress/PatchProgress.cs
- ModuleManagerTests/Patches/PatchCompilerTest.cs3650d6927de303a7be7b27fdf4d0a144ee4967371557089888000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUse better assertion
2019-05-05 13:58:08 -07003650d6927de303a7be7b27fdf4d0a144ee496737Use better assertioneditModuleManagerTests/Patches/PatchCompilerTest.cs
- ModuleManager/Logging/StreamLogger.csModuleManager/Collections/MessageQueue.cs5f7071d88369e69beb0e2fc5a74d1a8d3305c1591557090388000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMark disposables as sealed
Microsoft seems to recommend this
2019-05-05 14:06:28 -07005f7071d88369e69beb0e2fc5a74d1a8d3305c159Mark disposables as sealededitModuleManager/Collections/MessageQueue.cseditModuleManager/Logging/StreamLogger.cs
- ModuleManager/ModListGenerator.cs28bd925fbe75663c34b67d0bad6c012e011356021557090397000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAnother unnecessary using
2019-05-05 14:06:37 -070028bd925fbe75663c34b67d0bad6c012e01135602Another unnecessary usingeditModuleManager/ModListGenerator.cs
- ModuleManager/Extensions/UrlDirExtensions.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/MMPatchLoader.csModuleManagerTests/Extensions/UrlDirExtensionsTest.csModuleManager/ModuleManager.csproj5e5314e2d73e4ec237684793ec8975c2a2bc84ca1557120575000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUse custom code to lookup file by url
Should be less gc-happy and potentially faster, though this step rarely
takes any signicant amount of time.
Allows extensions to be specified optionally.
Doesn't support <ksp_root>/Parts or <ksp_root>/Internals but probably a
bunch of assumptions in ModuleManager about that too.
2019-05-05 22:29:35 -07005e5314e2d73e4ec237684793ec8975c2a2bc84caUse custom code to lookup file by urladdModuleManager/Extensions/UrlDirExtensions.cseditModuleManager/ModuleManager.csprojaddModuleManagerTests/Extensions/UrlDirExtensionsTest.cseditModuleManagerTests/ModuleManagerTests.csprojeditModuleManager/MMPatchLoader.cs
- ModuleManager/MMPatchLoader.csModuleManagerTests/Extensions/UrlFileExtensionsTest.csModuleManager/ModuleManager.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/Extensions/UrlFileExtensions.csModuleManager/Progress/PatchProgress.csModuleManager/ModuleManager.csprojae0d7a7c50df234e141909eedb2ceb6c5de6f3d21557121702000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comPut extension on cache URLs
Makes trailing spaces not break things
Resolves #121
2019-05-05 22:48:22 -0700ae0d7a7c50df234e141909eedb2ceb6c5de6f3d2Put extension on cache URLsaddModuleManager/Extensions/UrlFileExtensions.cseditModuleManager/ModuleManager.cseditModuleManager/Progress/PatchProgress.cseditModuleManager/ModuleManager.csprojeditModuleManager/MMPatchLoader.cseditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/Extensions/UrlFileExtensionsTest.cs
- ModuleManagerTests/ModuleManagerTests.csprojModuleManager/ModuleManager.csproj69ab085da68e4ed3c80f444f0a04bfa65e6171f51558992904000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAlphabetize .csproj files
2019-05-27 14:35:04 -070069ab085da68e4ed3c80f444f0a04bfa65e6171f5Alphabetize .csproj fileseditModuleManagerTests/ModuleManagerTests.csprojeditModuleManager/ModuleManager.csproj
- ModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Extensions/ByteArrayExtensionsTest.csModuleManager/Utils/FileUtils.csModuleManager/ModuleManager.csprojModuleManager/Extensions/ByteArrayExtensions.cse1bed9419ca20a15e04ba24e8bfe7e69563259e41559286931000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.comimprove file sha generator
* Actually dispose the sha when we're done
* Use a better way of converting bytes to hex strings (hopefully less
gc)
* Test byte array to hex string conversion
2019-05-31 00:15:31 -0700e1bed9419ca20a15e04ba24e8bfe7e69563259e4improve file sha generatoreditModuleManager/Utils/FileUtils.csaddModuleManager/Extensions/ByteArrayExtensions.csaddModuleManagerTests/Extensions/ByteArrayExtensionsTest.cseditModuleManager/ModuleManager.csprojeditModuleManagerTests/ModuleManagerTests.csproj
- TestUtils/UrlBuilder.csTestUtilsTests/UrlBuilderTest.csa27cb3df58b5b2218cfff2b0027959ce7332864f1559286932000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.comConvert UrlBuilder cfg test to theory
allows more inline data to be added
2019-05-31 00:15:32 -0700a27cb3df58b5b2218cfff2b0027959ce7332864fConvert UrlBuilder cfg test to theoryeditTestUtils/UrlBuilder.cseditTestUtilsTests/UrlBuilderTest.cs
- TestUtils/UrlBuilder.csTestUtilsTests/UrlBuilderTest.cs3d8594dd855febd0024a0ac876ad7e8ce03d28481559286933000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.comSet FileType based on common types
Makes checking against them easier
2019-05-31 00:15:33 -07003d8594dd855febd0024a0ac876ad7e8ce03d2848Set FileType based on common typeseditTestUtils/UrlBuilder.cseditTestUtilsTests/UrlBuilderTest.cs
- ModuleManagerTests/Logging/StreamLoggerTest.cseb3db605b24f56af6e4da5a17a8dbf3b9795292e1559288013000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.comunnecessary using
2019-05-31 00:33:33 -0700eb3db605b24f56af6e4da5a17a8dbf3b9795292eunnecessary usingeditModuleManagerTests/Logging/StreamLoggerTest.cs
- ModuleManagerTests/Logging/StreamLoggerTest.cs9795e3656b9e73a7ed1622d2b832002ad9b70d381559288453000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.commake StreamLoggerTest.TestLog work on \n platforms
line breaks are shorter which causes an extra null character to exist at
the end of the string, meaning that the default Trim() wasn't removing
that and the newline
2019-05-31 00:40:53 -07009795e3656b9e73a7ed1622d2b832002ad9b70d38make StreamLoggerTest.TestLog work on \n platformseditModuleManagerTests/Logging/StreamLoggerTest.cs
- TestUtilsTests/TestConfigNodeTest.cs9311cfb45507323f3f56f315dbda61f5034a31b01561614957000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.comImprove TestConfigNodeTest
Strictly assert the structure of the node
2019-06-26 22:55:57 -07009311cfb45507323f3f56f315dbda61f5034a31b0Improve TestConfigNodeTesteditTestUtilsTests/TestConfigNodeTest.cs
- TestUtils/TestConfigNode.csee5995f6196cfe58f2f646b1f8f8f847b32b9f0d1561615106000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.comRemove redundant parent class
2019-06-26 22:58:26 -0700ee5995f6196cfe58f2f646b1f8f8f847b32b9f0dRemove redundant parent classeditTestUtils/TestConfigNode.cs
- TestUtils/TestConfigNode.csTestUtilsTests/TestConfigNodeTest.cs3e4a9f998ecd40118e07bce7c655da6fb15a84421561615407000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.comFix TestConfigNode's handling of escaped chars
KSP removes these automatically, so we want to avoid that by
constructing the Value ourselves
2019-06-26 23:03:27 -07003e4a9f998ecd40118e07bce7c655da6fb15a8442Fix TestConfigNode's handling of escaped charseditTestUtils/TestConfigNode.cseditTestUtilsTests/TestConfigNodeTest.cs
- ModuleManagerTests/Extensions/ConfigNodeExtensionsTest.cs8e5c29ad0983157c88116085d4745e125941a4161561616281000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.comClean up test a bit
Use AssertValue method Use AssertEmpty rather than asserting count zero
2019-06-26 23:18:01 -07008e5c29ad0983157c88116085d4745e125941a416Clean up test a biteditModuleManagerTests/Extensions/ConfigNodeExtensionsTest.cs
- ModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManager/Extensions/ConfigNodeExtensions.cs0feef88557d938ee16b889ba5685db307be2c7981561618409000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.comFix DeepCopy handling of escaped values
KSP removes these in AddValue, we can circumvent that by constructing
the Value ourselves
2019-06-26 23:53:29 -07000feef88557d938ee16b889ba5685db307be2c798Fix DeepCopy handling of escaped valueseditModuleManagerTests/Extensions/ConfigNodeExtensionsTest.cseditModuleManager/Extensions/ConfigNodeExtensions.cs
- ModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManager/MMPatchLoader.csModuleManager/Extensions/ConfigNodeExtensions.csModuleManagerTests/MMPatchLoaderTest.cs96201a72d6c1037c95dc7f98da8177c25ee867f01561620237000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.comFix ModifyNode handling of escaped characters
new AddValueSafe method to handle this
use safe ShallowCopyFrom rather than ConfigNode's CopyTo as recursion is
not necessary and it handles escaped characters correctly
2019-06-27 00:23:57 -070096201a72d6c1037c95dc7f98da8177c25ee867f0Fix ModifyNode handling of escaped characterseditModuleManagerTests/Extensions/ConfigNodeExtensionsTest.cseditModuleManager/Extensions/ConfigNodeExtensions.cseditModuleManagerTests/MMPatchLoaderTest.cseditModuleManager/MMPatchLoader.cs
- ModuleManager/MMPatchLoader.csf2fba86ce98bcba5ab13b7d3ce6c6fd7e51e74ea1561621217000https://ksp.sarbian.com/jenkins/user/blowfishproblowfishprojoeydwong@gmail.comEnsure tabs and newlines don't break cache
Explicitly escape \n and \t which the localizer unescapes when game
database is initially loaded
2019-06-27 00:40:17 -0700f2fba86ce98bcba5ab13b7d3ce6c6fd7e51e74eaEnsure tabs and newlines don't break cacheeditModuleManager/MMPatchLoader.cs
- ModuleManager/Properties/AssemblyInfo.cs3d85ddca5fcf62e81e21904fcb04364039081bbf1565132603000https://ksp.sarbian.com/jenkins/user/sarbiansarbiansebastien.gaggini@gmail.comv4.0.3
2019-08-07 01:03:23 +02003d85ddca5fcf62e81e21904fcb04364039081bbfv4.0.3editModuleManager/Properties/AssemblyInfo.cs
githttps://ksp.sarbian.com/jenkins/user/sarbiansarbianhttps://ksp.sarbian.com/jenkins/user/blowfishproblowfishprohttps://ksp.sarbian.com/jenkins/user/joeydwongjoeydwong