Started by GitHub push by sarbian2080cefc35a4970d1ec1d990017f139342f8474df180cefc35a4970d1ec1d990017f139342f8474df1refs/remotes/origin/dev80cefc35a4970d1ec1d990017f139342f8474df180cefc35a4970d1ec1d990017f139342f8474df1refs/remotes/origin/dev80cefc35a4970d1ec1d990017f139342f8474df180cefc35a4970d1ec1d990017f139342f8474df1refs/remotes/origin/devhttps://github.com/sarbian/ModuleManager.gitfalse#2048046498ModuleManager-Dev #2020falsefalse2097FAILURE1505237315572https://ksp.sarbian.com/jenkins/user/markusappel/my-views/view/all/job/ModuleManager-Dev/20/ModuleManager/Cats/CatManager.csModuleManager/Properties/cat-1.pngIPatchProgress.csModuleManager/Properties/cat-12.pngModuleManager/Cats/CatOrbiter.csModuleManager/Properties/cat-10.pngpackages.configProperties/rainbow2.pngModuleManager.csprojModuleManager/Properties/cat-2.pngModuleManager/Cats/CatMover.csModuleManager/Logging/IBasicLogger.csModuleManager/Properties/cat-3.pngCats/CatManager.csCats/CatMover.csModuleManager/ModuleManager.csProperties/Resources.Designer.csCats/CatOrbiter.csProperties/cat-7.pngModuleManager/MMPatchLoader.csMMPatchLoader.csModuleManager/Properties/Resources.resxModuleManager/CustomConfigsManager.csProperties/cat-6.pngModuleManager/ModuleManager.csprojModuleManager/Properties/cat-4.pngModuleManager.slnModuleManager/Properties/cat-11.pngModuleManager.csModuleManager/Properties/Resources.Designer.csProperties/cat-5.pngModuleManager/Properties/rainbow2.pngProperties/AssemblyInfo.csProperties/cat-11.pngLogging/IBasicLogger.csExtensions/NodeStackExtensions.csModuleManager/Extensions/NodeStackExtensions.csModuleManager/Properties/cat-5.pngModuleManager/PatchContext.csModuleManager/Collections/ImmutableStack.csModuleManager/PatchProgress.csModuleManager/Properties/AssemblyInfo.csModuleManager/IPatchProgress.csProperties/cat-4.pngProperties/cat-12.pngModuleManager/Cats/CatAnimator.csLogging/ModLogger.csCollections/ImmutableStack.csModuleManager/Properties/cat-6.pngPatchProgress.csPatchContext.csModuleManager/Properties/cat-8.pngProperties/cat-8.pngProperties/cat-3.pngModuleManager/Logging/ModLogger.csModuleManager/packages.configProperties/Resources.resxCustomConfigsManager.csModuleManager/Properties/cat-7.pngProperties/cat-9.pngModuleManager/Properties/cat-9.pngCats/CatAnimator.csProperties/cat-2.pngProperties/cat-10.pngProperties/cat-1.png1a12a253a3addda038bfcd8fef7fa0b0f1840c0c1504326419000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.commove main project to its own directory Allows more to be added 2017-09-01 21:26:59 -07001a12a253a3addda038bfcd8fef7fa0b0f1840c0cmove main project to its own directoryaddModuleManager/Cats/CatAnimator.csaddModuleManager/CustomConfigsManager.csaddModuleManager/Properties/cat-10.pngaddModuleManager/Properties/cat-7.pngdeleteExtensions/NodeStackExtensions.csaddModuleManager/IPatchProgress.csaddModuleManager/Properties/rainbow2.pngaddModuleManager/Logging/IBasicLogger.csdeleteProperties/AssemblyInfo.csdeleteProperties/cat-1.pngeditModuleManager.slnaddModuleManager/ModuleManager.csprojaddModuleManager/packages.configaddModuleManager/Properties/cat-3.pngaddModuleManager/Cats/CatMover.csdeleteProperties/cat-6.pngaddModuleManager/Cats/CatOrbiter.csdeleteModuleManager.csprojdeleteLogging/ModLogger.csdeleteProperties/cat-12.pngaddModuleManager/Collections/ImmutableStack.csdeleteCats/CatMover.csaddModuleManager/Properties/Resources.resxdeleteProperties/Resources.resxdeleteProperties/cat-11.pngdeleteLogging/IBasicLogger.csaddModuleManager/Properties/cat-1.pngdeleteProperties/Resources.Designer.csaddModuleManager/Properties/cat-5.pngaddModuleManager/PatchContext.csaddModuleManager/Properties/AssemblyInfo.csaddModuleManager/Properties/Resources.Designer.csaddModuleManager/PatchProgress.csaddModuleManager/Properties/cat-4.pngdeleteCats/CatOrbiter.csdeleteCollections/ImmutableStack.csaddModuleManager/Extensions/NodeStackExtensions.csaddModuleManager/Cats/CatManager.csdeleteIPatchProgress.csaddModuleManager/Properties/cat-9.pngaddModuleManager/Logging/ModLogger.csdeleteMMPatchLoader.csdeleteProperties/cat-10.pngdeleteProperties/cat-8.pngaddModuleManager/ModuleManager.csdeleteCustomConfigsManager.csdeleteCats/CatAnimator.csdeleteProperties/cat-4.pngaddModuleManager/Properties/cat-6.pngaddModuleManager/Properties/cat-2.pngdeletepackages.configdeleteProperties/cat-5.pngaddModuleManager/Properties/cat-8.pngdeleteProperties/rainbow2.pngaddModuleManager/Properties/cat-12.pngdeleteProperties/cat-9.pngdeleteCats/CatManager.csaddModuleManager/MMPatchLoader.csdeletePatchProgress.csdeleteModuleManager.csdeletePatchContext.csdeleteProperties/cat-7.pngdeleteProperties/cat-2.pngdeleteProperties/cat-3.pngaddModuleManager/Properties/cat-11.pngModuleManager/ModuleManager.csprojf02f418db54ecb0ef523e08063e3d6c59922f5fd1504326591000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comBetter output dir for debug 2017-09-01 21:29:51 -0700f02f418db54ecb0ef523e08063e3d6c59922f5fdBetter output dir for debugeditModuleManager/ModuleManager.csprojModuleManager/ModuleManager.csproj95362b529ab739ad6c62d9a0a50ca7eaf60fe7f11504326600000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDo not copy local 2017-09-01 21:30:00 -070095362b529ab739ad6c62d9a0a50ca7eaf60fe7f1Do not copy localeditModuleManager/ModuleManager.csprojModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/DummyTest.csModuleManagerTests/packages.configModuleManagerTests/Properties/AssemblyInfo.csModuleManager.slnc4ba1b943c1d94fdab9ac7e51c1ca5dc9f26e9181504327341000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd test project 2017-09-01 21:42:21 -0700c4ba1b943c1d94fdab9ac7e51c1ca5dc9f26e918Add test projectaddModuleManagerTests/DummyTest.cseditModuleManager.slnaddModuleManagerTests/Properties/AssemblyInfo.csaddModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/packages.configModuleManagerTests/ModuleManagerTests.csproje8159e1f9d8f8c292c827dc0e47f1b93431efcb21504327635000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd MM, Assembly-CSharp, UnityEngine refs 2017-09-01 21:47:15 -0700e8159e1f9d8f8c292c827dc0e47f1b93431efcb2Add MM, Assembly-CSharp, UnityEngine refseditModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/packages.config563a9427e4b3cd21da3ccaa3c38b149c2bb1ee9c1504328185000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd console runner Will be needed eventually 2017-09-01 21:56:25 -0700563a9427e4b3cd21da3ccaa3c38b149c2bb1ee9cAdd console runnereditModuleManagerTests/packages.configTestUtilsTests/Properties/AssemblyInfo.csTestUtilsTests/packages.configTestUtilsTests/TestUtilsTests.csprojTestUtilsTests/DummyTest.csModuleManager.slnTestUtils/Properties/AssemblyInfo.csTestUtils/TestUtils.csproja7f901e4654900cde28f93c15e27154d66a36e301504329367000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comYo dawg, I heard you like tests 2017-09-01 22:16:07 -0700a7f901e4654900cde28f93c15e27154d66a36e30Yo dawg, I heard you like testsaddTestUtilsTests/TestUtilsTests.csprojeditModuleManager.slnaddTestUtilsTests/packages.configaddTestUtils/Properties/AssemblyInfo.csaddTestUtilsTests/Properties/AssemblyInfo.csaddTestUtilsTests/DummyTest.csaddTestUtils/TestUtils.csprojTestUtils/TestConfigNode.csTestUtilsTests/TestConfigNodeTest.csTestUtilsTests/TestUtilsTests.csprojTestUtils/TestUtils.csprojbe37f18a9cff44b889ecbc150b1a9b164b098c661504329802000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd TestConfigNode class Makes testing with ConfigNodes by simplifying creating them 2017-09-01 22:23:22 -0700be37f18a9cff44b889ecbc150b1a9b164b098c66Add TestConfigNode classaddTestUtils/TestConfigNode.csaddTestUtilsTests/TestConfigNodeTest.cseditTestUtils/TestUtils.csprojeditTestUtilsTests/TestUtilsTests.csprojModuleManagerTests/ModuleManagerTests.csproj278dad81e20c01e24505d4b9a48bd6c083eab8281504329872000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comReference TestUtils 2017-09-01 22:24:32 -0700278dad81e20c01e24505d4b9a48bd6c083eab828Reference TestUtilseditModuleManagerTests/ModuleManagerTests.csprojModuleManager/ModuleManager.csproj66e6612df80ebeac9c8cd23e37430ad527014a961504370462000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDon't reference a specific version of System 2017-09-02 09:41:02 -070066e6612df80ebeac9c8cd23e37430ad527014a96Don't reference a specific version of SystemeditModuleManager/ModuleManager.csprojModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Collections/ImmutableStackTest.csdf9c8ec4ead848c8ec2c7adeb13c7de8a81804771504370549000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd test for ImmutableStack 2017-09-02 09:42:29 -0700df9c8ec4ead848c8ec2c7adeb13c7de8a8180477Add test for ImmutableStackeditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/Collections/ImmutableStackTest.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Extensions/NodeStackExtensionsTest.cs3e7100991cc45ea01bc78ee2f95f4cdd38cae0a61504393533000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd test for GetPath 2017-09-02 16:05:33 -07003e7100991cc45ea01bc78ee2f95f4cdd38cae0a6Add test for GetPathaddModuleManagerTests/Extensions/NodeStackExtensionsTest.cseditModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/packages.config6e8285c5c6559339826804e599b90c3883284c761504402506000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd NSubstitute 2017-09-02 18:35:06 -07006e8285c5c6559339826804e599b90c3883284c76Add NSubstituteeditModuleManagerTests/ModuleManagerTests.csprojeditModuleManagerTests/packages.configModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Logging/ModLoggerTest.cs7398d4d1acbf2a8ed1db9dbc372fa94cf2c9cfa61504403632000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd tests for ModLogger 2017-09-02 18:53:52 -07007398d4d1acbf2a8ed1db9dbc372fa94cf2c9cfa6Add tests for ModLoggeraddModuleManagerTests/Logging/ModLoggerTest.cseditModuleManagerTests/ModuleManagerTests.csprojModuleManager/MMPatchLoader.csa5a095fc17b5e3a8c8b9c756a035d0bcbefdbec21504403972000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix an error 2017-09-02 18:59:32 -0700a5a095fc17b5e3a8c8b9c756a035d0bcbefdbec2Fix an erroreditModuleManager/MMPatchLoader.csTestUtilsTests/UrlBuilderTest.csTestUtilsTests/TestUtilsTests.csprojTestUtils/URLBuilder.csTestUtils/TestUtils.csproj564b226028542cf258b2792fb8612baab6b939dc1504492797000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd UrlBuilder Hackily creates UrlDir, UrlFile, UrlConfig for testing purposes 2017-09-03 19:39:57 -0700564b226028542cf258b2792fb8612baab6b939dcAdd UrlBuildereditTestUtils/TestUtils.csprojaddTestUtils/URLBuilder.cseditTestUtilsTests/TestUtilsTests.csprojaddTestUtilsTests/UrlBuilderTest.csModuleManager/MMPatchLoader.csModuleManager/IPatchProgress.csModuleManager/PatchProgress.csf190d17f56a1837204b62ad004da8005df624c2b1504500927000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comProgress shouldn't depend on deleted subnodes The number of needs unsatisfied nodes it should be counting is the number of root nodes that have been removed, not subnodes as well 2017-09-03 21:55:27 -0700f190d17f56a1837204b62ad004da8005df624c2bProgress shouldn't depend on deleted subnodeseditModuleManager/MMPatchLoader.cseditModuleManager/IPatchProgress.cseditModuleManager/PatchProgress.csModuleManager/MMPatchLoader.csModuleManager/IPatchProgress.csModuleManager/PatchProgress.csfca971747aa52e91653941cc5988cf7fa81195031504560261000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comThese should use actual URLs Since all the calls were just using .url anyway 2017-09-04 14:24:21 -0700fca971747aa52e91653941cc5988cf7fa8119503These should use actual URLseditModuleManager/MMPatchLoader.cseditModuleManager/PatchProgress.cseditModuleManager/IPatchProgress.csModuleManager/MMPatchLoader.csModuleManager/IPatchProgress.csModuleManager/PatchProgress.cs28e4ce78e513990712835ae12a6fe7d89f116ff71504561039000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comThese too 2017-09-04 14:37:19 -070028e4ce78e513990712835ae12a6fe7d89f116ff7These tooeditModuleManager/PatchProgress.cseditModuleManager/MMPatchLoader.cseditModuleManager/IPatchProgress.csModuleManager/PatchProgress.cs8d8463d17795917e4906dd469cae52e53c83bd601504587100000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMinor logging tweak 2017-09-04 21:51:40 -07008d8463d17795917e4906dd469cae52e53c83bd60Minor logging tweakeditModuleManager/PatchProgress.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/PatchProgressTest.csd37f58bc70332b6e5271fe69303d78c3aeb2b7411504587109000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd tests for PatchProgress 2017-09-04 21:51:49 -0700d37f58bc70332b6e5271fe69303d78c3aeb2b741Add tests for PatchProgressaddModuleManagerTests/PatchProgressTest.cseditModuleManagerTests/ModuleManagerTests.csprojModuleManager/MMPatchLoader.csca12c392d34244cddc3eca746d66070f90ae9eee1504845168000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comReplace DeepCopy with ConfigNode.CreateCopy It does 100% the same thing (and is recursive) 2017-09-07 21:32:48 -0700ca12c392d34244cddc3eca746d66070f90ae9eeeReplace DeepCopy with ConfigNode.CreateCopyeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs2b824899ff271c0681f7d03f527ec5b549a2f98a1504845418000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comInline out variable declarations Yay C#7 2017-09-07 21:36:58 -07002b824899ff271c0681f7d03f527ec5b549a2f98aInline out variable declarationseditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csModuleManager/CustomConfigsManager.csModuleManager/ModuleManager.cs47ce0154abaa501cb0cbcd10a709b9bd11bd370f1504845626000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comObey naming conventions 2017-09-07 21:40:26 -070047ce0154abaa501cb0cbcd10a709b9bd11bd370fObey naming conventionseditModuleManager/MMPatchLoader.cseditModuleManager/CustomConfigsManager.cseditModuleManager/ModuleManager.csgithttps://ksp.sarbian.com/jenkins/user/joeydwongjoeydwong