Started by GitHub push by sarbian227ef806233e270acdb2ed016f081f4a39602f2ea77ef806233e270acdb2ed016f081f4a39602f2ea7refs/remotes/origin/dev7ef806233e270acdb2ed016f081f4a39602f2ea77ef806233e270acdb2ed016f081f4a39602f2ea7refs/remotes/origin/dev7ef806233e270acdb2ed016f081f4a39602f2ea77ef806233e270acdb2ed016f081f4a39602f2ea7refs/remotes/origin/devhttps://github.com/sarbian/ModuleManager.gitfalse#2229866498ModuleManager-Dev #2222falsefalse22103FAILURE1506763391400https://ksp.sarbian.com/jenkins/user/markusappel/my-views/view/all/job/ModuleManager-Dev/22/ModuleManager/Extensions/StringExtensions.csModuleManager/MMPatchLoader.csModuleManagerTests/Extensions/StringExtensionsTest.cs180c2ee8434b8558072fca973299fa4821969f501505795809000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract RemoveWS 2017-09-18 21:36:49 -0700180c2ee8434b8558072fca973299fa4821969f50Extract RemoveWSeditModuleManager/Extensions/StringExtensions.cseditModuleManagerTests/Extensions/StringExtensionsTest.cseditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs20a8afbeaf2aae223c407899649360715249d1021505801312000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix logging 2017-09-18 23:08:32 -070020a8afbeaf2aae223c407899649360715249d102Fix loggingeditModuleManager/MMPatchLoader.csModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManager/MMPatchLoader.csModuleManager/Extensions/ConfigNodeExtensions.cs35d89f8ab11a495ade7d25719e367b903127a4fa1505880666000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract PrettyPrint 2017-09-19 21:11:06 -070035d89f8ab11a495ade7d25719e367b903127a4faExtract PrettyPrinteditModuleManager/MMPatchLoader.cseditModuleManager/Extensions/ConfigNodeExtensions.cseditModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManagerTests/Extensions/UrlConfigExtensionsTest.csModuleManager/Extensions/UrlConfigExtensions.csb52a80ea42e54cef13a90290c84eaeb4938236491505880746000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comGet rid of unnecesary using directives 2017-09-19 21:12:26 -0700b52a80ea42e54cef13a90290c84eaeb493823649Get rid of unnecesary using directiveseditModuleManagerTests/Extensions/UrlConfigExtensionsTest.cseditModuleManager/Extensions/UrlConfigExtensions.csModuleManager/MMPatchLoader.cs45a4c0c2222159a75c17415c16ef499c9e785c711506192297000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDon't run PrePatchInit if cache is being used Mod list is not necessary 2017-09-23 11:44:57 -070045a4c0c2222159a75c17415c16ef499c9e785c71Don't run PrePatchInit if cache is being usededitModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csd397a80a1157dbd74374fc9abd8a4f9e4b1ebbb31506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEliminate mods instance variable 2017-09-23 11:44:58 -0700d397a80a1157dbd74374fc9abd8a4f9e4b1ebbb3Eliminate mods instance variableeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs12780a636b8ace12511cfd71d8ec9302b3a152011506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUse method param rather than instance var Makes things easier to disentagle 2017-09-23 11:44:58 -070012780a636b8ace12511cfd71d8ec9302b3a15201Use method param rather than instance vareditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csb6b628cbed7806607a53eca2815e5e6be441eebf1506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEliminate Update Status will be updated when necessary anyway 2017-09-23 11:44:58 -0700b6b628cbed7806607a53eca2815e5e6be441eebfEliminate UpdateeditModuleManager/MMPatchLoader.csModuleManager/ModuleManager.cs7a40730ad2b966bcc0eccee8968af93d950efaa71506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEliminate redundant logging MMPatchLoader logs this info itself 2017-09-23 11:44:58 -07007a40730ad2b966bcc0eccee8968af93d950efaa7Eliminate redundant loggingeditModuleManager/ModuleManager.csModuleManager/MMPatchLoader.cs7e714a47ba7f158718e878ffcad83324f5b304531506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comKeep track of progress fraction independently 2017-09-23 11:44:58 -07007e714a47ba7f158718e878ffcad83324f5b30453Keep track of progress fraction independentlyeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs9236be107824be90bb56840dc20486aacb4fce7d1506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake StatusUpdate less general If cache is used, status only needs to be set once, no need to check it every time 2017-09-23 11:44:58 -07009236be107824be90bb56840dc20486aacb4fce7dMake StatusUpdate less generaleditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs8696143e2f3fd17dab5f92f81798141d4eeff69f1506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMove this What I get for trying to make a bunch of changes and then split them into small commits 2017-09-23 11:44:58 -07008696143e2f3fd17dab5f92f81798141d4eeff69fMove thiseditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs58d52d9572fce69dc234dbd7d1ba4f5b78e483131506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEliminate Progress instance variable Make it local, inject where needed 2017-09-23 11:44:58 -070058d52d9572fce69dc234dbd7d1ba4f5b78e48313Eliminate Progress instance variableeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs2645d222082cf9a5913590ac97ad6253c6ec92a31506192298000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake more methods static All their instance variable dependencies have been eliminated 2017-09-23 11:44:58 -07002645d222082cf9a5913590ac97ad6253c6ec92a3Make more methods staticeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs824b077dfc46eee2998bbc56ea3fb28f7c96b7761506193169000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comThis is no longer necessary And will probably result in an error anyway 2017-09-23 11:59:29 -0700824b077dfc46eee2998bbc56ea3fb28f7c96b776This is no longer necessaryeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csac0a149a21efe830c2c8e7df2468526395b6fe6d1506193250000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMove exception handling outside of PrettyConfig Callers really shouldn't be trying to print the result if it resulted in an exception anyway 2017-09-23 12:00:50 -0700ac0a149a21efe830c2c8e7df2468526395b6fe6dMove exception handling outside of PrettyConfigeditModuleManager/MMPatchLoader.csModuleManagerTests/Extensions/ConfigNodeExtensionsTest.cseb18b601a5662c74712af4eea74c0c60cb7ca4671506194323000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comTweak test This isn't the case it was trying to test 2017-09-23 12:18:43 -0700eb18b601a5662c74712af4eea74c0c60cb7ca467Tweak testeditModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csTestUtils/TestConfigNode.csTestUtilsTests/TestConfigNodeTest.cs4fdfb8911e4b93c8f7c332e8fab077a8a1bc68611506224183000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAllow adding a ConfigNode.Value in initializer Not useful yet but maybe at some point 2017-09-23 20:36:23 -07004fdfb8911e4b93c8f7c332e8fab077a8a1bc6861Allow adding a ConfigNode.Value in initializereditTestUtils/TestConfigNode.cseditTestUtilsTests/TestConfigNodeTest.csModuleManagerTests/Extensions/UrlConfigExtensionsTest.csModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManager/MMPatchLoader.csModuleManager/Extensions/UrlConfigExtensions.csModuleManager/Extensions/ConfigNodeExtensions.cs70eca817c4d6d398c471b84d6ac0288ad4128e371506227482000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract PrettyConfig (for UrlConfig) 2017-09-23 21:31:22 -070070eca817c4d6d398c471b84d6ac0288ad4128e37Extract PrettyConfig (for UrlConfig)editModuleManagerTests/Extensions/UrlConfigExtensionsTest.cseditModuleManager/Extensions/UrlConfigExtensions.cseditModuleManagerTests/Extensions/ConfigNodeExtensionsTest.cseditModuleManager/Extensions/ConfigNodeExtensions.cseditModuleManager/MMPatchLoader.csModuleManagerTests/Extensions/UrlConfigExtensionsTest.cs55308af509bf7b8c082c641528df24847a5b59821506231836000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd one more test 2017-09-23 22:43:56 -070055308af509bf7b8c082c641528df24847a5b5982Add one more testeditModuleManagerTests/Extensions/UrlConfigExtensionsTest.csModuleManager/MMPatchLoader.cs1a7d1e36c64d27318b002a5505f5959be21551d11506234508000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake CheckNeeds static Can now be extracted 2017-09-23 23:28:28 -07001a7d1e36c64d27318b002a5505f5959be21551d1Make CheckNeeds staticeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csbc451c5bdf2dafa43972a7930ee9483a5366e8611506234530000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comThis can already be static 2017-09-23 23:28:50 -0700bc451c5bdf2dafa43972a7930ee9483a5366e861This can already be staticeditModuleManager/MMPatchLoader.csModuleManager/Extensions/NodeStackExtensions.cs60cb30aa9e47a292bb08be23f46bfd8d8caaccc51506579014000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comRemove unnecessary Using 2017-09-27 23:10:14 -070060cb30aa9e47a292bb08be23f46bfd8d8caaccc5Remove unnecessary UsingeditModuleManager/Extensions/NodeStackExtensions.csModuleManagerTests/Extensions/UrlConfigExtensionsTest.csModuleManager/Extensions/UrlConfigExtensions.csa035b672edecdefd73f22fefef00c56a9270360f1506579216000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comImprove url and node printing * Handle null name explicitly * Include url when printing a UrlConfig 2017-09-27 23:13:36 -0700a035b672edecdefd73f22fefef00c56a9270360fImprove url and node printingeditModuleManagerTests/Extensions/UrlConfigExtensionsTest.cseditModuleManager/Extensions/UrlConfigExtensions.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/MMPatchLoader.csModuleManagerTests/NeedsCheckerTest.csModuleManager/NeedsChecker.csModuleManager/ModuleManager.csproj59a922067956db3ba32b6c248e537149584252961506579311000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract CheckNeeds Equality vs sameness mostly not tested for now, need to determine desired behavior 2017-09-27 23:15:11 -070059a922067956db3ba32b6c248e53714958425296Extract CheckNeedseditModuleManagerTests/ModuleManagerTests.csprojaddModuleManager/NeedsChecker.csaddModuleManagerTests/NeedsCheckerTest.cseditModuleManager/MMPatchLoader.cseditModuleManager/ModuleManager.csprojModuleManager/MMPatchLoader.cs784e7a80059574c888b4626a711359ce5463a5ae1506582649000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEnsure that final string printed to the screen is the actual status 2017-09-28 00:10:49 -0700784e7a80059574c888b4626a711359ce5463a5aeEnsure that final string printed to the screen is the actual statuseditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs13850b617ff7cdadd06a6bf943c7be22cf51b21a1506582681000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix up mod list logging * Use a string builder * Print assemblies in a nicer format (table) 2017-09-28 00:11:21 -070013850b617ff7cdadd06a6bf943c7be22cf51b21aFix up mod list loggingeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cscd3a4680ae697b04680743db8120434c42c135d01506652058000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUse Path.Combine It's more concise then concatenating with the separator char 2017-09-28 19:27:38 -0700cd3a4680ae697b04680743db8120434c42c135d0Use Path.CombineeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs901b5a5bc2035719e7e3da3fac1a354ee0cdea561506670295000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUnnecessary now 2017-09-29 00:31:35 -0700901b5a5bc2035719e7e3da3fac1a354ee0cdea56Unnecessary noweditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csa5b1547d4b6020ebad74d1e9cf2668fc9514e58e1506757571000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comImprove assembly list * Get rid of unused code * Include KSPAssembly version 2017-09-30 00:46:11 -0700a5b1547d4b6020ebad74d1e9cf2668fc9514e58eImprove assembly listeditModuleManager/MMPatchLoader.csgithttps://ksp.sarbian.com/jenkins/user/joeydwongjoeydwong