Started by GitHub push by sarbian216b817fc57c564835ed653e005e14b28ea59e76296b817fc57c564835ed653e005e14b28ea59e7629refs/remotes/origin/dev6b817fc57c564835ed653e005e14b28ea59e76296b817fc57c564835ed653e005e14b28ea59e7629refs/remotes/origin/dev6b817fc57c564835ed653e005e14b28ea59e76296b817fc57c564835ed653e005e14b28ea59e7629refs/remotes/origin/devhttps://github.com/sarbian/ModuleManager.githttps://ksp.sarbian.com/jenkins/user/videogamer0907/my-views/view/all/job/ModuleManager-Dev/21/artifacthttps://ksp.sarbian.com/jenkins/user/videogamer0907/my-views/view/all/job/ModuleManager-Dev/changeshttps://ksp.sarbian.com/jenkins/user/videogamer0907/my-views/view/all/job/ModuleManager-Dev/21/https://ksp.sarbian.com/jenkins/user/videogamer0907/my-views/view/all/job/ModuleManager-Dev/21/testReportfalse#2155546498ModuleManager-Dev #2121falsefalse21101FAILURE1505495559469https://ksp.sarbian.com/jenkins/user/videogamer0907/my-views/view/all/job/ModuleManager-Dev/21/ModuleManagerTests/ModuleManagerTests.csprojModuleManager/MMPatchLoader.csModuleManager/Command.csModuleManager/CommandParser.csModuleManager/ModuleManager.csprojModuleManagerTests/CommandParserTest.csa9a990d7f119d0d2d30f50f85a10d8398d27c2b11505358686000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comPull Command and ParseCommand out of MMPatchLoader Would be nice if enums allowed static methods 2017-09-13 20:11:26 -0700a9a990d7f119d0d2d30f50f85a10d8398d27c2b1Pull Command and ParseCommand out of MMPatchLoaderaddModuleManager/CommandParser.cseditModuleManager/MMPatchLoader.cseditModuleManager/ModuleManager.csprojeditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/CommandParserTest.csaddModuleManager/Command.csModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/MMPatchLoader.csModuleManager/ModuleManager.csprojModuleManager/Extensions/ConfigNodeExtensions.csb43f79b20c2759797aa1ad6323331d3e5e834b851505358686000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract ShallowCopy "this" is the node you're copying to so that the extension method is only modifying "its" node 2017-09-13 20:11:26 -0700b43f79b20c2759797aa1ad6323331d3e5e834b85Extract ShallowCopyeditModuleManager/ModuleManager.csprojaddModuleManagerTests/Extensions/ConfigNodeExtensionsTest.cseditModuleManager/MMPatchLoader.cseditModuleManagerTests/ModuleManagerTests.csprojaddModuleManager/Extensions/ConfigNodeExtensions.csTestUtilsTests/UrlBuilderTest.csTestUtils/URLBuilder.cs534eee2d6cc93d7e3bf6a8899e201f674c957cb21505358686000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDon't create duplicates in UrlBuilder 2017-09-13 20:11:26 -0700534eee2d6cc93d7e3bf6a8899e201f674c957cb2Don't create duplicates in UrlBuildereditTestUtilsTests/UrlBuilderTest.cseditTestUtils/URLBuilder.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/Collections/ArrayEnumerator.csModuleManager/ModuleManager.csprojModuleManagerTests/Collections/ArrayEnumeratorTest.cs24f21435b3efc6e0064de654a679ec8d5afba2d31505362248000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd ArrayEnumerator Enumerates arrays in a garbage-free way 2017-09-13 21:10:48 -070024f21435b3efc6e0064de654a679ec8d5afba2d3Add ArrayEnumeratoraddModuleManagerTests/Collections/ArrayEnumeratorTest.cseditModuleManager/ModuleManager.csprojeditModuleManagerTests/ModuleManagerTests.csprojaddModuleManager/Collections/ArrayEnumerator.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/PatchListTest.csModuleManager/PatchList.csModuleManager/ModuleManager.csproj7138bbca48c127dda038d199b1518a0dfc84a0a51505365141000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comPatchList list of patches, 'nuff said 2017-09-13 21:59:01 -07007138bbca48c127dda038d199b1518a0dfc84a0a5PatchListeditModuleManager/ModuleManager.csprojeditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/PatchListTest.csaddModuleManager/PatchList.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/PatchExtractorTest.csModuleManager/PatchExtractor.csModuleManager/ModuleManager.csproj9a55a65987f83afbc0d2df67b0c1e4c8d80a47e61505365320000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd PatchExtractor Extracts patches from the game database and sorts them 2017-09-13 22:02:00 -07009a55a65987f83afbc0d2df67b0c1e4c8d80a47e6Add PatchExtractoraddModuleManager/PatchExtractor.csaddModuleManagerTests/PatchExtractorTest.cseditModuleManager/ModuleManager.csprojeditModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Extensions/UrlConfigExtensionsTest.csModuleManager/ModuleManager.csprojModuleManager/Extensions/UrlConfigExtensions.cs90027c2abade9c7f035948bcfed4e6cddbc32e7e1505367118000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd SafeUrl extension method for UrlConfig Makes sure logging doesn't mess up, and fixes the weird quirk where a node with a name value ends up displaying that instead of its actual name 2017-09-13 22:31:58 -070090027c2abade9c7f035948bcfed4e6cddbc32e7eAdd SafeUrl extension method for UrlConfigeditModuleManager/ModuleManager.csprojeditModuleManagerTests/ModuleManagerTests.csprojaddModuleManager/Extensions/UrlConfigExtensions.csaddModuleManagerTests/Extensions/UrlConfigExtensionsTest.csModuleManager/PatchExtractor.csModuleManager/MMPatchLoader.csModuleManager/PatchProgress.cs504354d57b7ffdb5128e48cdccccd9010ed22e631505369949000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUse SafeUrl in logging 2017-09-13 23:19:09 -0700504354d57b7ffdb5128e48cdccccd9010ed22e63Use SafeUrl in loggingeditModuleManager/PatchExtractor.cseditModuleManager/MMPatchLoader.cseditModuleManager/PatchProgress.csModuleManager/MMPatchLoader.cs331ab180365a6e243f4d2f192197b762a6820ba01505369949000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comRemove unused Doesn't really have any benefit 2017-09-13 23:19:09 -0700331ab180365a6e243f4d2f192197b762a6820ba0Remove unusededitModuleManager/MMPatchLoader.csModuleManagerTests/PatchExtractorTest.csModuleManager/IPatchProgress.csModuleManager/PatchExtractor.csModuleManagerTests/PatchProgressTest.csModuleManager/PatchProgress.cs3f8adeeb9ca45e6afd879602d8bf5176ba6f7a651505370312000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comLog when BEFORE or AFTER patch deleted This is pretty much equivalent to unsatisfied NEEDS, so it should be noted as such. Also log on an unsatisfied FOR, although this shouldn't happen (make it a warning) 2017-09-13 23:25:12 -07003f8adeeb9ca45e6afd879602d8bf5176ba6f7a65Log when BEFORE or AFTER patch deletededitModuleManager/IPatchProgress.cseditModuleManager/PatchProgress.cseditModuleManager/PatchExtractor.cseditModuleManagerTests/PatchExtractorTest.cseditModuleManagerTests/PatchProgressTest.csModuleManager/PatchList.csModuleManagerTests/PatchListTest.cs50346dc2f17ca43b5d47132e636df295ae95a9921505370333000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix case issues Mods may not be lowercase to begin with, need to handle this 2017-09-13 23:25:33 -070050346dc2f17ca43b5d47132e636df295ae95a992Fix case issueseditModuleManagerTests/PatchListTest.cseditModuleManager/PatchList.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/MMPatchLoader.csModuleManager/Extensions/StringExtensions.csModuleManager/ModuleManager.csprojModuleManagerTests/Extensions/StringExtensionsTest.cs99bc0bf583693dd2d83a94d93d1043bc28d037081505371760000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract IsBracketBalanced 2017-09-13 23:49:20 -070099bc0bf583693dd2d83a94d93d1043bc28d03708Extract IsBracketBalancedaddModuleManager/Extensions/StringExtensions.cseditModuleManager/MMPatchLoader.cseditModuleManager/ModuleManager.csprojeditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/Extensions/StringExtensionsTest.csModuleManager/PatchExtractor.csModuleManagerTests/PatchExtractorTest.cse52a646ba73fb0639218d779508e7f110aaa1a3f1505372189000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comRemove bracket unbalanced nodes when sorting 2017-09-13 23:56:29 -0700e52a646ba73fb0639218d779508e7f110aaa1a3fRemove bracket unbalanced nodes when sortingeditModuleManager/PatchExtractor.cseditModuleManagerTests/PatchExtractorTest.csModuleManager/MMPatchLoader.cs8a8131017d7a26286b0b9f0bf8c64dc4da0d1ecc1505372266000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUnused method 2017-09-13 23:57:46 -07008a8131017d7a26286b0b9f0bf8c64dc4da0d1eccUnused methodeditModuleManager/MMPatchLoader.csModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManager/MMPatchLoader.csModuleManager/Extensions/ConfigNodeExtensions.cs5a468bea8d010631895e3e7bdbf40a5682748b131505374314000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comBring back DeepCopy Apparently KSP's default implementation fails on badly formed nodes 2017-09-14 00:31:54 -07005a468bea8d010631895e3e7bdbf40a5682748b13Bring back DeepCopyeditModuleManager/MMPatchLoader.cseditModuleManager/Extensions/ConfigNodeExtensions.cseditModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManager/MMPatchLoader.cs2e5854df9056d21d8efcac868de3d527e1ddd3191505374892000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix bad region 2017-09-14 00:41:32 -07002e5854df9056d21d8efcac868de3d527e1ddd319Fix bad regioneditModuleManager/MMPatchLoader.csModuleManager/PatchExtractor.csModuleManagerTests/PatchExtractorTest.cs9bd8253f26f0aaf03891cbef10d5a3c27de3ec6d1505449711000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake sure badly formed mod passes are an error 2017-09-14 21:28:31 -07009bd8253f26f0aaf03891cbef10d5a3c27de3ec6dMake sure badly formed mod passes are an erroreditModuleManagerTests/PatchExtractorTest.cseditModuleManager/PatchExtractor.csModuleManager/MMPatchLoader.csb0102431984947e8cff86aa4e7874b97119f23611505452838000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comThat's a bug 2017-09-14 22:20:38 -0700b0102431984947e8cff86aa4e7874b97119f2361That's a bugeditModuleManager/MMPatchLoader.csModuleManager/PatchExtractor.csModuleManager/Extensions/ConfigNodeExtensions.cscacc840da0d34307ef18796288eaafb30d2f32291505455034000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd some explanatory comments 2017-09-14 22:57:14 -0700cacc840da0d34307ef18796288eaafb30d2f3229Add some explanatory commentseditModuleManager/PatchExtractor.cseditModuleManager/Extensions/ConfigNodeExtensions.csModuleManagerTests/Extensions/ConfigNodeExtensionsTest.csModuleManager/PatchExtractor.csModuleManager/Extensions/ConfigNodeExtensions.csc00735d7f3322aba14159706f996e7c45bc13dff1505455076000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUnnecessary using directives 2017-09-14 22:57:56 -0700c00735d7f3322aba14159706f996e7c45bc13dffUnnecessary using directiveseditModuleManager/Extensions/ConfigNodeExtensions.cseditModuleManagerTests/Extensions/ConfigNodeExtensionsTest.cseditModuleManager/PatchExtractor.csModuleManager/MMPatchLoader.cs8d71ac691054fcc9e1fa236d4debbb2687be46321505455955000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUse sorted patches when applying Improves performance somewhat Verified that sorting patches takes almost no time even for a fairly large number of patches 2017-09-14 23:12:35 -07008d71ac691054fcc9e1fa236d4debbb2687be4632Use sorted patches when applyingeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csaa990db608166c83fd2fdbf9cd62fdba40788ff81505456264000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comRemove now-unnecessary try-catch There's already one around it and we no longer care about removing patches from the database at this stage 2017-09-14 23:17:44 -0700aa990db608166c83fd2fdbf9cd62fdba40788ff8Remove now-unnecessary try-catcheditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.cs3ca180142d1cc787cf92ceae683b64cbab04c9641505456479000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comReplace big if with guard clause Reduces indentation. Insert nodes shouldn't exist here anyway 2017-09-14 23:21:19 -07003ca180142d1cc787cf92ceae683b64cbab04c964Replace big if with guard clauseeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csec7c67cea50bc2b67ceadeac9b57ae3284816a241505456695000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comSimplify this It no longer has to look in actual passes here, so we can just use the name we want it to display. It does change the way it displays in the loading screen but that seems fine. 2017-09-14 23:24:55 -0700ec7c67cea50bc2b67ceadeac9b57ae3284816a24Simplify thiseditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csModuleManager/PatchExtractor.csModuleManagerTests/PatchExtractorTest.cs809831304b89671c1abf746c91f5d166dd5a1a861505458924000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comInvalid command = error on the patch extractor This seems like the right place to check it 2017-09-15 00:02:04 -0700809831304b89671c1abf746c91f5d166dd5a1a86Invalid command = error on the patch extractoreditModuleManager/MMPatchLoader.cseditModuleManagerTests/PatchExtractorTest.cseditModuleManager/PatchExtractor.csgithttps://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong