Started by GitHub push by sarbian23a6d651959d203e0b4103ecf51746488ca88a44a2a6d651959d203e0b4103ecf51746488ca88a44a2refs/remotes/origin/deva6d651959d203e0b4103ecf51746488ca88a44a2a6d651959d203e0b4103ecf51746488ca88a44a2refs/remotes/origin/deva6d651959d203e0b4103ecf51746488ca88a44a2a6d651959d203e0b4103ecf51746488ca88a44a2refs/remotes/origin/devhttps://github.com/sarbian/ModuleManager.gitfalse#2335706498ModuleManager-Dev #2323falsefalse23111FAILURE1507964973984https://ksp.sarbian.com/jenkins/user/videogamer0907/my-views/view/all/job/ModuleManager-Dev/23/ModuleManager/MMPatchLoader.cs9cf00111aa40a9ae6a39ff6714613c5d68d200a51506826253000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAccidentally removed 2017-09-30 19:50:53 -07009cf00111aa40a9ae6a39ff6714613c5d68d200a5Accidentally removededitModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csModuleManager/PatchExtractor.csModuleManagerTests/PatchExtractorTest.csfde3fbc3782c23cbc0527e4128c49d08eb2cfbba1506883658000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMove tracking number of patches from mod list to sorting patches 2017-10-01 11:47:38 -0700fde3fbc3782c23cbc0527e4128c49d08eb2cfbbaMove tracking number of patcheseditModuleManagerTests/PatchExtractorTest.cseditModuleManager/MMPatchLoader.cseditModuleManager/PatchExtractor.csModuleManager/IPatchProgress.csModuleManager/PatchProgress.csf09622f190f8bb289df5229f6c45cf1a718858381506883815000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comPut progress counts in their own object Allows the same counts to be used with a different logger. Also remove unused setter for NeedsUnsatisfiedRootCount 2017-10-01 11:50:15 -0700f09622f190f8bb289df5229f6c45cf1a71885838Put progress counts in their own objecteditModuleManager/IPatchProgress.cseditModuleManager/PatchProgress.csModuleManager/MMPatchLoader.csce43104059244df30ebad90bfd928ab08ec4bd7d1506890154000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMove exception handling out of FIleSHA Callers should be aware of exceptions anyway 2017-10-01 13:35:54 -0700ce43104059244df30ebad90bfd928ab08ec4bd7dMove exception handling out of FIleSHAeditModuleManager/MMPatchLoader.csModuleManager/Utils/FileUtils.csModuleManager/MMPatchLoader.csModuleManager/ModuleManager.csproj2dc9f9121be35ea1c30ada09c0dc0456cc7b0c1a1506892495000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract FileSHA Interacts with the file system so difficult to test unfortunately 2017-10-01 14:14:55 -07002dc9f9121be35ea1c30ada09c0dc0456cc7b0c1aExtract FileSHAeditModuleManager/MMPatchLoader.csaddModuleManager/Utils/FileUtils.cseditModuleManager/ModuleManager.csprojModuleManager/MMPatchLoader.cs6f2693924bbd2b85b5b4ea598a8437f0c9f2a49c1506894329000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFix unassigned variable 2017-10-01 14:45:29 -07006f2693924bbd2b85b5b4ea598a8437f0c9f2a49cFix unassigned variableeditModuleManager/MMPatchLoader.csModuleManager/MMPatchLoader.csf3352db53fdd4685c73706845d0fea5e435330ff1507083585000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake this extractable 2017-10-03 19:19:45 -0700f3352db53fdd4685c73706845d0fea5e435330ffMake this extractableeditModuleManager/MMPatchLoader.csModuleManager/ModListGenerator.csModuleManager/MMPatchLoader.csModuleManager/ModuleManager.csproje40426a633c90762f8fb034d561aefb388f576341507085540000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract GenerateModList Unfortunately interacts with AssemblyLoader and the file system so not really testable 2017-10-03 19:52:20 -0700e40426a633c90762f8fb034d561aefb388f57634Extract GenerateModListeditModuleManager/MMPatchLoader.csaddModuleManager/ModListGenerator.cseditModuleManager/ModuleManager.csprojModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Collections/MessageQueueTest.csModuleManager/ModuleManager.csprojModuleManager/Collections/MessageQueue.cs7a2e18da8eb06d4215e4d034984e98ca0e770af81507085733000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd MessageQueue 2017-10-03 19:55:33 -07007a2e18da8eb06d4215e4d034984e98ca0e770af8Add MessageQueueaddModuleManager/Collections/MessageQueue.cseditModuleManagerTests/ModuleManagerTests.csprojeditModuleManager/ModuleManager.csprojaddModuleManagerTests/Collections/MessageQueueTest.csModuleManager/Logging/NormalMessage.csModuleManager/Logging/ILogMessage.csModuleManager/Logging/QueueLogger.csModuleManagerTests/Logging/NormalMessageTest.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/Logging/ExceptionMessage.csModuleManagerTests/Logging/ExceptionMessageTest.csModuleManager/ModuleManager.csprojModuleManagerTests/Logging/QueueLoggerTest.cs7d0c5878014b0e000808f8cb7b04d5665e280aa91507085739000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd QueueLogger and supporting classes Allows logging to a queue 2017-10-03 19:55:39 -07007d0c5878014b0e000808f8cb7b04d5665e280aa9Add QueueLogger and supporting classesaddModuleManager/Logging/ILogMessage.csaddModuleManager/Logging/ExceptionMessage.cseditModuleManager/ModuleManager.csprojeditModuleManagerTests/ModuleManagerTests.csprojaddModuleManager/Logging/NormalMessage.csaddModuleManager/Logging/QueueLogger.csaddModuleManagerTests/Logging/ExceptionMessageTest.csaddModuleManagerTests/Logging/NormalMessageTest.csaddModuleManagerTests/Logging/QueueLoggerTest.csModuleManagerTests/PatchProgressTest.csModuleManager/PatchProgress.csd1975dbdd1bc2c61488644dd8e53ab92c557befd1507170155000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDon't keep track of non-root needs unsatisfied Isn't used anywhere 2017-10-04 19:22:35 -0700d1975dbdd1bc2c61488644dd8e53ab92c557befdDon't keep track of non-root needs unsatisfiededitModuleManagerTests/PatchProgressTest.cseditModuleManager/PatchProgress.csModuleManager/ModuleManager.csprojModuleManager/FatalErrorHandler.cs78d46359c18677bf34a7cbe0f1b510e2c2b9dc1e1507181240000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd FatalErrorHandler Allows us to display a message to the user and quit when an unrecoverable error occurs. Can't really be tested unfortunately. 2017-10-04 22:27:20 -070078d46359c18677bf34a7cbe0f1b510e2c2b9dc1eAdd FatalErrorHandleraddModuleManager/FatalErrorHandler.cseditModuleManager/ModuleManager.csprojModuleManagerTests/Threading/BackgroundTaskTest.csModuleManager/Threading/BackgroundTask.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Threading/TaskStatusTest.csModuleManager/Threading/ITaskStatus.csModuleManager/Threading/TaskStatus.csModuleManager/Threading/TaskStatusWrapper.csModuleManager/ModuleManager.csproj172e2f3c845c42f1a4b4fb14182314891b00939a1507181921000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd background task support Allows a background task to be run and monitored, including if it exits due to an exception 2017-10-04 22:38:41 -0700172e2f3c845c42f1a4b4fb14182314891b00939aAdd background task supportaddModuleManager/Threading/ITaskStatus.csaddModuleManager/Threading/TaskStatusWrapper.csaddModuleManagerTests/Threading/BackgroundTaskTest.csaddModuleManagerTests/Threading/TaskStatusTest.csaddModuleManager/Threading/BackgroundTask.cseditModuleManagerTests/ModuleManagerTests.csprojaddModuleManager/Threading/TaskStatus.cseditModuleManager/ModuleManager.csprojModuleManagerTests/PatchProgressTest.csModuleManager/IPatchProgress.csModuleManager/Progress/IPatchProgress.csModuleManagerTests/Progress/PatchProgressTest.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/Progress/PatchProgress.csModuleManager/ModuleManager.csprojModuleManager/PatchProgress.cs7f9088719a5d478f5b5119fe7123ad06ba17a3401507182502000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comBegin creating Progress namespace 2017-10-04 22:48:22 -07007f9088719a5d478f5b5119fe7123ad06ba17a340Begin creating Progress namespaceaddModuleManager/Progress/PatchProgress.csdeleteModuleManagerTests/PatchProgressTest.csaddModuleManager/Progress/IPatchProgress.cseditModuleManager/ModuleManager.csprojdeleteModuleManager/IPatchProgress.csaddModuleManagerTests/Progress/PatchProgressTest.csdeleteModuleManager/PatchProgress.cseditModuleManagerTests/ModuleManagerTests.csprojModuleManager/ModListGenerator.csModuleManager/MMPatchLoader.csModuleManagerTests/PatchExtractorTest.csModuleManager/NeedsChecker.csModuleManager/PatchExtractor.csModuleManager/Progress/IPatchProgress.csModuleManagerTests/Progress/PatchProgressTest.csModuleManagerTests/NeedsCheckerTest.csModuleManager/Progress/PatchProgress.csModuleManager/PatchContext.csb0f72c293f1ae36994c73c628eca346906ba59b51507182930000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comFinish creating Progress namespace 2017-10-04 22:55:30 -0700b0f72c293f1ae36994c73c628eca346906ba59b5Finish creating Progress namespaceeditModuleManagerTests/NeedsCheckerTest.cseditModuleManager/MMPatchLoader.cseditModuleManager/PatchContext.cseditModuleManager/Progress/PatchProgress.cseditModuleManager/ModListGenerator.cseditModuleManager/NeedsChecker.cseditModuleManagerTests/Progress/PatchProgressTest.cseditModuleManager/Progress/IPatchProgress.cseditModuleManager/PatchExtractor.cseditModuleManagerTests/PatchExtractorTest.csModuleManagerTests/Progress/PatchProgressTest.csModuleManager/MMPatchLoader.cs3dbfbb1ad344efa8326def114cea916d685aefc01507182954000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comUnnecessary directives 2017-10-04 22:55:54 -07003dbfbb1ad344efa8326def114cea916d685aefc0Unnecessary directiveseditModuleManagerTests/Progress/PatchProgressTest.cseditModuleManager/MMPatchLoader.csModuleManagerTests/NeedsCheckerTest.cs92ae91f6a8fef397d17f658e67538bc060a50d231507184003000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd needs test for and/or and capitalization 2017-10-04 23:13:23 -070092ae91f6a8fef397d17f658e67538bc060a50d23Add needs test for and/or and capitalizationeditModuleManagerTests/NeedsCheckerTest.csModuleManager/MMPatchLoader.csModuleManagerTests/Utils/CounterTest.csModuleManager/Progress/ProgressCounter.csModuleManager/Progress/IPatchProgress.csModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Progress/PatchProgressTest.csModuleManager/Utils/Counter.csModuleManager/ModuleManager.csprojModuleManager/Progress/PatchProgress.cs6596b47e64677ee615718e6194d85e7ee67876591507186313000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comSeparate out progress counter Make it so that all the values can be incremented but not otherwise messed with. Allow a new progress tracker to be initialized that shares a counter with another but uses a different logger 2017-10-04 23:51:53 -07006596b47e64677ee615718e6194d85e7ee6787659Separate out progress countereditModuleManager/MMPatchLoader.cseditModuleManagerTests/ModuleManagerTests.csprojaddModuleManagerTests/Utils/CounterTest.csaddModuleManager/Utils/Counter.cseditModuleManager/Progress/IPatchProgress.csaddModuleManager/Progress/ProgressCounter.cseditModuleManager/ModuleManager.csprojeditModuleManager/Progress/PatchProgress.cseditModuleManagerTests/Progress/PatchProgressTest.csModuleManagerTests/Utils/CounterTest.csModuleManager/Utils/Counter.cs9a05e1b8902043f474c6d8bec4ed88da10ecf3281507187146000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEnsure Counter behaves like an int 2017-10-05 00:05:46 -07009a05e1b8902043f474c6d8bec4ed88da10ecf328Ensure Counter behaves like an inteditModuleManager/Utils/Counter.cseditModuleManagerTests/Utils/CounterTest.csModuleManager/Utils/Counter.cs97368004915876f14236207ea72b490ed85c86e71507187157000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMore unnecessary using 2017-10-05 00:05:57 -070097368004915876f14236207ea72b490ed85c86e7More unnecessary usingeditModuleManager/Utils/Counter.csModuleManagerTests/NeedsCheckerTest.csa1af72527f8c6356509a9e12cfecea7c76a865701507341464000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comAdd test for ! (not) in :NEEDS 2017-10-06 18:57:44 -0700a1af72527f8c6356509a9e12cfecea7c76a86570Add test for ! (not) in :NEEDSeditModuleManagerTests/NeedsCheckerTest.csModuleManager/Progress/PatchProgress.csModuleManager/Command.csModuleManager/CommandParser.cs3a19ff8e6698a8f15660cc8cb2edacd3cb2fcf701507874242000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMore unnecessary using directives 2017-10-12 22:57:22 -07003a19ff8e6698a8f15660cc8cb2edacd3cb2fcf70More unnecessary using directiveseditModuleManager/Progress/PatchProgress.cseditModuleManager/CommandParser.cseditModuleManager/Command.csModuleManagerTests/ModuleManagerTests.csprojModuleManager/MMPatchLoader.csModuleManagerTests/PatchApplierTest.csModuleManager/ModuleManager.csprojModuleManager/PatchApplier.cse9c341a3e1fcfa5061a441bc9c1455acd60bf2751507874639000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comExtract application of patches to its own thread Allows it to not be bound by logging which can be slow 2017-10-12 23:03:59 -0700e9c341a3e1fcfa5061a441bc9c1455acd60bf275Extract application of patches to its own threadeditModuleManager/ModuleManager.csprojaddModuleManager/PatchApplier.cseditModuleManager/MMPatchLoader.csaddModuleManagerTests/PatchApplierTest.cseditModuleManagerTests/ModuleManagerTests.csprojModuleManagerTests/Progress/PatchProgressTest.csModuleManager/Progress/PatchProgress.csb0e02e098a73aa19b1ef214f75aaaec2790d33ce1507875363000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comTest and fix PatchProgress.ProgressFraction Patches are now only counted after needs are checked, so this shouldn't consider needs unsatisfied nodes 2017-10-12 23:16:03 -0700b0e02e098a73aa19b1ef214f75aaaec2790d33ceTest and fix PatchProgress.ProgressFractioneditModuleManager/Progress/PatchProgress.cseditModuleManagerTests/Progress/PatchProgressTest.csModuleManager/MMPatchLoader.csba24af38d82bae9f5ed17dbf5115a7bed26441a81507943655000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comTweak 2017-10-13 18:14:15 -0700ba24af38d82bae9f5ed17dbf5115a7bed26441a8TweakeditModuleManager/MMPatchLoader.csgithttps://ksp.sarbian.com/jenkins/user/joeydwongjoeydwong