Started by user sarbiansarbiansarbian249322308c8044cdd27f366411d7eec52fa9f88a9a9322308c8044cdd27f366411d7eec52fa9f88a9arefs/remotes/origin/dev9322308c8044cdd27f366411d7eec52fa9f88a9a9322308c8044cdd27f366411d7eec52fa9f88a9arefs/remotes/origin/dev9322308c8044cdd27f366411d7eec52fa9f88a9a9322308c8044cdd27f366411d7eec52fa9f88a9arefs/remotes/origin/devhttps://github.com/sarbian/ModuleManager.gitfalse#2475616498ModuleManager-Dev #2424falsefalse245FAILURE1508796097180https://ksp.sarbian.com/jenkins/user/videogamer0907/my-views/view/all/job/ModuleManager-Dev/24/ModuleManager/PatchApplier.cs5fe79fd6b901eed0768ec3452ab65c97389b29711507966210000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comOnly convert to array once per pass This is expensive 2017-10-14 00:30:10 -07005fe79fd6b901eed0768ec3452ab65c97389b2971Only convert to array once per passeditModuleManager/PatchApplier.csModuleManager/PatchApplier.cs20e619287f1e8637476ada51f3a2470200b9b09b1507966210000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMake node matching its own method Saves a level of indentation 2017-10-14 00:30:10 -070020e619287f1e8637476ada51f3a2470200b9b09bMake node matching its own methodeditModuleManager/PatchApplier.csModuleManagerTests/PatchApplierTest.csModuleManager/PatchApplier.cs244af1ac93d9c32a017666ff0e59e88d01c754491507966210000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comLoop only applies to edit patches Saves another indentation level. Also remove MM_PATCH_LOOP {} after done 2017-10-14 00:30:10 -0700244af1ac93d9c32a017666ff0e59e88d01c75449Loop only applies to edit patcheseditModuleManagerTests/PatchApplierTest.cseditModuleManager/PatchApplier.csModuleManagerTests/PatchApplierTest.csModuleManager/PatchApplier.cscdeb5f76dbf574eb5d310c71ea5cc605f70775081507966210000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comDon't convert to an array at all It's not necessary. Also don't use switch - makes things cleaner. It's only 3 cases anyway 2017-10-14 00:30:10 -0700cdeb5f76dbf574eb5d310c71ea5cc605f7077508Don't convert to an array at alleditModuleManagerTests/PatchApplierTest.cseditModuleManager/PatchApplier.csModuleManager/MMPatchLoader.cs30eeb6f3c1a6ba1525b762ef6583f362b84e64ab1507966210000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEnsure that user gets updates during long passes The patcher can potentially generate log messages faster than the main thread can log them, causing frames that are noticeably long with no updates. This ensures that yields still happen then. Verified that this does not meaningfully affect performance. Previous tests suggest that the time wasted by waiting until the next frame is relatively small. 2017-10-14 00:30:10 -070030eeb6f3c1a6ba1525b762ef6583f362b84e64abEnsure that user gets updates during long passeseditModuleManager/MMPatchLoader.csModuleManager/PatchApplier.cs7e42de5a4e85a83ef6711885255a9f1b8b64aa0d1508305795000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comWithout switch, i is valid here 2017-10-17 22:49:55 -07007e42de5a4e85a83ef6711885255a9f1b8b64aa0dWithout switch, i is valid hereeditModuleManager/PatchApplier.csModuleManager/MMPatchLoader.csdc1a167b0874120c893962e097388bd8be2a84e31508306437000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comEnsure time between each check of the log queue This prevents the queue from being locked too often, slowing down the patching thread 2017-10-17 23:00:37 -0700dc1a167b0874120c893962e097388bd8be2a84e3Ensure time between each check of the log queueeditModuleManager/MMPatchLoader.csModuleManager/PatchApplier.csec5310bdfa4ebd10da8de9e675a2150d3beff0981508306884000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comConvert to an array initially Apparently it saves a bit of time, and this won't be changed while patches run 2017-10-17 23:08:04 -0700ec5310bdfa4ebd10da8de9e675a2150d3beff098Convert to an array initiallyeditModuleManager/PatchApplier.csModuleManager/PatchApplier.cs7cc6c5130dc9fe86d6bed7158b1390be88fa5edf1508307776000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comHaving an actual array here no longer necessary 2017-10-17 23:22:56 -07007cc6c5130dc9fe86d6bed7158b1390be88fa5edfHaving an actual array here no longer necessaryeditModuleManager/PatchApplier.csModuleManager/PatchApplier.csbd82d53b561931630a1c5ddda4491e56ab46e7271508307795000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comApparently Linq slows things down I guess it matters at scale 2017-10-17 23:23:15 -0700bd82d53b561931630a1c5ddda4491e56ab46e727Apparently Linq slows things downeditModuleManager/PatchApplier.csModuleManager/PatchApplier.csce3893f9682c3dae5232491b3ee9f4f97a6e3b2a1508310796000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comImprove access of name a bit Looks like GetValue("name") has a bit of overhead, instead we can check if the UrlConfig's type == name 2017-10-18 00:13:16 -0700ce3893f9682c3dae5232491b3ee9f4f97a6e3b2aImprove access of name a biteditModuleManager/PatchApplier.csModuleManager/PatchApplier.cs203ad88debd4cd772d754da569e35d0efd2419431508312589000https://ksp.sarbian.com/jenkins/user/joeydwongjoeydwongjoeydwong@gmail.comMove loop out of loop This is all a bit loopy 2017-10-18 00:43:09 -0700203ad88debd4cd772d754da569e35d0efd241943Move loop out of loopeditModuleManager/PatchApplier.csgithttps://ksp.sarbian.com/jenkins/user/joeydwongjoeydwong