Skip to content
Success

Changes

Summary

  1. Fix the warning for hyperbolic target orbits (commit: f9185c9) (details)
  2. Fix clamping of attach altitude (commit: f679d4d) (details)
  3. Ignore attach altitude if its checkbox is disabled (commit: 3da86ba) (details)
  4. Warn when retrograde inclination requires dog-leg (commit: 53dfc32) (details)
  5. Launch-into-plane target must be in the same SoI (commit: b52b43b) (details)
  6. Slightly different fix for low eccentricity (commit: ea92a83) (details)
Commit f9185c9b213b892129357b136f0a2fe0e3ae3a55 by mrev1995
Fix the warning for hyperbolic target orbits

Hyperbolic orbits have an apoapis _radius_ <0; apoapsis _altitude_
between -MainBody.Radius and 0 is still elliptical. It is still wrong to
have the periapsis be greater than the apoapsis, though, but that is
handled by a different check (and shows a different warning message).
(commit: f9185c9)
The file was modified MechJeb2/MechJebModuleAscentMenu.cs (diff)
Commit f679d4d0bb8b88adb286383bc1805a8b46a1b1a6 by mrev1995
Fix clamping of attach altitude

It should be between peR and apR (if apR > 0). Also clamp apR to be <0
or >= peR.
(commit: f679d4d)
The file was modified MechJeb2/MechJebModulePSGGlueBall.cs (diff)
Commit 3da86ba47858c6755dc7c6bd00a385df8c89c523 by mrev1995
Ignore attach altitude if its checkbox is disabled

Previously, for circular orbits, the attach altitude was still used as
final radius for the terminal constraints, even if the attach altitude
checkbox was _unticked_; it should be using the semi-major axis (or the
periapsis, or the apoapsis; all three are the same) of the orbit in that
case. This causes the final orbit to be incorrect if the target orbit is
(almost) circular.
(commit: 3da86ba)
The file was modified MechJebLib/PSG/AscentBuilder.cs (diff)
Commit 53dfc3289babbd2e6b7e2fa6ed71ee58d44d1a4a by mrev1995
Warn when retrograde inclination requires dog-leg

A retrograde near-equatorial orbit requires just as much of a dog-leg as
a prograde near-equatorial orbit. Warn the user in the same way for
those (possibly unreachable) orbits.
(commit: 53dfc32)
The file was modified MechJeb2/MechJebModuleAscentMenu.cs (diff)
Commit b52b43b26f726c386d924b170010365fe9453265 by mrev1995
Launch-into-plane target must be in the same SoI

For example; launch into the plane of Mars, when launching from Earth,
takes Mars' inclination and LAN relative to the Sun; and launches to an
orbit with that inclination and LAN relative to Earth. This does not
result in an orbit in the "same plane as" Mars (which is in fact
physically impossible).
(commit: b52b43b)
The file was modified MechJeb2/CachedLocalizer.cs (diff)
The file was modified MechJeb2/MechJebModuleAscentMenu.cs (diff)
The file was modified Localization/en-us.cfg (diff)
Commit ea92a8303784842ea80caad078bf631a07fa917a by lamont
Slightly different fix for low eccentricity

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
(commit: ea92a83)
The file was modified MechJebLib/PSG/AscentBuilder.cs (diff)