Skip to content
Failed

Changes

Summary

  1. Extract RemoveWS (commit: 180c2ee) (details)
  2. Fix logging (commit: 20a8afb) (details)
  3. Extract PrettyPrint (commit: 35d89f8) (details)
  4. Get rid of unnecesary using directives (commit: b52a80e) (details)
  5. Don't run PrePatchInit if cache is being used (commit: 45a4c0c) (details)
  6. Eliminate mods instance variable (commit: d397a80) (details)
  7. Use method param rather than instance var (commit: 12780a6) (details)
  8. Eliminate Update (commit: b6b628c) (details)
  9. Eliminate redundant logging (commit: 7a40730) (details)
  10. Keep track of progress fraction independently (commit: 7e714a4) (details)
  11. Make StatusUpdate less general (commit: 9236be1) (details)
  12. Move this (commit: 8696143) (details)
  13. Eliminate Progress instance variable (commit: 58d52d9) (details)
  14. Make more methods static (commit: 2645d22) (details)
  15. This is no longer necessary (commit: 824b077) (details)
  16. Move exception handling outside of PrettyConfig (commit: ac0a149) (details)
  17. Tweak test (commit: eb18b60) (details)
  18. Allow adding a ConfigNode.Value in initializer (commit: 4fdfb89) (details)
  19. Extract PrettyConfig (for UrlConfig) (commit: 70eca81) (details)
  20. Add one more test (commit: 55308af) (details)
  21. Make CheckNeeds static (commit: 1a7d1e3) (details)
  22. This can already be static (commit: bc451c5) (details)
  23. Remove unnecessary Using (commit: 60cb30a) (details)
  24. Improve url and node printing (commit: a035b67) (details)
  25. Extract CheckNeeds (commit: 59a9220) (details)
  26. Ensure that final string printed to the screen is the actual status (commit: 784e7a8) (details)
  27. Fix up mod list logging (commit: 13850b6) (details)
  28. Use Path.Combine (commit: cd3a468) (details)
  29. Unnecessary now (commit: 901b5a5) (details)
  30. Improve assembly list (commit: a5b1547) (details)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
The file was modified ModuleManager/Extensions/StringExtensions.cs (diff)
The file was modified ModuleManagerTests/Extensions/StringExtensionsTest.cs (diff)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
The file was modified ModuleManager/Extensions/ConfigNodeExtensions.cs (diff)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
The file was modified ModuleManagerTests/Extensions/ConfigNodeExtensionsTest.cs (diff)
Commit b52a80ea42e54cef13a90290c84eaeb493823649 by joeydwong
Get rid of unnecesary using directives
(commit: b52a80e)
The file was modified ModuleManagerTests/Extensions/UrlConfigExtensionsTest.cs (diff)
The file was modified ModuleManager/Extensions/UrlConfigExtensions.cs (diff)
Commit 45a4c0c2222159a75c17415c16ef499c9e785c71 by joeydwong
Don't run PrePatchInit if cache is being used
Mod list is not necessary
(commit: 45a4c0c)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit d397a80a1157dbd74374fc9abd8a4f9e4b1ebbb3 by joeydwong
Eliminate mods instance variable
(commit: d397a80)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit 12780a636b8ace12511cfd71d8ec9302b3a15201 by joeydwong
Use method param rather than instance var
Makes things easier to disentagle
(commit: 12780a6)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit b6b628cbed7806607a53eca2815e5e6be441eebf by joeydwong
Eliminate Update
Status will be updated when necessary anyway
(commit: b6b628c)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit 7a40730ad2b966bcc0eccee8968af93d950efaa7 by joeydwong
Eliminate redundant logging
MMPatchLoader logs this info itself
(commit: 7a40730)
The file was modified ModuleManager/ModuleManager.cs (diff)
Commit 7e714a47ba7f158718e878ffcad83324f5b30453 by joeydwong
Keep track of progress fraction independently
(commit: 7e714a4)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit 9236be107824be90bb56840dc20486aacb4fce7d by joeydwong
Make StatusUpdate less general
If cache is used, status only needs to be set once, no need to check it
every time
(commit: 9236be1)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit 8696143e2f3fd17dab5f92f81798141d4eeff69f by joeydwong
Move this
What I get for trying to make a bunch of changes and then split them
into small commits
(commit: 8696143)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit 58d52d9572fce69dc234dbd7d1ba4f5b78e48313 by joeydwong
Eliminate Progress instance variable
Make it local, inject where needed
(commit: 58d52d9)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit 2645d222082cf9a5913590ac97ad6253c6ec92a3 by joeydwong
Make more methods static
All their instance variable dependencies have been eliminated
(commit: 2645d22)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit 824b077dfc46eee2998bbc56ea3fb28f7c96b776 by joeydwong
This is no longer necessary
And will probably result in an error anyway
(commit: 824b077)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit ac0a149a21efe830c2c8e7df2468526395b6fe6d by joeydwong
Move exception handling outside of PrettyConfig
Callers really shouldn't be trying to print the result if it resulted in
an exception anyway
(commit: ac0a149)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit eb18b601a5662c74712af4eea74c0c60cb7ca467 by joeydwong
Tweak test
This isn't the case it was trying to test
(commit: eb18b60)
The file was modified ModuleManagerTests/Extensions/ConfigNodeExtensionsTest.cs (diff)
Commit 4fdfb8911e4b93c8f7c332e8fab077a8a1bc6861 by joeydwong
Allow adding a ConfigNode.Value in initializer
Not useful yet but maybe at some point
(commit: 4fdfb89)
The file was modified TestUtilsTests/TestConfigNodeTest.cs (diff)
The file was modified TestUtils/TestConfigNode.cs (diff)
Commit 70eca817c4d6d398c471b84d6ac0288ad4128e37 by joeydwong
Extract PrettyConfig (for UrlConfig)
(commit: 70eca81)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
The file was modified ModuleManager/Extensions/ConfigNodeExtensions.cs (diff)
The file was modified ModuleManager/Extensions/UrlConfigExtensions.cs (diff)
The file was modified ModuleManagerTests/Extensions/ConfigNodeExtensionsTest.cs (diff)
The file was modified ModuleManagerTests/Extensions/UrlConfigExtensionsTest.cs (diff)
The file was modified ModuleManagerTests/Extensions/UrlConfigExtensionsTest.cs (diff)
Commit 1a7d1e36c64d27318b002a5505f5959be21551d1 by joeydwong
Make CheckNeeds static
Can now be extracted
(commit: 1a7d1e3)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
The file was modified ModuleManager/Extensions/NodeStackExtensions.cs (diff)
Commit a035b672edecdefd73f22fefef00c56a9270360f by joeydwong
Improve url and node printing
* Handle null name explicitly
* Include url when printing a UrlConfig
(commit: a035b67)
The file was modified ModuleManagerTests/Extensions/UrlConfigExtensionsTest.cs (diff)
The file was modified ModuleManager/Extensions/UrlConfigExtensions.cs (diff)
Commit 59a922067956db3ba32b6c248e53714958425296 by joeydwong
Extract CheckNeeds
Equality vs sameness mostly not tested for now, need to determine
desired behavior
(commit: 59a9220)
The file was addedModuleManagerTests/NeedsCheckerTest.cs
The file was modified ModuleManager/ModuleManager.csproj (diff)
The file was modified ModuleManagerTests/ModuleManagerTests.csproj (diff)
The file was addedModuleManager/NeedsChecker.cs
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit 784e7a80059574c888b4626a711359ce5463a5ae by joeydwong
Ensure that final string printed to the screen is the actual status
(commit: 784e7a8)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit 13850b617ff7cdadd06a6bf943c7be22cf51b21a by joeydwong
Fix up mod list logging
* Use a string builder
* Print assemblies in a nicer format (table)
(commit: 13850b6)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit cd3a4680ae697b04680743db8120434c42c135d0 by joeydwong
Use Path.Combine
It's more concise then concatenating with the separator char
(commit: cd3a468)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit a5b1547d4b6020ebad74d1e9cf2668fc9514e58e by joeydwong
Improve assembly list
* Get rid of unused code
* Include KSPAssembly version
(commit: a5b1547)
The file was modified ModuleManager/MMPatchLoader.cs (diff)