Skip to content
[Jenkins]Jenkins
log in
Success

Changes

Summary

  1. Fix value assignment with * indexer (commit: c287441) (details)
  2. Reflection fields should be readonly (commit: 0aa64b5) (details)
  3. Create special GameData subdirectory (commit: ae2a14f) (details)
  4. Allow checking needs against directories (commit: 4a7e3c8) (details)
  5. Make patch stopwatch local (commit: 6c73797) (details)
  6. Make useCache local (commit: 267c64a) (details)
Commit c28744139c01a32caf2c98e8749ff9ba5276c3d5 by joeydwong
Fix value assignment with * indexer
Broken in #111 - probably an unusual case but it would have worked 
before.
Added tests to ensure that this fixes it.  Tests are not and will 
probably never cover all of MMPatchLoader.ModifyNode but useful to add 
bugfix cases here as they occur.
 (commit: c287441)
The file was modified ModuleManagerTests/ModuleManagerTests.csproj (diff)
The file was addedModuleManagerTests/MMPatchLoaderTest.cs
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit 0aa64b5f002c42400ffc3ef7f5499370f79a0313 by joeydwong
Reflection fields should be readonly
 (commit: 0aa64b5)
The file was modified TestUtils/UrlBuilder.cs (diff)
The file was modified ModuleManagerTests/NeedsCheckerTest.cs (diff)
Commit ae2a14f9154564360f07a6ef9d41ebc5add23eb6 by joeydwong
Create special GameData subdirectory
It's special
 (commit: ae2a14f)
The file was modified TestUtils/UrlBuilder.cs (diff)
The file was modified TestUtilsTests/UrlBuilderTest.cs (diff)
Commit 4a7e3c8a455084f1a05ec187819c46db66a2b1d3 by joeydwong
Allow checking needs against directories
If the needs string contains a / it will check for a directory with that 
path in GameData.  Notes:
* PluginData folders are excluded
* Leading and trailing slashes are allowed
* Multiple slashes together will be treated as a single slash
* Comaprison is case sensitive
 (commit: 4a7e3c8)
The file was modified ModuleManagerTests/NeedsCheckerTest.cs (diff)
The file was modified ModuleManager/NeedsChecker.cs (diff)
Commit 6c73797fa180d354ffabf9cc39500af6d3c625ab by joeydwong
Make patch stopwatch local
It's not needed outside of ProcessPatch(), which contains everything it 
needs to time
 (commit: 6c73797)
The file was modified ModuleManager/MMPatchLoader.cs (diff)
Commit 267c64af949627f55fe740296773b4d72ef88c7e by joeydwong
Make useCache local
Really only needed for a few lines in ProcessPatch()
 (commit: 267c64a)
The file was modified ModuleManager/MMPatchLoader.cs (diff)